rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-10-15 16:32:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(promql): centralize PromQL function registration in promql::functions (#9500)

Browse Source 
* refactor(promql): centralize PromQL function registration in promql::functions

Move the PromQL scalar UDF and UDAF registrations out of the query plan
decoder into a single `promql::functions::register_promql_functions`
entry point, so plan decoding no longer has to enumerate every PromQL
function implementation. The registered function set, aliases (e.g.
`prom_holt_winters`) and registration order are unchanged.

Add a registration test pinning the full set of `prom_*` scalar
functions and the `prom_holt_winters` alias, plus a decode regression
test covering the centralized registration path.

Fixes #9493

Signed-off-by: fengyue-xve <1759519137@qq.com>

* refactor(promql): register Ieee UDFs centrally and address review

Rebase onto main picked up #9479, which registered the Ieee comparison
and sqrt UDFs from the decoder directly. Register them from
`register_promql_functions` instead so the single entry point stays
complete, and add the seven `prom_eq`..`prom_sqrt` names to the
registration test.

Also per review: drop the doc paragraph that explains why the function
was moved, drop the redundant `test_serializer_decode_centralized_promql_registration`
test and the registration comment in the decoder, move `use std::sync::Arc`
up with the imports, and simplify the registration test assertions.

Signed-off-by: 风月 <1759519137@qq.com>
Signed-off-by: fengyue-xve <1759519137@qq.com>

---------

Signed-off-by: fengyue-xve <1759519137@qq.com>
Signed-off-by: 风月 <1759519137@qq.com>
This commit is contained in:
fengyue-xve
2026-10-14 07:33:52 +00:00
committed by GitHub
parent 00aa65de7a
commit 09bbe1cf9f
2 changed files with 190 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/query/src/query_engine/default_serializer.rs
+6 -92
View File
@@ -30,21 +30,7 @@ use datafusion::execution::{FunctionRegistry, SessionStateBuilder};
use datafusion::logical_expr::{Extension, LogicalPlan};
use datafusion_expr::{Expr, UserDefinedLogicalNode};
use greptime_proto::substrait_extension::MergeScan as PbMergeScan;
use promql::functions::{
AbsentOverTime, AvgOverTime, Changes, CountOverTime, Delta, Deriv, DoubleExponentialSmoothing,
IDelta, IeeeComparison, IeeeSqrt, Increase, LastOverTime, MaxOverTime, MinOverTime, MixedRange,
NativeHistogramAbsentOverTime, NativeHistogramAdd, NativeHistogramAggAvg,
NativeHistogramAggSum, NativeHistogramAvg, NativeHistogramAvgOverTime, NativeHistogramChanges,
NativeHistogramCount, NativeHistogramCountOverTime, NativeHistogramDelta,
NativeHistogramDivScalar, NativeHistogramDrop, NativeHistogramEq, NativeHistogramFraction,
NativeHistogramIDelta, NativeHistogramIRate, NativeHistogramIncrease,
NativeHistogramLastOverTime, NativeHistogramMulScalar, NativeHistogramNeg,
NativeHistogramNotEq, NativeHistogramPresentOverTime, NativeHistogramQuantile,
NativeHistogramRate, NativeHistogramResets, NativeHistogramScalarMul, NativeHistogramStddev,
NativeHistogramStdvar, NativeHistogramSub, NativeHistogramSum, NativeHistogramSumOverTime,
NativeHistogramToString, PredictLinear, PresentOverTime, PromqlFloatToString, QuantileOverTime,
Rate, Resets, Round, StddevOverTime, StdvarOverTime, SumOverTime, quantile_udaf,
};
use promql::functions::register_promql_functions;
use prost::Message;
use session::context::{QueryContext, QueryContextRef};
use snafu::ResultExt;
@@ -333,83 +319,7 @@ fn register_greptime_functions(
.context(RegisterUdfSnafu { name })?;
}
let _ = session_state.register_udaf(quantile_udaf());
for udf in IeeeComparison::all() {
let _ = session_state.register_udf(Arc::new(udf));
}
let _ = session_state.register_udf(Arc::new(IeeeSqrt::scalar_udf()));
let _ = session_state.register_udf(Arc::new(IDelta::<false>::scalar_udf()));
let _ = session_state.register_udf(Arc::new(IDelta::<true>::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Rate::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Increase::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Delta::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Resets::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Changes::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Deriv::scalar_udf()));
let _ = session_state.register_udf(Arc::new(Round::scalar_udf()));
let _ = session_state.register_udf(Arc::new(AvgOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(MinOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(MaxOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(SumOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(CountOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(LastOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(AbsentOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(PresentOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(StddevOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(StdvarOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(QuantileOverTime::scalar_udf()));
let _ = session_state.register_udf(Arc::new(PredictLinear::scalar_udf()));
let double_exponential_smoothing_udf =
DoubleExponentialSmoothing::scalar_udf().with_aliases(["prom_holt_winters"]);
let _ = session_state.register_udf(Arc::new(double_exponential_smoothing_udf));
for udf in [
NativeHistogramAbsentOverTime::scalar_udf(),
NativeHistogramAdd::scalar_udf(),
NativeHistogramAvg::scalar_udf(),
NativeHistogramAvgOverTime::scalar_udf(),
NativeHistogramChanges::scalar_udf(),
NativeHistogramCount::scalar_udf(),
NativeHistogramCountOverTime::scalar_udf(),
NativeHistogramDelta::scalar_udf(),
NativeHistogramDivScalar::scalar_udf(),
NativeHistogramDrop::bool_false_udf(String::new(), None),
NativeHistogramDrop::bool_true_udf(String::new(), None),
NativeHistogramDrop::float_null_udf(String::new(), None),
NativeHistogramEq::scalar_udf(),
NativeHistogramFraction::scalar_udf(),
NativeHistogramIDelta::scalar_udf(),
NativeHistogramIRate::scalar_udf(),
NativeHistogramIncrease::scalar_udf(),
NativeHistogramLastOverTime::scalar_udf(),
MixedRange::float_udf(None),
MixedRange::histogram_udf(None),
NativeHistogramMulScalar::scalar_udf(),
NativeHistogramNeg::scalar_udf(),
NativeHistogramNotEq::scalar_udf(),
NativeHistogramPresentOverTime::scalar_udf(),
NativeHistogramQuantile::scalar_udf(),
NativeHistogramRate::scalar_udf(),
NativeHistogramResets::scalar_udf(),
NativeHistogramScalarMul::scalar_udf(),
NativeHistogramStddev::scalar_udf(),
NativeHistogramStdvar::scalar_udf(),
NativeHistogramSub::scalar_udf(),
NativeHistogramSum::scalar_udf(),
NativeHistogramSumOverTime::scalar_udf(),
NativeHistogramToString::scalar_udf(),
PromqlFloatToString::scalar_udf(),
] {
let _ = session_state.register_udf(Arc::new(udf));
}
for udaf in [
NativeHistogramAggAvg::aggregate_udf(),
NativeHistogramAggSum::aggregate_udf(),
] {
let _ = session_state.register_udaf(Arc::new(udaf));
}
register_promql_functions(session_state);
Ok(())
}
@@ -471,6 +381,10 @@ mod tests {
use datatypes::data_type::DataType;
use futures::stream::BoxStream;
use promql::extension_plan::{RangeManipulate, SeriesNormalize, UnionDistinctOn};
use promql::functions::{
MixedRange, NativeHistogramAggAvg, NativeHistogramAggSum, NativeHistogramCount,
NativeHistogramDrop, PromqlFloatToString,
};
use session::context::QueryContext;
use table::TableRef;
use table::metadata::{TableId, TableInfoRef};