From 18875eed4d73edf66d2c4c0f4752c01f887a2510 Mon Sep 17 00:00:00 2001 From: Weny Xu Date: Mon, 1 Dec 2025 14:33:23 +0800 Subject: [PATCH] feat: implement `Display` trait for `FlushRegions` (#7320) feat: implement Display trait for FlushRegions Signed-off-by: WenyXu --- src/common/meta/src/instruction.rs | 10 ++++++++++ src/datanode/src/heartbeat/handler/flush_region.rs | 11 +++++++++++ 2 files changed, 21 insertions(+) diff --git a/src/common/meta/src/instruction.rs b/src/common/meta/src/instruction.rs index c1eb600fd8..c731c90490 100644 --- a/src/common/meta/src/instruction.rs +++ b/src/common/meta/src/instruction.rs @@ -339,6 +339,16 @@ pub struct FlushRegions { pub error_strategy: FlushErrorStrategy, } +impl Display for FlushRegions { + fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { + write!( + f, + "FlushRegions(region_ids={:?}, strategy={:?}, error_strategy={:?})", + self.region_ids, self.strategy, self.error_strategy + ) + } +} + impl FlushRegions { /// Create synchronous single-region flush pub fn sync_single(region_id: RegionId) -> Self { diff --git a/src/datanode/src/heartbeat/handler/flush_region.rs b/src/datanode/src/heartbeat/handler/flush_region.rs index 721673432e..a86d672eca 100644 --- a/src/datanode/src/heartbeat/handler/flush_region.rs +++ b/src/datanode/src/heartbeat/handler/flush_region.rs @@ -320,4 +320,15 @@ mod tests { assert!(flush_reply.results[0].1.is_ok()); assert!(flush_reply.results[1].1.is_err()); } + + #[test] + fn test_flush_regions_display() { + let region_id = RegionId::new(1024, 1); + let flush_regions = FlushRegions::sync_single(region_id); + let display = format!("{}", flush_regions); + assert_eq!( + display, + "FlushRegions(region_ids=[4398046511105(1024, 1)], strategy=Sync, error_strategy=FailFast)" + ); + } }