rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-26 09:50:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: add deregister_schema to CatalogManager (#1911)

Browse Source 
* feat: add deregister_schema to CatalogManager

* refactor: MemoryCatalogManager::deregister_schema

* fix: typo

* fix: typo
This commit is contained in:
Niwaka
2023-07-10 10:59:14 +09:00
committed by GitHub
parent f20b5695b8
commit 195dfdc5d3
5 changed files with 109 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/frontend/src/catalog.rs
View File

@@ -28,8 +28,8 @@ use catalog::helper::{
use catalog::information_schema::InformationSchemaProvider;
use catalog::remote::KvCacheInvalidatorRef;
use catalog::{
CatalogManager, DeregisterTableRequest, RegisterSchemaRequest, RegisterSystemTableRequest,
RegisterTableRequest, RenameTableRequest,
CatalogManager, DeregisterSchemaRequest, DeregisterTableRequest, RegisterSchemaRequest,
RegisterSystemTableRequest, RegisterTableRequest, RenameTableRequest,
};
use client::client_manager::DatanodeClients;
use common_catalog::consts::{DEFAULT_CATALOG_NAME, DEFAULT_SCHEMA_NAME, INFORMATION_SCHEMA_NAME};
@@ -130,7 +130,7 @@ impl CatalogManager for FrontendCatalogManager {
}
async fn register_catalog(&self, _name: String) -> CatalogResult<bool> {
unimplemented!("FrontendCatalogManager does not support register catalog")
unimplemented!("FrontendCatalogManager does not support registering catalog")
}
// TODO(LFC): Handle the table caching in (de)register_table.
@@ -151,7 +151,14 @@ impl CatalogManager for FrontendCatalogManager {
&self,
_request: RegisterSchemaRequest,
) -> catalog::error::Result<bool> {
unimplemented!("FrontendCatalogManager does not support register schema")
unimplemented!("FrontendCatalogManager does not support registering schema")
}
async fn deregister_schema(
&self,
_request: DeregisterSchemaRequest,
) -> catalog_err::Result<bool> {
unimplemented!("FrontendCatalogManager does not support deregistering schema")
}
async fn rename_table(&self, _request: RenameTableRequest) -> catalog_err::Result<bool> {