refactor: avoid unnecessary alloc by using unwrap_or_else (#3742)

feat(promql): address post-merge CR
This commit is contained in:
Eugene Tolbakov
2024-04-19 02:31:25 +01:00
committed by GitHub
parent 314f2704d4
commit 2114b153e7
3 changed files with 11 additions and 9 deletions

View File

@@ -37,7 +37,9 @@ impl StatementExecutor {
end: eval.end,
step: eval.step,
query: eval.query,
lookback: eval.lookback.unwrap_or(DEFAULT_LOOKBACK_STRING.to_string()),
lookback: eval
.lookback
.unwrap_or_else(|| DEFAULT_LOOKBACK_STRING.to_string()),
};
QueryLanguageParser::parse_promql(&promql, &query_ctx).context(ParseQuerySnafu)?
}
@@ -46,7 +48,7 @@ impl StatementExecutor {
query: explain.query,
lookback: explain
.lookback
.unwrap_or(DEFAULT_LOOKBACK_STRING.to_string()),
.unwrap_or_else(|| DEFAULT_LOOKBACK_STRING.to_string()),
..PromQuery::default()
};
let explain_node_name = if explain.is_verbose {
@@ -69,7 +71,7 @@ impl StatementExecutor {
query: analyze.query,
lookback: analyze
.lookback
.unwrap_or(DEFAULT_LOOKBACK_STRING.to_string()),
.unwrap_or_else(|| DEFAULT_LOOKBACK_STRING.to_string()),
};
let analyze_node_name = if analyze.is_verbose {
ANALYZE_VERBOSE_NODE_NAME