feat(partition): support iceberg_hash in partition rules (#9693)

* feat(partition): support iceberg_hash in partition rules

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* fix(partition): reject partition column type changes and quote rule identifiers

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* fix(table): keep time index widening for partition columns

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* refactor(partition): replace PartitionFunction with IcebergHash

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* docs(partition): describe iceberg_hash in the function module

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* fix(meta): validate iceberg_hash partition bounds on ALTER and trim comments

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* test: quote partition rule identifiers in SHOW CREATE TABLE expectations

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* test(partition): check hash rules in information_schema and repartition target columns

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* fix(partition): coerce hash partition rules against the evaluation schema

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

* fix(partition): keep quotes in partition column names when building filters

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

---------

Signed-off-by: Dennis Zhuang <killme2008@gmail.com>

src/sql/src/parsers/create_parser.rs

@@ -28,8 +28,8 @@ pub(crate) use json::parse_json2_type_and_options;
 pub use json::parse_json2_type_hint_path;
 use snafu::{OptionExt, ResultExt, ensure};
 use sqlparser::ast::{
-    ColumnOption, ColumnOptionDef, DataType, Expr, KeyOrIndexDisplay, NullsDistinctOption,
-    PrimaryKeyConstraint, UniqueConstraint,
+    ColumnOption, ColumnOptionDef, DataType, Expr, FunctionArg, FunctionArgExpr, FunctionArguments,
+    KeyOrIndexDisplay, NullsDistinctOption, PrimaryKeyConstraint, UniqueConstraint,
 };
 use sqlparser::dialect::keywords::Keyword;
 use sqlparser::keywords::ALL_KEYWORDS;
@@ -1300,6 +1300,17 @@ fn ensure_one_expr(expr: &Expr, columns: &[&Column]) -> Result<()> {
             );
             Ok(())
         }
+        // The function and its argument shape are validated when the rule is converted.
+        Expr::Function(function) => {
+            if let FunctionArguments::List(args) = &function.args {
+                for arg in &args.args {
+                    if let FunctionArg::Unnamed(FunctionArgExpr::Expr(expr)) = arg {
+                        ensure_one_expr(expr, columns)?;
+                    }
+                }
+            }
+            Ok(())
+        }
         Expr::Value(_) => Ok(()),
         Expr::UnaryOp { expr, .. } => {
             ensure_one_expr(expr, columns)?;

src/sql/src/statements/create.rs

@@ -14,6 +14,7 @@
 
 use std::collections::HashMap;
 use std::fmt::{Display, Formatter, Write};
+use std::ops::ControlFlow;
 
 use common_catalog::consts::FILE_ENGINE;
 use datatypes::json::{JSON2_DEFAULT_MAX_AUTO_EXPANDED_PATHS, JsonSettings};
@@ -22,7 +23,7 @@ use datatypes::schema::{CompressionOptions, FulltextOptions, SkippingIndexOption
 use itertools::Itertools;
 use serde::Serialize;
 use snafu::ResultExt;
-use sqlparser::ast::{ColumnOptionDef, DataType, Expr};
+use sqlparser::ast::{ColumnOptionDef, DataType, Expr, visit_expressions_mut};
 use sqlparser_derive::{Visit, VisitMut};
 
 use crate::ast::{ColumnDef, Ident, ObjectName};
@@ -395,11 +396,17 @@ pub struct Partitions {
 }
 
 impl Partitions {
-    /// set quotes to all [Ident]s from column list
+    /// Sets quotes to all column [Ident]s, in the column list and in the expressions.
     pub fn set_quote(&mut self, quote_style: char) {
         self.column_list
             .iter_mut()
             .for_each(|c| c.quote_style = Some(quote_style));
+        let _ = visit_expressions_mut(&mut self.exprs, |expr| {
+            if let Expr::Identifier(ident) = expr {
+                ident.quote_style = Some(quote_style);
+            }
+            ControlFlow::<()>::Continue(())
+        });
     }
 }