From 2f7dbd21689dbf0e86b0d993f949d48be9df31da Mon Sep 17 00:00:00 2001 From: discord9 <55937128+discord9@users.noreply.github.com> Date: Mon, 14 Sep 2026 14:25:22 +0800 Subject: [PATCH] refactor: omit unused typed statistics helper from backport Signed-off-by: discord9 <55937128+discord9@users.noreply.github.com> --- src/mito2/src/sst/parquet/format.rs | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/src/mito2/src/sst/parquet/format.rs b/src/mito2/src/sst/parquet/format.rs index 7dc39b4c27..9e27f7490a 100644 --- a/src/mito2/src/sst/parquet/format.rs +++ b/src/mito2/src/sst/parquet/format.rs @@ -36,7 +36,7 @@ use datafusion_common::ScalarValue; use datatypes::arrow::array::{ ArrayRef, BinaryArray, BinaryDictionaryBuilder, DictionaryArray, UInt64Array, }; -use datatypes::arrow::datatypes::{DataType as ArrowDataType, SchemaRef, UInt32Type}; +use datatypes::arrow::datatypes::{SchemaRef, UInt32Type}; use datatypes::arrow::record_batch::RecordBatch; use datatypes::prelude::DataType; use datatypes::types::json_type::JsonNativeType; @@ -136,26 +136,15 @@ pub(crate) fn column_values( column: &ColumnMetadata, column_index: usize, is_min: bool, -) -> Option { - column_values_by_type( - row_groups, - &column.column_schema.data_type.as_arrow_type(), - column_index, - is_min, - ) -} - -/// Returns min/max values for a top-level column with the given Arrow data type. -/// Resolves its leaf from the actual Parquet schema, not an inferred Arrow layout. -pub(crate) fn column_values_by_type( - row_groups: &[impl Borrow], - data_type: &ArrowDataType, - column_index: usize, - is_min: bool, ) -> Option { let column_index = scalar_leaf_index(row_groups.first()?.borrow().schema_descr(), column_index)?; - let null_scalar: ScalarValue = data_type.try_into().ok()?; + let null_scalar: ScalarValue = column + .column_schema + .data_type + .as_arrow_type() + .try_into() + .ok()?; let scalar_values = row_groups .iter() .map(|meta| {