refactor: enhanced trigger interval (#6740)

* refactor: enhance trigger interval

* update greptime-proto

* fix: build

src/operator/Cargo.toml

@@ -6,7 +6,7 @@ license.workspace = true
 
 [features]
 testing = []
-enterprise = ["common-meta/enterprise", "sql/enterprise", "query/enterprise"]
+enterprise = ["common-meta/enterprise", "sql/enterprise", "query/enterprise", "prost-types"]
 
 [lints]
 workspace = true
@@ -56,6 +56,7 @@ object_store_opendal.workspace = true
 partition.workspace = true
 prometheus.workspace = true
 prost.workspace = true
+prost-types = { workspace = true, optional = true }
 query.workspace = true
 regex.workspace = true
 serde_json.workspace = true

src/operator/src/error.rs

@@ -851,6 +851,15 @@ pub enum Error {
         #[snafu(implicit)]
         location: Location,
     },
+
+    #[cfg(feature = "enterprise")]
+    #[snafu(display("Too large duration"))]
+    TooLargeDuration {
+        #[snafu(source)]
+        error: prost_types::DurationError,
+        #[snafu(implicit)]
+        location: Location,
+    },
 }
 
 pub type Result<T> = std::result::Result<T, Error>;
@@ -897,6 +906,8 @@ impl ErrorExt for Error {
             | Error::CreatePartitionRules { .. } => StatusCode::InvalidArguments,
             #[cfg(feature = "enterprise")]
             Error::InvalidTriggerName { .. } => StatusCode::InvalidArguments,
+            #[cfg(feature = "enterprise")]
+            Error::TooLargeDuration { .. } => StatusCode::InvalidArguments,
             Error::TableAlreadyExists { .. } | Error::ViewAlreadyExists { .. } => {
                 StatusCode::TableAlreadyExists
             }

src/operator/src/expr_helper/trigger.rs

@@ -4,10 +4,11 @@ use api::v1::{
     WebhookOptions as PbWebhookOptions,
 };
 use session::context::QueryContextRef;
-use snafu::ensure;
+use snafu::{ensure, ResultExt};
 use sql::ast::{ObjectName, ObjectNamePartExt};
-use sql::statements::create::trigger::{ChannelType, CreateTrigger};
+use sql::statements::create::trigger::{ChannelType, CreateTrigger, TriggerOn};
 
+use crate::error;
 use crate::error::Result;
 
 pub fn to_create_trigger_task_expr(
@@ -17,13 +18,18 @@ pub fn to_create_trigger_task_expr(
     let CreateTrigger {
         trigger_name,
         if_not_exists,
-        query,
-        interval,
+        trigger_on,
         labels,
         annotations,
         channels,
     } = create_trigger;
 
+    let TriggerOn {
+        query,
+        interval,
+        raw_interval_expr,
+    } = trigger_on;
+
     let catalog_name = query_ctx.current_catalog().to_string();
     let trigger_name = sanitize_trigger_name(trigger_name)?;
 
@@ -47,6 +53,8 @@ pub fn to_create_trigger_task_expr(
     let labels = labels.into_map();
     let annotations = annotations.into_map();
 
+    let interval = interval.try_into().context(error::TooLargeDurationSnafu)?;
+
     Ok(PbCreateTriggerExpr {
         catalog_name,
         trigger_name,
@@ -55,7 +63,8 @@ pub fn to_create_trigger_task_expr(
         channels,
         labels,
         annotations,
-        interval,
+        interval: Some(interval),
+        raw_interval_expr,
     })
 }
 
@@ -72,6 +81,8 @@ fn sanitize_trigger_name(mut trigger_name: ObjectName) -> Result<String> {
 
 #[cfg(test)]
 mod tests {
+    use std::time::Duration;
+
     use session::context::QueryContext;
     use sql::dialect::GreptimeDbDialect;
     use sql::parser::{ParseOptions, ParserContext};
@@ -123,7 +134,8 @@ NOTIFY
             "(SELECT host AS host_label, cpu, memory FROM machine_monitor WHERE cpu > 2)",
             expr.sql
         );
-        assert_eq!(300, expr.interval);
+        let expected: prost_types::Duration = Duration::from_secs(300).try_into().unwrap();
+        assert_eq!(Some(expected), expr.interval);
         assert_eq!(1, expr.labels.len());
         assert_eq!("label_val", expr.labels.get("label_name").unwrap());
         assert_eq!(1, expr.annotations.len());