rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-27 18:30:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: create database if not exists (#1009)

Browse Source
This commit is contained in:
LFC
2023-02-15 17:47:46 +08:00
committed by GitHub
parent cd0d58cb24
commit 34fdba77df
10 changed files with 70 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/frontend/src/instance/distributed.rs
View File

@@ -281,7 +281,7 @@ impl DistInstance {
database_name: stmt.name.to_string(),
create_if_not_exists: stmt.if_not_exists,
};
Ok(self.handle_create_database(expr).await?)
return self.handle_create_database(expr, query_ctx).await;
}
Statement::CreateTable(stmt) => {
let create_expr = &mut expr_factory::create_to_expr(&stmt, query_ctx)?;
@@ -371,10 +371,30 @@ impl DistInstance {
}
/// Handles distributed database creation
async fn handle_create_database(&self, expr: CreateDatabaseExpr) -> Result<Output> {
async fn handle_create_database(
&self,
expr: CreateDatabaseExpr,
query_ctx: QueryContextRef,
) -> Result<Output> {
let catalog = query_ctx.current_catalog();
if self
.catalog_manager
.schema(&catalog, &expr.database_name)
.context(CatalogSnafu)?
.is_some()
{
return if expr.create_if_not_exists {
Ok(Output::AffectedRows(1))
} else {
SchemaExistsSnafu {
name: &expr.database_name,
}
.fail()
};
}
let key = SchemaKey {
// TODO(sunng87): custom catalog
catalog_name: DEFAULT_CATALOG_NAME.to_string(),
catalog_name: catalog,
schema_name: expr.database_name,
};
let value = SchemaValue {};

2
src/frontend/src/instance/distributed/grpc.rs
View File

@@ -45,7 +45,7 @@ impl GrpcQueryHandler for DistInstance {
err_msg: "Missing 'expr' in DDL request",
})?;
match expr {
DdlExpr::CreateDatabase(expr) => self.handle_create_database(expr).await,
DdlExpr::CreateDatabase(expr) => self.handle_create_database(expr, ctx).await,
DdlExpr::CreateTable(mut expr) => {
// TODO(LFC): Support creating distributed table through GRPC interface.
// Currently only SQL supports it; how to design the fields in CreateTableExpr?