From 36ab1ceef7469ac73fbee86869849e6ccca0b882 Mon Sep 17 00:00:00 2001 From: Yingwen Date: Fri, 20 Jun 2025 21:14:50 +0800 Subject: [PATCH] chore: prints a warning when skip_ssl_validation is true (#6367) chore: warn when skip_ssl_validation is true We already log all configs when a node starts. Signed-off-by: evenyag --- src/datanode/src/store.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/datanode/src/store.rs b/src/datanode/src/store.rs index 3a2f626141..7e80259e66 100644 --- a/src/datanode/src/store.rs +++ b/src/datanode/src/store.rs @@ -207,15 +207,16 @@ pub(crate) fn clean_temp_dir(dir: &str) -> Result<()> { } pub(crate) fn build_http_client(config: &HttpClientConfig) -> Result { + if config.skip_ssl_validation { + common_telemetry::warn!("Skipping SSL validation for object storage HTTP client. Please ensure the environment is trusted."); + } + let client = reqwest::ClientBuilder::new() .pool_max_idle_per_host(config.pool_max_idle_per_host as usize) .connect_timeout(config.connect_timeout) .pool_idle_timeout(config.pool_idle_timeout) .timeout(config.timeout) - .danger_accept_invalid_certs({ - info!("skip_ssl_validation: {}", config.skip_ssl_validation); - config.skip_ssl_validation - }) + .danger_accept_invalid_certs(config.skip_ssl_validation) .build() .context(BuildHttpClientSnafu)?; Ok(HttpClient::with(client))