From 389ded93d188938afd099699b8a053348a55720b Mon Sep 17 00:00:00 2001 From: Weny Xu Date: Mon, 27 May 2024 13:01:40 +0900 Subject: [PATCH] chore: add logs for setting the region to writable (#4044) * chore: add logs for setting the region to writable * fix: ignore redundant logs --- src/mito2/src/region.rs | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/mito2/src/region.rs b/src/mito2/src/region.rs index 95068d55f4..71006324d9 100644 --- a/src/mito2/src/region.rs +++ b/src/mito2/src/region.rs @@ -168,10 +168,24 @@ impl MitoRegion { if writable { // Only sets the region to writable if it is read only. // This prevents others updating the manifest. - let _ = self + match self .manifest_ctx .state - .compare_exchange(RegionState::ReadOnly, RegionState::Writable); + .compare_exchange(RegionState::ReadOnly, RegionState::Writable) + { + Ok(state) => info!( + "Set region {} to writable, previous state: {:?}", + self.region_id, state + ), + Err(state) => { + if state != RegionState::Writable { + warn!( + "Failed to set region {} to writable, current state: {:?}", + self.region_id, state + ) + } + } + } } else { self.manifest_ctx.state.store(RegionState::ReadOnly); }