refactor: remove the "mode" configuration item completely (#6042)

src/datanode/src/datanode.rs

@@ -47,7 +47,6 @@ use query::dummy_catalog::TableProviderFactoryRef;
 use query::QueryEngineFactory;
 use servers::export_metrics::ExportMetricsTask;
 use servers::server::ServerHandlers;
-use servers::Mode;
 use snafu::{ensure, OptionExt, ResultExt};
 use store_api::path_utils::{region_dir, WAL_DIR};
 use store_api::region_engine::{RegionEngineRef, RegionRole};
@@ -267,24 +266,18 @@ impl DatanodeBuilder {
             None
         };
 
-        let mode = if heartbeat_task.is_none() {
-            Mode::Standalone
-        } else {
-            Mode::Distributed
-        };
+        let is_standalone = heartbeat_task.is_none();
         let greptimedb_telemetry_task = get_greptimedb_telemetry_task(
             Some(self.opts.storage.data_home.clone()),
-            &mode,
-            self.opts.enable_telemetry,
+            is_standalone && self.opts.enable_telemetry,
         )
         .await;
 
-        let leases_notifier =
-            if self.opts.require_lease_before_startup && matches!(mode, Mode::Distributed) {
-                Some(Arc::new(Notify::new()))
-            } else {
-                None
-            };
+        let leases_notifier = if self.opts.require_lease_before_startup && !is_standalone {
+            Some(Arc::new(Notify::new()))
+        } else {
+            None
+        };
 
         let export_metrics_task =
             ExportMetricsTask::try_new(&self.opts.export_metrics, Some(&self.plugins))

src/datanode/src/greptimedb_telemetry.rs

@@ -20,7 +20,6 @@ use common_greptimedb_telemetry::{
     default_get_uuid, Collector, GreptimeDBTelemetry, GreptimeDBTelemetryTask,
     Mode as VersionReporterMode, TELEMETRY_INTERVAL,
 };
-use servers::Mode;
 
 struct StandaloneGreptimeDBTelemetryCollector {
     uuid: Option<String>,
@@ -55,7 +54,6 @@ impl Collector for StandaloneGreptimeDBTelemetryCollector {
 
 pub async fn get_greptimedb_telemetry_task(
     working_home: Option<String>,
-    mode: &Mode,
     enable: bool,
 ) -> Arc<GreptimeDBTelemetryTask> {
     if !enable || cfg!(test) || cfg!(debug_assertions) {
@@ -64,19 +62,14 @@ pub async fn get_greptimedb_telemetry_task(
     // Always enable.
     let should_report = Arc::new(AtomicBool::new(true));
 
-    match mode {
-        Mode::Standalone => Arc::new(GreptimeDBTelemetryTask::enable(
-            TELEMETRY_INTERVAL,
-            Box::new(GreptimeDBTelemetry::new(
-                working_home.clone(),
-                Box::new(StandaloneGreptimeDBTelemetryCollector {
-                    uuid: default_get_uuid(&working_home),
-                    retry: 0,
-                }),
-                should_report.clone(),
-            )),
-            should_report,
+    let uuid = default_get_uuid(&working_home);
+    Arc::new(GreptimeDBTelemetryTask::enable(
+        TELEMETRY_INTERVAL,
+        Box::new(GreptimeDBTelemetry::new(
+            working_home,
+            Box::new(StandaloneGreptimeDBTelemetryCollector { uuid, retry: 0 }),
+            should_report.clone(),
         )),
-        Mode::Distributed => Arc::new(GreptimeDBTelemetryTask::disable()),
-    }
+        should_report,
+    ))
 }