From 4bfe02ec7fc1df88a1ccbdf41e4b1061cd78a25c Mon Sep 17 00:00:00 2001 From: localhost Date: Thu, 10 Jul 2025 20:33:06 +0800 Subject: [PATCH] chore: remove region id to reduce time series (#6506) Signed-off-by: evenyag --- src/datanode/src/metrics.rs | 4 ++-- src/datanode/src/region_server.rs | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/datanode/src/metrics.rs b/src/datanode/src/metrics.rs index 12ac482826..1b0e513375 100644 --- a/src/datanode/src/metrics.rs +++ b/src/datanode/src/metrics.rs @@ -27,14 +27,14 @@ lazy_static! { pub static ref HANDLE_REGION_REQUEST_ELAPSED: HistogramVec = register_histogram_vec!( "greptime_datanode_handle_region_request_elapsed", "datanode handle region request elapsed", - &[REGION_ID, REGION_REQUEST_TYPE] + &[REGION_REQUEST_TYPE] ) .unwrap(); /// The number of rows in region request received by region server, labeled with request type. pub static ref REGION_CHANGED_ROW_COUNT: IntCounterVec = register_int_counter_vec!( "greptime_datanode_region_changed_row_count", "datanode region changed row count", - &[REGION_ID, REGION_REQUEST_TYPE] + &[REGION_REQUEST_TYPE] ) .unwrap(); /// The elapsed time since the last received heartbeat. diff --git a/src/datanode/src/region_server.rs b/src/datanode/src/region_server.rs index 2f3530721a..2aa4f2e80b 100644 --- a/src/datanode/src/region_server.rs +++ b/src/datanode/src/region_server.rs @@ -915,9 +915,8 @@ impl RegionServerInner { request: RegionRequest, ) -> Result { let request_type = request.request_type(); - let region_id_str = region_id.to_string(); let _timer = crate::metrics::HANDLE_REGION_REQUEST_ELAPSED - .with_label_values(&[®ion_id_str, request_type]) + .with_label_values(&[request_type]) .start_timer(); let region_change = match &request { @@ -957,7 +956,7 @@ impl RegionServerInner { // Update metrics if matches!(region_change, RegionChange::Ingest) { crate::metrics::REGION_CHANGED_ROW_COUNT - .with_label_values(&[®ion_id_str, request_type]) + .with_label_values(&[request_type]) .inc_by(result.affected_rows as u64); } // Sets corresponding region status to ready.