refactor: add &mut Plugins argument in plugins setup api and remove unnecessary mut (#4389)

refactor: add '&mut Plugins' argument in plugins setup api and remove unnecessary mut

Signed-off-by: zyy17 <zyylsxm@gmail.com>

src/plugins/src/datanode.rs

@@ -16,8 +16,13 @@ use common_base::Plugins;
 use datanode::config::DatanodeOptions;
 use datanode::error::Result;
 
-pub async fn setup_datanode_plugins(_opts: &mut DatanodeOptions) -> Result<Plugins> {
-    Ok(Plugins::new())
+#[allow(unused_variables)]
+#[allow(unused_mut)]
+pub async fn setup_datanode_plugins(
+    plugins: &mut Plugins,
+    dn_opts: &DatanodeOptions,
+) -> Result<()> {
+    Ok(())
 }
 
 pub async fn start_datanode_plugins(_plugins: Plugins) -> Result<()> {

src/plugins/src/frontend.rs

@@ -18,16 +18,17 @@ use frontend::error::{IllegalAuthConfigSnafu, Result};
 use frontend::frontend::FrontendOptions;
 use snafu::ResultExt;
 
-pub async fn setup_frontend_plugins(opts: &FrontendOptions) -> Result<Plugins> {
-    let plugins = Plugins::new();
-
-    if let Some(user_provider) = opts.user_provider.as_ref() {
+#[allow(unused_mut)]
+pub async fn setup_frontend_plugins(
+    plugins: &mut Plugins,
+    fe_opts: &FrontendOptions,
+) -> Result<()> {
+    if let Some(user_provider) = fe_opts.user_provider.as_ref() {
         let provider =
             auth::user_provider_from_option(user_provider).context(IllegalAuthConfigSnafu)?;
         plugins.insert::<UserProviderRef>(provider);
     }
-
-    Ok(plugins)
+    Ok(())
 }
 
 pub async fn start_frontend_plugins(_plugins: Plugins) -> Result<()> {

src/plugins/src/meta_srv.rs

@@ -16,8 +16,12 @@ use common_base::Plugins;
 use meta_srv::error::Result;
 use meta_srv::metasrv::MetasrvOptions;
 
-pub async fn setup_metasrv_plugins(_opts: &mut MetasrvOptions) -> Result<Plugins> {
-    Ok(Plugins::new())
+#[allow(unused_variables)]
+pub async fn setup_metasrv_plugins(
+    _plugins: &mut Plugins,
+    metasrv_opts: &MetasrvOptions,
+) -> Result<()> {
+    Ok(())
 }
 
 pub async fn start_metasrv_plugins(_plugins: Plugins) -> Result<()> {