rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-21 15:30:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: change plugin option type from &[PluginOptions] to Option<&PluginOptions> for understandability (#6763)

Browse Source 
refactor: change plugin option type from `[PluginOptions]` to `Option<&PluginOptions>` for understandability

Signed-off-by: zyy17 <zyylsxm@gmail.com>
This commit is contained in:
zyy17
2025-08-19 19:11:00 -07:00
committed by GitHub
parent 7af471c5aa
commit 5420d6f7fb
11 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/src/datanode/builder.rs
View File

@@ -71,7 +71,7 @@ impl InstanceBuilder {
maybe_activate_heap_profile(&dn_opts.memory);
create_resource_limit_metrics(APP_NAME);
plugins::setup_datanode_plugins(plugins, &opts.plugins, dn_opts)
plugins::setup_datanode_plugins(plugins, opts.plugins.as_ref(), dn_opts)
.await
.context(StartDatanodeSnafu)?;

2
src/cmd/src/flownode.rs
View File

@@ -291,7 +291,7 @@ impl StartCommand {
opts.grpc.detect_server_addr();
let mut plugins = Plugins::new();
plugins::setup_flownode_plugins(&mut plugins, &plugin_opts, &opts)
plugins::setup_flownode_plugins(&mut plugins, plugin_opts.as_ref(), &opts)
.await
.context(StartFlownodeSnafu)?;

4
src/cmd/src/frontend.rs
View File

@@ -293,7 +293,7 @@ impl StartCommand {
let mut opts = opts.component;
opts.grpc.detect_server_addr();
let mut plugins = Plugins::new();
plugins::setup_frontend_plugins(&mut plugins, &plugin_opts, &opts)
plugins::setup_frontend_plugins(&mut plugins, plugin_opts.as_ref(), &opts)
.await
.context(error::StartFrontendSnafu)?;
@@ -526,7 +526,7 @@ mod tests {
};
let mut plugins = Plugins::new();
plugins::setup_frontend_plugins(&mut plugins, &[], &fe_opts)
plugins::setup_frontend_plugins(&mut plugins, None, &fe_opts)
.await
.unwrap();

2
src/cmd/src/metasrv.rs
View File

@@ -337,7 +337,7 @@ impl StartCommand {
info!("Metasrv options: {:#?}", opts);
let mut plugins = Plugins::new();
plugins::setup_metasrv_plugins(&mut plugins, &plugin_opts, &opts)
plugins::setup_metasrv_plugins(&mut plugins, plugin_opts.as_ref(), &opts)
.await
.context(StartMetaServerSnafu)?;

2
src/cmd/src/options.rs
View File

@@ -42,7 +42,7 @@ pub struct GreptimeOptions<T> {
/// The runtime options.
pub runtime: RuntimeOptions,
/// The plugin options.
pub plugins: Vec<PluginOptions>,
pub plugins: Option<PluginOptions>,
/// The options of each component (like Datanode or Standalone) of GreptimeDB.
#[serde(flatten)]

6
src/cmd/src/standalone.rs
View File

@@ -503,11 +503,11 @@ impl StartCommand {
let fe_opts = opts.frontend_options();
let dn_opts = opts.datanode_options();
plugins::setup_frontend_plugins(&mut plugins, &plugin_opts, &fe_opts)
plugins::setup_frontend_plugins(&mut plugins, plugin_opts.as_ref(), &fe_opts)
.await
.context(error::StartFrontendSnafu)?;
plugins::setup_datanode_plugins(&mut plugins, &plugin_opts, &dn_opts)
plugins::setup_datanode_plugins(&mut plugins, plugin_opts.as_ref(), &dn_opts)
.await
.context(error::StartDatanodeSnafu)?;
@@ -877,7 +877,7 @@ mod tests {
};
let mut plugins = Plugins::new();
plugins::setup_frontend_plugins(&mut plugins, &[], &fe_opts)
plugins::setup_frontend_plugins(&mut plugins, None, &fe_opts)
.await
.unwrap();