diff --git a/config/config.md b/config/config.md index 779c5a7ea8..a430ce1553 100644 --- a/config/config.md +++ b/config/config.md @@ -349,7 +349,6 @@ | `meta_schema_name` | String | `greptime_schema` | Optional PostgreSQL schema for metadata table and election table name qualification.
When PostgreSQL public schema is not writable (e.g., PostgreSQL 15+ with restricted public),
set this to a writable schema. GreptimeDB will use `meta_schema_name`.`meta_table_name`.
GreptimeDB will NOT create the schema automatically; please ensure it exists or the user has permission.
**Only used when backend is `postgres_store`.** | | `meta_election_lock_id` | Integer | `1` | Advisory lock id in PostgreSQL for election. Effect when using PostgreSQL as kvbackend
Only used when backend is `postgres_store`. | | `selector` | String | `round_robin` | Datanode selector type.
- `round_robin` (default value)
- `lease_based`
- `load_based`
For details, please see "https://docs.greptime.com/developer-guide/metasrv/selector". | -| `use_memory_store` | Bool | `false` | Store data in memory. | | `enable_region_failover` | Bool | `false` | Whether to enable region failover.
This feature is only available on GreptimeDB running on cluster mode and
- Using Remote WAL
- Using shared storage (e.g., s3). | | `region_failure_detector_initialization_delay` | String | `10m` | The delay before starting region failure detection.
This delay helps prevent Metasrv from triggering unnecessary region failovers before all Datanodes are fully started.
Especially useful when the cluster is not deployed with GreptimeDB Operator and maintenance mode is not enabled. | | `allow_region_failover_on_local_wal` | Bool | `false` | Whether to allow region failover on local WAL.
**This option is not recommended to be set to true, because it may lead to data loss during failover.** | diff --git a/config/metasrv.example.toml b/config/metasrv.example.toml index 1afffe186f..a640de2588 100644 --- a/config/metasrv.example.toml +++ b/config/metasrv.example.toml @@ -50,9 +50,6 @@ meta_election_lock_id = 1 ## For details, please see "https://docs.greptime.com/developer-guide/metasrv/selector". selector = "round_robin" -## Store data in memory. -use_memory_store = false - ## Whether to enable region failover. ## This feature is only available on GreptimeDB running on cluster mode and ## - Using Remote WAL diff --git a/src/cmd/src/metasrv.rs b/src/cmd/src/metasrv.rs index 204ee25c8b..2ce5fb3a02 100644 --- a/src/cmd/src/metasrv.rs +++ b/src/cmd/src/metasrv.rs @@ -155,8 +155,6 @@ pub struct StartCommand { #[clap(short, long)] selector: Option, #[clap(long)] - use_memory_store: Option, - #[clap(long)] enable_region_failover: Option, #[clap(long)] http_addr: Option, @@ -186,7 +184,6 @@ impl Debug for StartCommand { .field("store_addrs", &self.sanitize_store_addrs()) .field("config_file", &self.config_file) .field("selector", &self.selector) - .field("use_memory_store", &self.use_memory_store) .field("enable_region_failover", &self.enable_region_failover) .field("http_addr", &self.http_addr) .field("http_timeout", &self.http_timeout) @@ -268,10 +265,6 @@ impl StartCommand { .context(error::UnsupportedSelectorTypeSnafu { selector_type })?; } - if let Some(use_memory_store) = self.use_memory_store { - opts.use_memory_store = use_memory_store; - } - if let Some(enable_region_failover) = self.enable_region_failover { opts.enable_region_failover = enable_region_failover; } @@ -391,7 +384,6 @@ mod tests { server_addr = "127.0.0.1:3002" store_addr = "127.0.0.1:2379" selector = "LeaseBased" - use_memory_store = false [logging] level = "debug" @@ -470,7 +462,6 @@ mod tests { server_addr = "127.0.0.1:3002" datanode_lease_secs = 15 selector = "LeaseBased" - use_memory_store = false [http] addr = "127.0.0.1:4000" diff --git a/src/meta-srv/src/metasrv.rs b/src/meta-srv/src/metasrv.rs index 34f3410101..9e6eacf9b4 100644 --- a/src/meta-srv/src/metasrv.rs +++ b/src/meta-srv/src/metasrv.rs @@ -163,8 +163,6 @@ pub struct MetasrvOptions { pub backend_client: BackendClientOptions, /// The type of selector. pub selector: SelectorType, - /// Whether to use the memory store. - pub use_memory_store: bool, /// Whether to enable region failover. pub enable_region_failover: bool, /// The base heartbeat interval. @@ -250,7 +248,6 @@ impl fmt::Debug for MetasrvOptions { .field("store_addrs", &self.sanitize_store_addrs()) .field("backend_tls", &self.backend_tls) .field("selector", &self.selector) - .field("use_memory_store", &self.use_memory_store) .field("enable_region_failover", &self.enable_region_failover) .field( "allow_region_failover_on_local_wal", @@ -301,7 +298,6 @@ impl Default for MetasrvOptions { store_addrs: vec!["127.0.0.1:2379".to_string()], backend_tls: None, selector: SelectorType::default(), - use_memory_store: false, enable_region_failover: false, heartbeat_interval: distributed_time_constants::BASE_HEARTBEAT_INTERVAL, region_failure_detector_initialization_delay: Duration::from_secs(10 * 60), diff --git a/tests/conf/metasrv-test.toml.template b/tests/conf/metasrv-test.toml.template index 910601d6ff..e5cde7703d 100644 --- a/tests/conf/metasrv-test.toml.template +++ b/tests/conf/metasrv-test.toml.template @@ -3,9 +3,6 @@ flush_stats_factor = 1 ## Store server address default to etcd store. store_addrs = [{store_addrs | unescaped}] -## Store data in memory. -use_memory_store = false - ## The datastore for meta server. backend = "EtcdStore" {{ endif }}