ignore unmatched left and right greater

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2024-09-08 11:12:21 +08:00
parent 6208772ba4
commit 60bacff57e

View File

@@ -274,7 +274,7 @@ impl<'a> RuleChecker<'a> {
fn check_axis(&self) -> Result<()> { fn check_axis(&self) -> Result<()> {
for (col_index, axis) in self.axis.iter().enumerate() { for (col_index, axis) in self.axis.iter().enumerate() {
for (val, split_point) in axis { for (val, split_point) in axis {
if split_point.less_than_counter != 0 || !split_point.is_equal { if !split_point.is_equal {
UnclosedValueSnafu { UnclosedValueSnafu {
value: format!("{val:?}"), value: format!("{val:?}"),
column: self.rule.partition_columns[col_index].clone(), column: self.rule.partition_columns[col_index].clone(),
@@ -410,6 +410,7 @@ mod tests {
/// b <= h b >= s /// b <= h b >= s
/// ``` /// ```
#[test] #[test]
#[ignore = "don't check unmatched `>` and `<` for now"]
fn empty_expr_case_1() { fn empty_expr_case_1() {
// PARTITION ON COLUMNS (b) ( // PARTITION ON COLUMNS (b) (
// b <= 'h', // b <= 'h',
@@ -451,6 +452,7 @@ mod tests {
/// 10 20 /// 10 20
/// ``` /// ```
#[test] #[test]
#[ignore = "don't check unmatched `>` and `<` for now"]
fn empty_expr_case_2() { fn empty_expr_case_2() {
// PARTITION ON COLUMNS (b) ( // PARTITION ON COLUMNS (b) (
// a >= 100 AND b <= 10 OR a > 100 AND a <= 200 AND b <= 10 OR a >= 200 AND b > 10 AND b <= 20 OR a > 200 AND b <= 20 // a >= 100 AND b <= 10 OR a > 100 AND a <= 200 AND b <= 10 OR a >= 200 AND b > 10 AND b <= 20 OR a > 200 AND b <= 20
@@ -580,6 +582,7 @@ mod tests {
} }
#[test] #[test]
#[ignore = "don't check unmatched `>` and `<` for now"]
fn duplicate_expr_case_1() { fn duplicate_expr_case_1() {
// PARTITION ON COLUMNS (a) ( // PARTITION ON COLUMNS (a) (
// a <= 20, // a <= 20,