rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-05-21 15:30:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use derive_builder for boilerplate builders (#116)

Browse Source 
* refactor: remove boilerplate builder code with derive_builder macro

* refactor: better build creation using Default::default()

* refactor: resolve api change issues in benchmark code

* refactor: address some review issues

* refactor: address clippy issues

* chore: doc and todo update

* refactor: add builder for RegionDescriptor
This commit is contained in:
Ning Sun
2022-07-29 14:31:12 +08:00
committed by GitHub
parent 45490b6293
commit 62cb649389
10 changed files with 250 additions and 261 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/table-engine/src/engine.rs
View File

@@ -116,27 +116,33 @@ impl<Store: StorageEngine> MitoEngineInner<Store> {
let host_column =
ColumnDescriptorBuilder::new(0, "host", ConcreteDataType::string_datatype())
.is_nullable(false)
.build();
.build()
.unwrap();
let cpu_column =
ColumnDescriptorBuilder::new(1, "cpu", ConcreteDataType::float64_datatype())
.is_nullable(true)
.build();
.build()
.unwrap();
let memory_column =
ColumnDescriptorBuilder::new(2, "memory", ConcreteDataType::float64_datatype())
.is_nullable(true)
.build();
let ts_column =
ColumnDescriptorBuilder::new(0, "ts", ConcreteDataType::int64_datatype()).build();
.build()
.unwrap();
let ts_column = ColumnDescriptorBuilder::new(0, "ts", ConcreteDataType::int64_datatype())
.build()
.unwrap();
let row_key = RowKeyDescriptorBuilder::new(ts_column)
.push_column(host_column)
.enable_version_column(false)
.build();
.build()
.unwrap();
let default_cf = ColumnFamilyDescriptorBuilder::default()
.push_column(cpu_column)
.push_column(memory_column)
.build();
.build()
.unwrap();
let region = self
.storage_engine
@@ -155,17 +161,20 @@ impl<Store: StorageEngine> MitoEngineInner<Store> {
.context(error::CreateRegionSnafu)?;
// Use region meta schema instead of request schema
let table_meta = TableMetaBuilder::new(region.in_memory_metadata().schema().clone())
let table_meta = TableMetaBuilder::default()
.schema(region.in_memory_metadata().schema().clone())
.engine(DEFAULT_ENGINE)
.build();
.build()
.unwrap();
let table_name = request.name;
let table_info = TableInfoBuilder::new(table_name.clone(), table_meta)
.table_id(self.next_table_id())
.ident(self.next_table_id())
.table_version(0u64)
.table_type(TableType::Base)
.desc(request.desc)
.build();
.build()
.unwrap();
let table = Arc::new(MitoTable::new(table_info, region));