From 658332fe686328e37112faa08c15281e979d7768 Mon Sep 17 00:00:00 2001 From: Lanqing Yang Date: Thu, 18 Dec 2025 21:09:32 +0800 Subject: [PATCH] chore(mito): nit remove extra hashset in gc workers (#7399) chore(mito): remove extra hashset in gc workers Signed-off-by: lyang24 --- src/mito2/src/gc.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/mito2/src/gc.rs b/src/mito2/src/gc.rs index d4c02b0b0a..ed8841794b 100644 --- a/src/mito2/src/gc.rs +++ b/src/mito2/src/gc.rs @@ -540,7 +540,7 @@ impl LocalGcWorker { fn filter_deletable_files( &self, entries: Vec, - in_use_filenames: &HashSet<&FileId>, + in_use_filenames: &HashSet, may_linger_filenames: &HashSet<&FileId>, eligible_for_removal: &HashSet<&FileId>, unknown_file_may_linger_until: chrono::DateTime, @@ -641,9 +641,6 @@ impl LocalGcWorker { .flatten() .collect::>(); - // in use filenames, include sst and index files - let in_use_filenames = in_used.iter().collect::>(); - // When full_file_listing is false, skip expensive list operations and only delete // files that are tracked in recently_removed_files if !self.full_file_listing { @@ -653,7 +650,7 @@ impl LocalGcWorker { // 3. Have passed the lingering time let files_to_delete: Vec = eligible_for_removal .iter() - .filter(|file_id| !in_use_filenames.contains(*file_id)) + .filter(|file_id| !in_used.contains(*file_id)) .map(|&f| *f) .collect(); @@ -672,7 +669,7 @@ impl LocalGcWorker { let (all_unused_files_ready_for_delete, all_in_exist_linger_files) = self .filter_deletable_files( all_entries, - &in_use_filenames, + in_used, &may_linger_filenames, &eligible_for_removal, unknown_file_may_linger_until,