rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2025-12-26 08:00:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT (#1904)

Browse Source 
* feat!: rename WITH parameter ENDPOINT_URL to ENDPOINT

* fix: typo
This commit is contained in:
Weny Xu
2023-07-07 18:04:24 +09:00
committed by GitHub
parent 55500b7711
commit 6dd24f4dc4
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/rfcs/2023-07-06-table-engine-refactor.md
View File

@@ -131,7 +131,7 @@ region3-->RegionManifest3
This RFC proposes to refactor table engines into region engines as a first step to make the `Datanode` acts like a `RegionServer`. This RFC proposes to refactor table engines into region engines as a first step to make the `Datanode` acts like a `RegionServer`.
# Detials # Details
## Overview ## Overview
We plan to refactor the `TableEngine` trait into `RegionEngine` gradually. This RFC focuses on the `mito` engine as it is the default table engine and the most complicated engine. We plan to refactor the `TableEngine` trait into `RegionEngine` gradually. This RFC focuses on the `mito` engine as it is the default table engine and the most complicated engine.

4
src/common/datasource/src/object_store/s3.rs
View File

@@ -20,7 +20,7 @@ use snafu::ResultExt;
use crate::error::{self, Result}; use crate::error::{self, Result};
const ENDPOINT_URL: &str = "endpoint_url"; const ENDPOINT: &str = "endpoint";
const ACCESS_KEY_ID: &str = "access_key_id"; const ACCESS_KEY_ID: &str = "access_key_id";
const SECRET_ACCESS_KEY: &str = "secret_access_key"; const SECRET_ACCESS_KEY: &str = "secret_access_key";
const SESSION_TOKEN: &str = "session_token"; const SESSION_TOKEN: &str = "session_token";
@@ -36,7 +36,7 @@ pub fn build_s3_backend(
let _ = builder.root(path).bucket(host); let _ = builder.root(path).bucket(host);
if let Some(endpoint) = connection.get(ENDPOINT_URL) { if let Some(endpoint) = connection.get(ENDPOINT) {
let _ = builder.endpoint(endpoint); let _ = builder.endpoint(endpoint);
} }