From 7375b34ebec644c1ea0a6197c8a9722ab2e416f5 Mon Sep 17 00:00:00 2001 From: WenyXu Date: Thu, 6 Jun 2024 12:45:10 +0000 Subject: [PATCH] fix: add default value for `MetaClientOptions` --- src/meta-client/src/lib.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/meta-client/src/lib.rs b/src/meta-client/src/lib.rs index f7329b4fb6..ea4d07a749 100644 --- a/src/meta-client/src/lib.rs +++ b/src/meta-client/src/lib.rs @@ -22,6 +22,7 @@ pub mod error; // Options for meta client in datanode instance. #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] pub struct MetaClientOptions { + #[serde(default = "default_metasrc_addrs")] pub metasrv_addrs: Vec, #[serde(default = "default_timeout")] #[serde(with = "humantime_serde")] @@ -35,6 +36,7 @@ pub struct MetaClientOptions { #[serde(default = "default_connect_timeout")] #[serde(with = "humantime_serde")] pub connect_timeout: Duration, + #[serde(default = "default_tcp_nodelay")] pub tcp_nodelay: bool, #[serde(default = "default_metadata_cache_max_capacity")] pub metadata_cache_max_capacity: u64, @@ -74,15 +76,23 @@ fn default_metadata_cache_tti() -> Duration { Duration::from_secs(300u64) } +fn default_tcp_nodelay() -> bool { + true +} + +fn default_metasrc_addrs() -> Vec { + vec!["127.0.0.1:3002".to_string()] +} + impl Default for MetaClientOptions { fn default() -> Self { Self { - metasrv_addrs: vec!["127.0.0.1:3002".to_string()], + metasrv_addrs: default_metasrc_addrs(), timeout: default_timeout(), heartbeat_timeout: default_heartbeat_timeout(), ddl_timeout: default_ddl_timeout(), connect_timeout: default_connect_timeout(), - tcp_nodelay: true, + tcp_nodelay: default_tcp_nodelay(), metadata_cache_max_capacity: default_metadata_cache_max_capacity(), metadata_cache_ttl: default_metadata_cache_ttl(), metadata_cache_tti: default_metadata_cache_tti(),