From 7a9dd5f0c8a89443d261c20787a3cc3be73e2c44 Mon Sep 17 00:00:00 2001
From: JeremyHi <jiachun_feng@proton.me>
Date: Wed, 10 May 2023 18:06:04 +0800
Subject: [PATCH] feat: ignore mailbox message into stat (#1560)

---
 src/meta-srv/src/handler/collect_stats_handler.rs   | 6 ++++++
 src/meta-srv/src/handler/persist_stats_handler.rs   | 1 -
 src/meta-srv/src/handler/response_header_handler.rs | 1 +
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/meta-srv/src/handler/collect_stats_handler.rs b/src/meta-srv/src/handler/collect_stats_handler.rs
index 5fc38379e1..d82874caf9 100644
--- a/src/meta-srv/src/handler/collect_stats_handler.rs
+++ b/src/meta-srv/src/handler/collect_stats_handler.rs
@@ -34,6 +34,12 @@ impl HeartbeatHandler for CollectStatsHandler {
         _ctx: &mut Context,
         acc: &mut HeartbeatAccumulator,
     ) -> Result<()> {
+        if req.mailbox_message.is_some() {
+            // If the heartbeat is a mailbox message, it may have no other valid information,
+            // so we don't need to collect stats.
+            return Ok(());
+        }
+
         match Stat::try_from(req.clone()) {
             Ok(stat) => {
                 let _ = acc.stat.insert(stat);
diff --git a/src/meta-srv/src/handler/persist_stats_handler.rs b/src/meta-srv/src/handler/persist_stats_handler.rs
index d7395e15a1..7cc30363d0 100644
--- a/src/meta-srv/src/handler/persist_stats_handler.rs
+++ b/src/meta-srv/src/handler/persist_stats_handler.rs
@@ -55,7 +55,6 @@ impl HeartbeatHandler for PersistStatsHandler {
         }
 
         let stats = stats.drain(..).collect();
-
         let val = StatValue { stats };
 
         let put = PutRequest {
diff --git a/src/meta-srv/src/handler/response_header_handler.rs b/src/meta-srv/src/handler/response_header_handler.rs
index 28fffa3c29..bc80730751 100644
--- a/src/meta-srv/src/handler/response_header_handler.rs
+++ b/src/meta-srv/src/handler/response_header_handler.rs
@@ -40,6 +40,7 @@ impl HeartbeatHandler for ResponseHeaderHandler {
             ..Default::default()
         };
         acc.header = Some(res_header);
+
         Ok(())
     }
 }