From 819c990a89ff9be699a16373f1aa16a8fc8e6758 Mon Sep 17 00:00:00 2001
From: fys <40801205+Fengys123@users.noreply.github.com>
Date: Fri, 24 Feb 2023 15:36:32 +0800
Subject: [PATCH] fix: thread that reports the heartbeat panics in unit test
 (#1078)

fix: ut panic in heartbeat report thread
---
 src/datanode/src/mock.rs | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/datanode/src/mock.rs b/src/datanode/src/mock.rs
index ed764c2fae..c54491f800 100644
--- a/src/datanode/src/mock.rs
+++ b/src/datanode/src/mock.rs
@@ -60,7 +60,7 @@ impl Instance {
         ));
 
         // By default, catalog manager and factory are created in standalone mode
-        let (catalog_manager, factory) = match opts.mode {
+        let (catalog_manager, factory, heartbeat_task) = match opts.mode {
             Mode::Standalone => {
                 let catalog = Arc::new(
                     catalog::local::LocalCatalogManager::try_new(table_engine.clone())
@@ -68,7 +68,7 @@ impl Instance {
                         .context(CatalogSnafu)?,
                 );
                 let factory = QueryEngineFactory::new(catalog.clone());
-                (catalog as CatalogManagerRef, factory)
+                (catalog as CatalogManagerRef, factory, None)
             }
             Mode::Distributed => {
                 let catalog = Arc::new(catalog::remote::RemoteCatalogManager::new(
@@ -79,20 +79,20 @@ impl Instance {
                     }),
                 ));
                 let factory = QueryEngineFactory::new(catalog.clone());
-                (catalog as CatalogManagerRef, factory)
+                let heartbeat_task = HeartbeatTask::new(
+                    opts.node_id.unwrap_or(42),
+                    opts.rpc_addr.clone(),
+                    None,
+                    meta_client.clone(),
+                    catalog.clone(),
+                );
+                (catalog as CatalogManagerRef, factory, Some(heartbeat_task))
             }
         };
         let query_engine = factory.query_engine();
         let script_executor =
             ScriptExecutor::new(catalog_manager.clone(), query_engine.clone()).await?;
 
-        let heartbeat_task = HeartbeatTask::new(
-            opts.node_id.unwrap_or(42),
-            opts.rpc_addr.clone(),
-            None,
-            meta_client.clone(),
-            catalog_manager.clone(),
-        );
         Ok(Self {
             query_engine: query_engine.clone(),
             sql_handler: SqlHandler::new(
@@ -103,7 +103,7 @@ impl Instance {
             catalog_manager,
             script_executor,
             table_id_provider: Some(Arc::new(LocalTableIdProvider::default())),
-            heartbeat_task: Some(heartbeat_task),
+            heartbeat_task,
         })
     }
 }