diff --git a/src/common/meta/src/key.rs b/src/common/meta/src/key.rs index 027c6a5896..dd5f9c88c6 100644 --- a/src/common/meta/src/key.rs +++ b/src/common/meta/src/key.rs @@ -53,8 +53,6 @@ pub mod schema_name; pub mod table_info; pub mod table_name; pub mod table_region; -// TODO(weny): removes it. -#[allow(unused)] pub mod table_route; use std::sync::Arc; diff --git a/src/common/meta/src/key/datanode_table.rs b/src/common/meta/src/key/datanode_table.rs index ea77b102f2..31a577d5ce 100644 --- a/src/common/meta/src/key/datanode_table.rs +++ b/src/common/meta/src/key/datanode_table.rs @@ -43,7 +43,6 @@ impl DatanodeTableKey { format!("{}/{datanode_id}", DATANODE_TABLE_KEY_PREFIX) } - #[allow(unused)] pub fn strip_table_id(raw_key: &[u8]) -> Result { let key = String::from_utf8(raw_key.to_vec()).map_err(|e| { InvalidTableMetadataSnafu { diff --git a/src/common/meta/src/key/table_route.rs b/src/common/meta/src/key/table_route.rs index 8f1f656b1a..dffda1ce23 100644 --- a/src/common/meta/src/key/table_route.rs +++ b/src/common/meta/src/key/table_route.rs @@ -15,19 +15,16 @@ use std::fmt::Display; use api::v1::meta::TableName; -use futures::future::try_join_all; -use serde::__private::de; use serde::{Deserialize, Serialize}; use snafu::ensure; use table::metadata::TableId; use crate::error::{Result, UnexpectedSnafu}; use crate::key::{to_removed_key, TableMetaKey}; -use crate::kv_backend::txn::{Compare, CompareOp, Txn, TxnOp, TxnOpResponse, TxnRequest}; +use crate::kv_backend::txn::{Compare, CompareOp, Txn, TxnOp, TxnOpResponse}; use crate::kv_backend::KvBackendRef; -use crate::rpc::router::{region_distribution, RegionRoute, Table, TableRoute}; -use crate::rpc::store::{BatchGetRequest, CompareAndPutRequest, MoveValueRequest}; -use crate::rpc::KeyValue; +use crate::rpc::router::RegionRoute; +use crate::rpc::store::{CompareAndPutRequest, MoveValueRequest}; pub const TABLE_ROUTE_PREFIX: &str = "__meta_table_route"; @@ -319,19 +316,13 @@ mod tests { use super::TableRouteKey; use crate::key::table_route::{TableRouteManager, TableRouteValue}; use crate::kv_backend::memory::MemoryKvBackend; - use crate::rpc::router::{RegionRoute, Table, TableRoute}; - use crate::table_name::TableName; + use crate::rpc::router::RegionRoute; #[tokio::test] async fn test_table_route_manager() { let mgr = TableRouteManager::new(Arc::new(MemoryKvBackend::default())); let table_id = 1024u32; - let table = Table { - id: table_id as u64, - table_name: TableName::new("foo", "bar", "baz"), - table_schema: b"mock schema".to_vec(), - }; let region_route = RegionRoute::default(); let region_routes = vec![region_route]; @@ -349,11 +340,13 @@ mod tests { let mut updated = expect.clone(); updated.region_routes.push(RegionRoute::default()); - mgr.compare_and_put(1024, Some(expect.clone()), updated.region_routes.clone()) + let _ = mgr + .compare_and_put(1024, Some(expect.clone()), updated.region_routes.clone()) .await .unwrap(); - mgr.compare_and_put(1024, Some(expect.clone()), updated.region_routes) + let _ = mgr + .compare_and_put(1024, Some(expect.clone()), updated.region_routes) .await .unwrap(); } diff --git a/src/meta-srv/src/ddl.rs b/src/meta-srv/src/ddl.rs index 3c4b0a5828..cb154d9fad 100644 --- a/src/meta-srv/src/ddl.rs +++ b/src/meta-srv/src/ddl.rs @@ -51,7 +51,6 @@ pub(crate) struct DdlContext { pub(crate) datanode_clients: Arc, pub(crate) mailbox: MailboxRef, pub(crate) server_addr: String, - #[allow(unused)] pub(crate) table_metadata_manager: TableMetadataManagerRef, } diff --git a/src/meta-srv/src/procedure/region_failover.rs b/src/meta-srv/src/procedure/region_failover.rs index 06b0049460..efe1acb3bc 100644 --- a/src/meta-srv/src/procedure/region_failover.rs +++ b/src/meta-srv/src/procedure/region_failover.rs @@ -453,12 +453,6 @@ mod tests { Self { selector: None } } - #[allow(unused)] - pub fn with_selector(mut self, selector: SelectorRef) -> Self { - self.selector = Some(selector); - self - } - pub async fn build(self) -> TestingEnv { let in_memory = Arc::new(MemStore::new()); let kv_store: KvStoreRef = Arc::new(MemStore::new());