From 8d229dda987c53addbefdbbe7986ed3d31f669a6 Mon Sep 17 00:00:00 2001 From: "Lei, HUANG" <6406592+v0y4g3r@users.noreply.github.com> Date: Wed, 24 Apr 2024 15:08:01 +0800 Subject: [PATCH] chore: always obsolete wal to avoid discontinuous log entries (#3789) --- src/mito2/src/region/opener.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/mito2/src/region/opener.rs b/src/mito2/src/region/opener.rs index 0744c49202..2bdeed1c1c 100644 --- a/src/mito2/src/region/opener.rs +++ b/src/mito2/src/region/opener.rs @@ -441,13 +441,11 @@ pub(crate) async fn replay_memtable( // data in the WAL. let mut last_entry_id = flushed_entry_id; let replay_from_entry_id = flushed_entry_id + 1; - let mut stale_entry_found = false; let mut wal_stream = wal.scan(region_id, replay_from_entry_id, wal_options)?; while let Some(res) = wal_stream.next().await { let (entry_id, entry) = res?; if entry_id <= flushed_entry_id { - stale_entry_found = true; warn!("Stale WAL entries read during replay, region id: {}, flushed entry id: {}, entry id read: {}", region_id, flushed_entry_id, entry_id); ensure!( allow_stale_entries, @@ -476,11 +474,8 @@ pub(crate) async fn replay_memtable( region_write_ctx.write_memtable(); } - if allow_stale_entries && stale_entry_found { - wal.obsolete(region_id, flushed_entry_id, wal_options) - .await?; - info!("Force obsolete WAL entries, region id: {}, flushed entry id: {}, last entry id read: {}", region_id, flushed_entry_id, last_entry_id); - } + wal.obsolete(region_id, flushed_entry_id, wal_options) + .await?; info!( "Replay WAL for region: {}, rows recovered: {}, last entry id: {}",