From 8e7e68708f97bd698fb4e5eb867489c7bf2f2751 Mon Sep 17 00:00:00 2001 From: Ning Sun Date: Wed, 1 Mar 2023 16:59:11 +0800 Subject: [PATCH] docs: correct readme format (#1105) * docs: correct readme format * ci: fix config name --- ...pr-title-breaking-change-label-config.json} | 0 README.md | 11 ++++++----- .../src/python/ffi_types/vector/tests.rs | 18 +++++++----------- 3 files changed, 13 insertions(+), 16 deletions(-) rename .github/{pr-title-breaking-change-lable-config.json => pr-title-breaking-change-label-config.json} (100%) diff --git a/.github/pr-title-breaking-change-lable-config.json b/.github/pr-title-breaking-change-label-config.json similarity index 100% rename from .github/pr-title-breaking-change-lable-config.json rename to .github/pr-title-breaking-change-label-config.json diff --git a/README.md b/README.md index d258339d22..16cc9ead4f 100644 --- a/README.md +++ b/README.md @@ -61,11 +61,12 @@ To compile GreptimeDB from source, you'll need: find an installation instructions [here](https://grpc.io/docs/protoc-installation/). **Note that `protoc` version needs to be >= 3.15** because we have used the `optional` keyword. You can check it with `protoc --version`. -- python3-dev or python3-devel(Optional, only needed if you want to run scripts in cpython): this install a Python shared library required for running python scripting engine(In CPython Mode). - This is available as `python3-dev` on ubuntu, you can install it with `sudo apt install python3-dev`, or `python3-devel` on RPM based distributions (e.g. Fedora, Red Hat, SuSE), Mac 's Python3 package should have this shared library by default. -Then, you can build GreptimeDB from source code: - -``` +- python3-dev or python3-devel(Optional, only needed if you want to run scripts + in cpython): this install a Python shared library required for running python + scripting engine(In CPython Mode). This is available as `python3-dev` on + ubuntu, you can install it with `sudo apt install python3-dev`, or + `python3-devel` on RPM based distributions (e.g. Fedora, Red Hat, SuSE). Mac's + `Python3` package should have this shared library by default. #### Build with Docker diff --git a/src/script/src/python/ffi_types/vector/tests.rs b/src/script/src/python/ffi_types/vector/tests.rs index 66007b5b53..e43380e04f 100644 --- a/src/script/src/python/ffi_types/vector/tests.rs +++ b/src/script/src/python/ffi_types/vector/tests.rs @@ -57,8 +57,8 @@ fn test_eval_py_vector_in_pairs() { fn sample_py_vector() -> HashMap { let b1 = Arc::new(BooleanVector::from_slice(&[false, false, true, true])) as VectorRef; let b2 = Arc::new(BooleanVector::from_slice(&[false, true, false, true])) as VectorRef; - let f1 = Arc::new(Float64Vector::from_slice(&[0.0f64, 2.0, 10.0, 42.0])) as VectorRef; - let f2 = Arc::new(Float64Vector::from_slice(&[-0.1f64, -42.0, 2., 7.0])) as VectorRef; + let f1 = Arc::new(Float64Vector::from_slice([0.0f64, 2.0, 10.0, 42.0])) as VectorRef; + let f2 = Arc::new(Float64Vector::from_slice([-0.1f64, -42.0, 2., 7.0])) as VectorRef; HashMap::from([ ("b1".to_owned(), b1), ("b2".to_owned(), b2), @@ -85,24 +85,20 @@ fn get_test_cases() -> Vec { }, TestCase { eval: "f1+f2".to_string(), - result: Arc::new(Float64Vector::from_slice(&[-0.1f64, -40.0, 12., 49.0])) as VectorRef, + result: Arc::new(Float64Vector::from_slice([-0.1f64, -40.0, 12., 49.0])) as VectorRef, }, TestCase { eval: "f1-f2".to_string(), - result: Arc::new(Float64Vector::from_slice(&[0.1f64, 44.0, 8., 35.0])) as VectorRef, + result: Arc::new(Float64Vector::from_slice([0.1f64, 44.0, 8., 35.0])) as VectorRef, }, TestCase { eval: "f1*f2".to_string(), - result: Arc::new(Float64Vector::from_slice(&[ - -0.0f64, - -84.0, - 20., - 42.0 * 7.0, - ])) as VectorRef, + result: Arc::new(Float64Vector::from_slice([-0.0f64, -84.0, 20., 42.0 * 7.0])) + as VectorRef, }, TestCase { eval: "f1/f2".to_string(), - result: Arc::new(Float64Vector::from_slice(&[ + result: Arc::new(Float64Vector::from_slice([ 0.0 / -0.1f64, 2. / -42., 10. / 2.,