diff --git a/src/datatypes/src/scalars.rs b/src/datatypes/src/scalars.rs index 2018cefac7..13b2e4ad7f 100644 --- a/src/datatypes/src/scalars.rs +++ b/src/datatypes/src/scalars.rs @@ -1,5 +1,4 @@ use std::any::Any; -use std::default; use common_time::{Date, DateTime, Timestamp}; diff --git a/src/datatypes/src/types/geometry.rs b/src/datatypes/src/types/geometry.rs index 4fc5d0ce58..5909dfd5e4 100644 --- a/src/datatypes/src/types/geometry.rs +++ b/src/datatypes/src/types/geometry.rs @@ -1,7 +1,7 @@ use serde::{Deserialize, Serialize}; use crate::data_type::DataType; -use crate::prelude::{DataTypeRef, LogicalTypeId, Value}; +use crate::prelude::LogicalTypeId; use crate::value::GeometryValue; use crate::vectors::geometry::GeometryVectorBuilder; diff --git a/src/datatypes/src/value.rs b/src/datatypes/src/value.rs index 21e8259a53..8b3a9eaee1 100644 --- a/src/datatypes/src/value.rs +++ b/src/datatypes/src/value.rs @@ -591,7 +591,7 @@ impl<'a> PartialEq for GeometryValueRef<'a> { impl<'a> Eq for GeometryValueRef<'a> {} impl<'a> Ord for GeometryValueRef<'a> { - fn cmp(&self, other: &Self) -> Ordering { + fn cmp(&self, _other: &Self) -> Ordering { unreachable!() } } diff --git a/src/datatypes/src/vectors/geometry.rs b/src/datatypes/src/vectors/geometry.rs index 1e8d6c8aa6..6b6162aea2 100644 --- a/src/datatypes/src/vectors/geometry.rs +++ b/src/datatypes/src/vectors/geometry.rs @@ -1,18 +1,16 @@ use std::sync::Arc; use arrow::array::{Array, MutableArray}; -use snafu::{ensure, OptionExt, ResultExt}; +use snafu::{OptionExt, ResultExt}; use self::point::{PointVector, PointVectorBuilder}; -use super::{MutableVector, Validity, Value, Vector}; +use super::{MutableVector, Vector}; use crate::error::SerializeSnafu; use crate::prelude::ScalarRef; use crate::types::GeometryType; use crate::value::{GeometryValueRef, ValueRef}; -use crate::vectors::{impl_try_from_arrow_array_for_vector, impl_validity_for_vector}; use crate::{ data_type::ConcreteDataType, - error, prelude::{ScalarVector, ScalarVectorBuilder}, serialize::Serializable, value::GeometryValue, @@ -230,7 +228,7 @@ impl MutableVector for GeometryVectorBuilder { impl ScalarVectorBuilder for GeometryVectorBuilder { type VectorType = GeometryVector; - fn with_capacity(capacity: usize) -> Self { + fn with_capacity(_capacity: usize) -> Self { unimplemented!() } diff --git a/src/datatypes/src/vectors/geometry/point.rs b/src/datatypes/src/vectors/geometry/point.rs index df7847412a..d2cd12d455 100644 --- a/src/datatypes/src/vectors/geometry/point.rs +++ b/src/datatypes/src/vectors/geometry/point.rs @@ -1,19 +1,10 @@ -use std::sync::Arc; - -use arrow::array::{ - Array, FixedSizeListArray, Float64Vec, ListArray, MutableArray, MutableFixedSizeListArray, - PrimitiveArray, StructArray, -}; -use arrow::datatypes::DataType::{self, Float64, List}; +use arrow::array::{Array, Float64Vec, MutableArray, PrimitiveArray, StructArray}; +use arrow::datatypes::DataType::{self, Float64}; use arrow::datatypes::Field; -use geo::Point; -use crate::value::{GeometryValue, GeometryValueRef, OrderedF64, Value, ValueRef}; +use crate::prelude::Validity; +use crate::value::{GeometryValue, Value}; use crate::vectors::impl_validity_for_vector; -use crate::{ - prelude::{ScalarVector, ScalarVectorBuilder, Validity, Vector}, - vectors::MutableVector, -}; #[derive(Debug, Clone, PartialEq)] pub struct PointVector { pub array: StructArray, diff --git a/src/datatypes/src/vectors/operations.rs b/src/datatypes/src/vectors/operations.rs index a9dabbb177..6acec24f92 100644 --- a/src/datatypes/src/vectors/operations.rs +++ b/src/datatypes/src/vectors/operations.rs @@ -120,15 +120,15 @@ where } } impl VectorOp for GeometryVector { - fn replicate(&self, offsets: &[usize]) -> VectorRef { + fn replicate(&self, _offsets: &[usize]) -> VectorRef { todo!() } - fn dedup(&self, selected: &mut MutableBitmap, prev_vector: Option<&dyn Vector>) { + fn dedup(&self, _selected: &mut MutableBitmap, _prev_vector: Option<&dyn Vector>) { todo!() } - fn filter(&self, filter: &BooleanVector) -> Result { + fn filter(&self, _filter: &BooleanVector) -> Result { todo!() } }