refactor: make grpc service able to be added dynamically (#3160)

src/cmd/Cargo.toml

@@ -18,7 +18,7 @@ async-trait.workspace = true
 auth.workspace = true
 catalog.workspace = true
 chrono.workspace = true
-clap = { version = "4.4", features = ["derive"] }
+clap.workspace = true
 client.workspace = true
 common-base.workspace = true
 common-catalog.workspace = true

src/cmd/src/datanode.rs

@@ -22,6 +22,7 @@ use common_config::WalConfig;
 use common_telemetry::{info, logging};
 use datanode::config::DatanodeOptions;
 use datanode::datanode::{Datanode, DatanodeBuilder};
+use datanode::service::DatanodeServiceBuilder;
 use meta_client::MetaClientOptions;
 use servers::Mode;
 use snafu::{OptionExt, ResultExt};
@@ -38,6 +39,10 @@ impl Instance {
     fn new(datanode: Datanode) -> Self {
         Self { datanode }
     }
+
+    pub fn datanode_mut(&mut self) -> &mut Datanode {
+        &mut self.datanode
+    }
 }
 
 #[async_trait]
@@ -219,15 +224,20 @@ impl StartCommand {
             client: Arc::new(meta_client.clone()),
         });
 
-        let datanode = DatanodeBuilder::new(opts, plugins)
+        let mut datanode = DatanodeBuilder::new(opts.clone(), plugins)
             .with_meta_client(meta_client)
             .with_kv_backend(meta_backend)
-            .enable_region_server_service()
-            .enable_http_service()
             .build()
             .await
             .context(StartDatanodeSnafu)?;
 
+        let services = DatanodeServiceBuilder::new(&opts)
+            .with_default_grpc_server(&datanode.region_server())
+            .enable_http_service()
+            .build()
+            .context(StartDatanodeSnafu)?;
+        datanode.setup_services(services);
+
         Ok(Instance::new(datanode))
     }
 }

src/cmd/src/lib.rs

@@ -35,6 +35,11 @@ lazy_static::lazy_static! {
 pub trait App {
     fn name(&self) -> &str;
 
+    /// A hook for implementor to make something happened before actual startup. Defaults to no-op.
+    fn pre_start(&mut self) -> error::Result<()> {
+        Ok(())
+    }
+
     async fn start(&mut self) -> error::Result<()>;
 
     async fn stop(&self) -> error::Result<()>;