From 9c4aa81f85a7d300af9013475daf6867446d205a Mon Sep 17 00:00:00 2001 From: WenyXu Date: Mon, 10 Feb 2025 13:24:23 +0000 Subject: [PATCH] fix: fix add column validation --- src/metric-engine/src/engine/alter/extract_new_columns.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/metric-engine/src/engine/alter/extract_new_columns.rs b/src/metric-engine/src/engine/alter/extract_new_columns.rs index 50ccf7cbcd..fdb1ef6126 100644 --- a/src/metric-engine/src/engine/alter/extract_new_columns.rs +++ b/src/metric-engine/src/engine/alter/extract_new_columns.rs @@ -14,13 +14,11 @@ use std::collections::{HashMap, HashSet}; -use api::v1::SemanticType; -use snafu::ensure; use store_api::metadata::ColumnMetadata; use store_api::region_request::{AlterKind, RegionAlterRequest}; use store_api::storage::{ColumnId, RegionId}; -use crate::error::{AddingFieldColumnSnafu, Result}; +use crate::error::Result; /// Extract new columns from the create requests. /// @@ -42,10 +40,6 @@ pub fn extract_new_columns<'a>( if !physical_columns.contains_key(column_name) && !new_column_names.contains(column_name) { - ensure!( - col.column_metadata.semantic_type != SemanticType::Field, - AddingFieldColumnSnafu { name: column_name } - ); new_column_names.insert(column_name); // TODO(weny): avoid clone new_columns.push(col.column_metadata.clone());