From 9f442dedf9b73c1ca8a0251c650bba808a930f91 Mon Sep 17 00:00:00 2001 From: Hao Date: Sun, 23 Apr 2023 12:21:25 +0800 Subject: [PATCH] chore: fix some typo and add deriv to plan in promql (#1438) --- src/promql/src/functions/deriv.rs | 4 ++-- src/promql/src/planner.rs | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/promql/src/functions/deriv.rs b/src/promql/src/functions/deriv.rs index 1f4b6597e4..4ba0a30438 100644 --- a/src/promql/src/functions/deriv.rs +++ b/src/promql/src/functions/deriv.rs @@ -29,8 +29,8 @@ use datatypes::arrow::datatypes::DataType; use crate::functions::{extract_array, linear_regression}; use crate::range_array::RangeArray; -#[range_fn(name = "Deriv", ret = "Float64Array", display_name = "prom_drive")] -pub fn drive(times: &TimestampMillisecondArray, values: &Float64Array) -> Option { +#[range_fn(name = "Deriv", ret = "Float64Array", display_name = "prom_deriv")] +pub fn deriv(times: &TimestampMillisecondArray, values: &Float64Array) -> Option { if values.len() < 2 { None } else { diff --git a/src/promql/src/planner.rs b/src/promql/src/planner.rs index 358bc54103..1a710cb8cc 100644 --- a/src/promql/src/planner.rs +++ b/src/promql/src/planner.rs @@ -51,9 +51,9 @@ use crate::extension_plan::{ EmptyMetric, InstantManipulate, Millisecond, RangeManipulate, SeriesDivide, SeriesNormalize, }; use crate::functions::{ - AbsentOverTime, AvgOverTime, Changes, CountOverTime, Delta, HoltWinters, IDelta, Increase, - LastOverTime, MaxOverTime, MinOverTime, PredictLinear, PresentOverTime, QuantileOverTime, Rate, - Resets, StddevOverTime, StdvarOverTime, SumOverTime, + AbsentOverTime, AvgOverTime, Changes, CountOverTime, Delta, Deriv, HoltWinters, IDelta, + Increase, LastOverTime, MaxOverTime, MinOverTime, PredictLinear, PresentOverTime, + QuantileOverTime, Rate, Resets, StddevOverTime, StdvarOverTime, SumOverTime, }; const LEFT_PLAN_JOIN_ALIAS: &str = "lhs"; @@ -776,6 +776,7 @@ impl PromPlanner { "irate" => ScalarFunc::Udf(IDelta::::scalar_udf()), "resets" => ScalarFunc::Udf(Resets::scalar_udf()), "changes" => ScalarFunc::Udf(Changes::scalar_udf()), + "deriv" => ScalarFunc::Udf(Deriv::scalar_udf()), "avg_over_time" => ScalarFunc::Udf(AvgOverTime::scalar_udf()), "min_over_time" => ScalarFunc::Udf(MinOverTime::scalar_udf()), "max_over_time" => ScalarFunc::Udf(MaxOverTime::scalar_udf()),