rust/greptimedb
1
0
Fork 0
mirror of https://github.com/GreptimeTeam/greptimedb.git synced 2026-01-06 21:32:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: sort condition in HistogramFold (#2674)

Browse Source 
* sort ts before le

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* add test case

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

---------

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
This commit is contained in:
Ruihang Xia
2023-11-01 16:28:53 +08:00
committed by GitHub
parent 5f3bbdca4f
commit a9137b77f0
3 changed files with 78 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tests/cases/standalone/common/promql/simple_histogram.result
View File

@@ -244,3 +244,44 @@ drop table histogram2_bucket;
Affected Rows: 0
-- not from Prometheus
-- makesure the sort expr works as expected
create table histogram3_bucket (
ts timestamp time index,
le string,
s string,
val double,
primary key (s, le),
);
Affected Rows: 0
insert into histogram3_bucket values
(2900000, "0.1", "a", 0),
(2900000, "1", "a", 0),
(2900000, "5", "a", 0),
(2900000, "+Inf", "a", 0),
(3000000, "0.1", "a", 50),
(3000000, "1", "a", 70),
(3000000, "5", "a", 110),
(3000000, "+Inf", "a", 120),
(3005000, "0.1", "a", 10),
(3005000, "1", "a", 20),
(3005000, "5", "a", 20),
(3005000, "+Inf", "a", 30);
Affected Rows: 12
tql eval (3000, 3005, '3s') histogram_quantile(0.5, sum by(le, s) (rate(histogram3_bucket[5m])));
+---+---------------------+---------------------------------+
| s | ts | SUM(prom_rate(ts_range,val,ts)) |
+---+---------------------+---------------------------------+
| a | 1970-01-01T00:50:00 | 0.55 |
| a | 1970-01-01T00:50:03 | 0.5500000000000002 |
+---+---------------------+---------------------------------+
drop table histogram3_bucket;
Affected Rows: 0

28
tests/cases/standalone/common/promql/simple_histogram.sql
View File

@@ -132,3 +132,31 @@ tql eval (2820, 2820, '1s') histogram_quantile(0.5, rate(histogram2_bucket[15m])
tql eval (2820, 2820, '1s') histogram_quantile(0.833, rate(histogram2_bucket[15m]));
drop table histogram2_bucket;
-- not from Prometheus
-- makesure the sort expr works as expected
create table histogram3_bucket (
ts timestamp time index,
le string,
s string,
val double,
primary key (s, le),
);
insert into histogram3_bucket values
(2900000, "0.1", "a", 0),
(2900000, "1", "a", 0),
(2900000, "5", "a", 0),
(2900000, "+Inf", "a", 0),
(3000000, "0.1", "a", 50),
(3000000, "1", "a", 70),
(3000000, "5", "a", 110),
(3000000, "+Inf", "a", 120),
(3005000, "0.1", "a", 10),
(3005000, "1", "a", 20),
(3005000, "5", "a", 20),
(3005000, "+Inf", "a", 30);
tql eval (3000, 3005, '3s') histogram_quantile(0.5, sum by(le, s) (rate(histogram3_bucket[5m])));
drop table histogram3_bucket;