From bd9f7dc40b3aca6fffbca681dca825471691a36d Mon Sep 17 00:00:00 2001 From: Dennis Zhuang Date: Sun, 18 Oct 2026 12:08:07 +0800 Subject: [PATCH] docs(promql): say what draining the histograms after an early stop is for Signed-off-by: Dennis Zhuang --- src/promql/src/histogram_eval/aggregate.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/promql/src/histogram_eval/aggregate.rs b/src/promql/src/histogram_eval/aggregate.rs index 1dd9fb25bc2..548f7a6d57c 100644 --- a/src/promql/src/histogram_eval/aggregate.rs +++ b/src/promql/src/histogram_eval/aggregate.rs @@ -117,7 +117,7 @@ fn aggregate_point<'a>( SampleRef::Histogram(view) => Some(FloatHistogram::try_from_view(&view)), }); let value = sum_or_avg(op, histograms.by_ref())?; - // An early stop leaves samples whose floats and conversion errors still count. + // A fold stopped by mixed bucket kinds still reports conversion errors of later samples. for histogram in histograms { histogram?; }