From cc83764331ac2f35f734dd5617f539c553f01025 Mon Sep 17 00:00:00 2001
From: Weny Xu <wenymedia@gmail.com>
Date: Mon, 9 Oct 2023 20:40:10 +0900
Subject: [PATCH] fix: check table exists before allocating table id (#2546)

* fix: check table exists before allocating table_id

* chore: apply suggestions from CR
---
 src/frontend/src/error.rs                     |  4 ---
 src/operator/src/error.rs                     |  5 ++++
 src/operator/src/statement/ddl.rs             | 25 +++++++++++++++++++
 .../standalone/common/create/create.result    |  4 +++
 .../cases/standalone/common/create/create.sql |  2 ++
 5 files changed, 36 insertions(+), 4 deletions(-)

diff --git a/src/frontend/src/error.rs b/src/frontend/src/error.rs
index 99e8b17b9f..63c009db51 100644
--- a/src/frontend/src/error.rs
+++ b/src/frontend/src/error.rs
@@ -182,9 +182,6 @@ pub enum Error {
     #[snafu(display("Failed to find leaders when altering table, table: {}", table))]
     LeaderNotFound { table: String, location: Location },
 
-    #[snafu(display("Table already exists: `{}`", table))]
-    TableAlreadyExist { table: String, location: Location },
-
     #[snafu(display("Failed to found context value: {}", key))]
     ContextValueNotFound { key: String, location: Location },
 
@@ -345,7 +342,6 @@ impl ErrorExt for Error {
             | Error::ExecLogicalPlan { source, .. } => source.status_code(),
 
             Error::LeaderNotFound { .. } => StatusCode::StorageUnavailable,
-            Error::TableAlreadyExist { .. } => StatusCode::TableAlreadyExists,
             Error::InvokeRegionServer { source, .. } => source.status_code(),
 
             Error::External { source, .. } => source.status_code(),
diff --git a/src/operator/src/error.rs b/src/operator/src/error.rs
index 3939bb28a4..cb9963ced7 100644
--- a/src/operator/src/error.rs
+++ b/src/operator/src/error.rs
@@ -28,6 +28,9 @@ use snafu::{Location, Snafu};
 #[snafu(visibility(pub))]
 #[stack_trace_debug]
 pub enum Error {
+    #[snafu(display("Table already exists: `{}`", table))]
+    TableAlreadyExists { table: String, location: Location },
+
     #[snafu(display("Failed to invalidate table cache"))]
     InvalidateTableCache {
         location: Location,
@@ -512,6 +515,8 @@ impl ErrorExt for Error {
             | Error::InferFileTableSchema { .. }
             | Error::SchemaIncompatible { .. } => StatusCode::InvalidArguments,
 
+            Error::TableAlreadyExists { .. } => StatusCode::TableAlreadyExists,
+
             Error::NotSupported { .. } => StatusCode::Unsupported,
 
             Error::TableMetadataManager { source, .. } => source.status_code(),
diff --git a/src/operator/src/statement/ddl.rs b/src/operator/src/statement/ddl.rs
index 5d6a984eb2..820c51d9b5 100644
--- a/src/operator/src/statement/ddl.rs
+++ b/src/operator/src/statement/ddl.rs
@@ -95,6 +95,31 @@ impl StatementExecutor {
             .fail();
         };
 
+        // if table exists.
+        if let Some(table) = self
+            .catalog_manager
+            .table(
+                &create_table.catalog_name,
+                &create_table.schema_name,
+                &create_table.table_name,
+            )
+            .await
+            .context(error::CatalogSnafu)?
+        {
+            return if create_table.create_if_not_exists {
+                Ok(table)
+            } else {
+                error::TableAlreadyExistsSnafu {
+                    table: format_full_table_name(
+                        &create_table.catalog_name,
+                        &create_table.schema_name,
+                        &create_table.table_name,
+                    ),
+                }
+                .fail()
+            };
+        }
+
         let table_name = TableName::new(
             &create_table.catalog_name,
             &create_table.schema_name,
diff --git a/tests/cases/standalone/common/create/create.result b/tests/cases/standalone/common/create/create.result
index 67df15c3f3..9f110ac743 100644
--- a/tests/cases/standalone/common/create/create.result
+++ b/tests/cases/standalone/common/create/create.result
@@ -46,6 +46,10 @@ CREATE TABLE test2 (i INTEGER, j TIMESTAMP TIME INDEX);
 
 Affected Rows: 0
 
+CREATE TABLE test2 (i INTEGER, j TIMESTAMP TIME INDEX);
+
+Error: 4000(TableAlreadyExists), Table already exists: `greptime.public.test2`
+
 DESC TABLE integers;
 
 +--------+----------------------+-----+------+---------+---------------+
diff --git a/tests/cases/standalone/common/create/create.sql b/tests/cases/standalone/common/create/create.sql
index e8e6120296..61a3588269 100644
--- a/tests/cases/standalone/common/create/create.sql
+++ b/tests/cases/standalone/common/create/create.sql
@@ -22,6 +22,8 @@ CREATE TABLE test2 (i INTEGER, j TIMESTAMP TIME INDEX NULL);
 
 CREATE TABLE test2 (i INTEGER, j TIMESTAMP TIME INDEX);
 
+CREATE TABLE test2 (i INTEGER, j TIMESTAMP TIME INDEX);
+
 DESC TABLE integers;
 
 DESC TABLE test1;