refactor: remove constructors from trait (#121)

* refactor: remove constructors from trait

* refactor: move PutOp into its parent type

* refactor: move put constructor to write request

* refactor: change visibility of PutData constructors

call from WriteRequest instead

* refactor: consistent naming for entry constructor

* refactor: fix constructor form Namespace trait

* refactor: remove comment code

* doc: fix doc comments
This commit is contained in:
Ning Sun
2022-08-02 16:25:03 +08:00
committed by GitHub
parent b5fcdae01d
commit cd42f308a8
18 changed files with 88 additions and 59 deletions

View File

@@ -44,10 +44,10 @@ impl<R: Region> Table for MitoTable<R> {
return Ok(0);
}
let mut write_request = R::WriteRequest::new(self.schema());
let mut write_request = self.region.write_request(self.schema());
//FIXME(dennis): we can only insert to demo table right now
let mut put_op = <<R as Region>::WriteRequest as WriteRequest>::PutOp::new();
let mut put_op = write_request.put_op();
let mut columns_values = request.columns_values;
let key_columns = vec!["ts", "host"];
let value_columns = vec!["cpu", "memory"];