From cd64176418ea100f48fa118cc26d137486ae14da Mon Sep 17 00:00:00 2001
From: discord9 <discord9@163.com>
Date: Fri, 23 Oct 2026 16:29:22 +0800
Subject: [PATCH] fix(sql): preserve lookback when displaying TQL view
 definitions

Signed-off-by: discord9 <discord9@163.com>
---
 src/sql/src/parsers/create_parser.rs | 40 ++++++++++++++++++++--------
 src/sql/src/statements/tql.rs        |  2 +-
 2 files changed, 30 insertions(+), 12 deletions(-)

diff --git a/src/sql/src/parsers/create_parser.rs b/src/sql/src/parsers/create_parser.rs
index adb0bccf898..de9c5657358 100644
--- a/src/sql/src/parsers/create_parser.rs
+++ b/src/sql/src/parsers/create_parser.rs
@@ -3329,17 +3329,35 @@ CREATE TABLE spans (
 
     #[test]
     fn test_parse_create_view_tql_eval() {
-        let sql = "CREATE VIEW test AS TQL EVAL (0, 15, '5s') metric";
-        let result =
-            ParserContext::create_with_dialect(sql, &GreptimeDbDialect {}, ParseOptions::default())
-                .unwrap();
-        assert!(matches!(
-            &result[0],
-            Statement::CreateView(CreateView {
-                query,
-                ..
-            }) if matches!(query.as_ref(), Statement::Tql(Tql::Eval(_)))
-        ));
+        for (query, expected_lookback) in [
+            ("TQL EVAL (0, 15, '5s') metric", None),
+            ("TQL EVAL (0, 15, '5s', '5m') metric", Some("5m")),
+            ("TQL EVAL (0, 15, '5s', '300') metric", Some("300")),
+        ] {
+            let sql = format!("CREATE VIEW test AS {query}");
+            let result = ParserContext::create_with_dialect(
+                &sql,
+                &GreptimeDbDialect {},
+                ParseOptions::default(),
+            )
+            .unwrap();
+            let Statement::CreateView(view) = &result[0] else {
+                panic!("expected CREATE VIEW, got {:?}", result[0]);
+            };
+            let Statement::Tql(Tql::Eval(eval)) = view.query.as_ref() else {
+                panic!("expected TQL EVAL, got {}", view.query);
+            };
+            assert_eq!(eval.lookback.as_deref(), expected_lookback);
+
+            let formatted = result[0].to_string();
+            let reparsed = ParserContext::create_with_dialect(
+                &formatted,
+                &GreptimeDbDialect {},
+                ParseOptions::default(),
+            )
+            .unwrap();
+            assert_eq!(reparsed[0], result[0], "{formatted}");
+        }
 
         for sql in [
             "CREATE VIEW test AS TQL EXPLAIN (0, 15, '5s') metric",
diff --git a/src/sql/src/statements/tql.rs b/src/sql/src/statements/tql.rs
index 835a957eada..948c31ddd8d 100644
--- a/src/sql/src/statements/tql.rs
+++ b/src/sql/src/statements/tql.rs
@@ -46,7 +46,7 @@ fn format_tql(
 ) -> std::fmt::Result {
     write!(f, "({start}, {end}, '{step}'")?;
     if let Some(lookback) = lookback {
-        write!(f, ", {lookback}")?;
+        write!(f, ", '{lookback}'")?;
     }
     if let Some(alias) = alias {
         write!(f, ") {query} AS {alias}")