diff --git a/src/servers/src/error.rs b/src/servers/src/error.rs index 2640454a94..e86ee531f3 100644 --- a/src/servers/src/error.rs +++ b/src/servers/src/error.rs @@ -605,9 +605,7 @@ macro_rules! define_into_tonic_status { fn from(err: $Error) -> Self { use tonic::codegen::http::{HeaderMap, HeaderValue}; use tonic::metadata::MetadataMap; - use $crate::http::header::constants::{ - GREPTIME_DB_HEADER_ERROR_CODE, GREPTIME_DB_HEADER_ERROR_MSG, - }; + use $crate::http::header::constants::GREPTIME_DB_HEADER_ERROR_CODE; let mut headers = HeaderMap::::with_capacity(2); @@ -620,10 +618,6 @@ macro_rules! define_into_tonic_status { ); let root_error = err.output_msg(); - if let Ok(err_msg) = HeaderValue::from_bytes(root_error.as_bytes()) { - let _ = headers.insert(GREPTIME_DB_HEADER_ERROR_MSG, err_msg); - } - let metadata = MetadataMap::from_headers(headers); tonic::Status::with_metadata( $crate::error::status_to_tonic_code(status_code), diff --git a/src/servers/src/http/error_result.rs b/src/servers/src/http/error_result.rs index c92042f323..5b69ba0a6a 100644 --- a/src/servers/src/http/error_result.rs +++ b/src/servers/src/http/error_result.rs @@ -21,7 +21,7 @@ use common_telemetry::logging::{debug, error}; use schemars::JsonSchema; use serde::{Deserialize, Serialize}; -use crate::http::header::constants::{GREPTIME_DB_HEADER_ERROR_CODE, GREPTIME_DB_HEADER_ERROR_MSG}; +use crate::http::header::constants::GREPTIME_DB_HEADER_ERROR_CODE; use crate::http::header::{GREPTIME_DB_HEADER_EXECUTION_TIME, GREPTIME_DB_HEADER_FORMAT}; use crate::http::ResponseFormat; @@ -78,15 +78,10 @@ impl IntoResponse for ErrorResponse { fn into_response(self) -> Response { let ty = self.ty.as_str(); let code = self.code; - let msg = self.error.clone(); let execution_time = self.execution_time_ms; let mut resp = Json(self).into_response(); resp.headers_mut() .insert(GREPTIME_DB_HEADER_ERROR_CODE, HeaderValue::from(code)); - resp.headers_mut().insert( - GREPTIME_DB_HEADER_ERROR_MSG, - HeaderValue::from_str(&msg).expect("malformed error msg"), - ); resp.headers_mut() .insert(&GREPTIME_DB_HEADER_FORMAT, HeaderValue::from_static(ty)); resp.headers_mut().insert( diff --git a/src/servers/src/http/header.rs b/src/servers/src/http/header.rs index fd5dc8c430..ec28f6a446 100644 --- a/src/servers/src/http/header.rs +++ b/src/servers/src/http/header.rs @@ -36,7 +36,6 @@ pub mod constants { pub const GREPTIME_DB_HEADER_NAME: &str = "x-greptime-db-name"; pub const GREPTIME_TIMEZONE_HEADER_NAME: &str = "x-greptime-timezone"; pub const GREPTIME_DB_HEADER_ERROR_CODE: &str = common_error::GREPTIME_DB_HEADER_ERROR_CODE; - pub const GREPTIME_DB_HEADER_ERROR_MSG: &str = common_error::GREPTIME_DB_HEADER_ERROR_MSG; } pub static GREPTIME_DB_HEADER_FORMAT: HeaderName =