From d402f8344271996ae33fd166ca64df41358281b1 Mon Sep 17 00:00:00 2001 From: Ning Sun Date: Wed, 1 Mar 2023 13:18:26 +0800 Subject: [PATCH] ci: generate apidocs when pushing to default branch (#1093) * ci: generate apidocs when pushing to default branch * ci: require clippy before running tests * fix: resolve new clippy warnings on primitive slice * fix: resolve more clippy warnings * Update .github/workflows/apidoc.yml Co-authored-by: Ruihang Xia * ci: add an index html to redirect --------- Co-authored-by: Ruihang Xia --- .github/workflows/apidoc.yml | 39 ++++++++++++++++++ .github/workflows/develop.yml | 6 ++- .github/workflows/release.yml | 8 ++-- rust-toolchain.toml | 2 +- src/catalog/src/system.rs | 8 ++-- src/common/recordbatch/src/adapter.rs | 4 +- src/common/recordbatch/src/lib.rs | 8 ++-- src/common/recordbatch/src/recordbatch.rs | 6 +-- src/datatypes/src/schema/column_schema.rs | 2 +- src/datatypes/src/vectors/binary.rs | 2 +- src/datatypes/src/vectors/boolean.rs | 2 +- src/datatypes/src/vectors/date.rs | 12 +++--- src/datatypes/src/vectors/datetime.rs | 8 ++-- src/datatypes/src/vectors/eq.rs | 30 +++++++------- src/datatypes/src/vectors/list.rs | 4 +- src/datatypes/src/vectors/null.rs | 2 +- src/datatypes/src/vectors/operations/cast.rs | 4 +- .../src/vectors/operations/filter.rs | 2 +- .../src/vectors/operations/find_unique.rs | 32 +++++++-------- src/datatypes/src/vectors/primitive.rs | 8 ++-- src/datatypes/src/vectors/string.rs | 2 +- src/query/src/datafusion.rs | 2 +- src/query/src/sql.rs | 4 +- src/query/src/tests/percentile_test.rs | 2 +- src/query/src/tests/query_engine_test.rs | 4 +- src/script/src/table.rs | 6 +-- src/servers/src/grpc/flight/stream.rs | 2 +- src/storage/benches/wal/util/mod.rs | 4 +- src/storage/src/memtable/tests.rs | 10 ++--- src/storage/src/schema.rs | 8 ++-- src/storage/src/sst/parquet.rs | 2 +- src/storage/src/write_batch.rs | 40 +++++++++---------- src/storage/src/write_batch/codec.rs | 4 +- src/storage/src/write_batch/compat.rs | 2 +- src/table/src/table/scan.rs | 4 +- 35 files changed, 163 insertions(+), 122 deletions(-) create mode 100644 .github/workflows/apidoc.yml diff --git a/.github/workflows/apidoc.yml b/.github/workflows/apidoc.yml new file mode 100644 index 0000000000..e341733776 --- /dev/null +++ b/.github/workflows/apidoc.yml @@ -0,0 +1,39 @@ +on: + push: + branches: + - develop + paths-ignore: + - 'docs/**' + - 'config/**' + - '**.md' + - '.dockerignore' + - 'docker/**' + - '.gitignore' + +name: Build API docs + +env: + RUST_TOOLCHAIN: nightly-2023-02-26 + +jobs: + apidoc: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: dtolnay/rust-toolchain@master + with: + toolchain: ${{ env.RUST_TOOLCHAIN }} + - run: cargo doc --workspace --no-deps --document-private-items + - run: | + cat < target/doc/index.html + + + + + + + EOF + - name: Publish dist directory + uses: JamesIves/github-pages-deploy-action@v4 + with: + folder: target/doc diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml index dd02022721..3f011d33ac 100644 --- a/.github/workflows/develop.yml +++ b/.github/workflows/develop.yml @@ -24,7 +24,7 @@ on: name: CI env: - RUST_TOOLCHAIN: nightly-2023-02-14 + RUST_TOOLCHAIN: nightly-2023-02-26 jobs: typos: @@ -116,6 +116,7 @@ jobs: if: github.event.pull_request.draft == false runs-on: ubuntu-latest-8-cores timeout-minutes: 60 + needs: [clippy] steps: - uses: actions/checkout@v3 - uses: arduino/setup-protoc@v1 @@ -131,7 +132,7 @@ jobs: ETCD_VER=v3.5.7 DOWNLOAD_URL=https://github.com/etcd-io/etcd/releases/download curl -L ${DOWNLOAD_URL}/${ETCD_VER}/etcd-${ETCD_VER}-linux-amd64.tar.gz -o /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz - mkdir -p /tmp/etcd-download + mkdir -p /tmp/etcd-download tar xzvf /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz -C /tmp/etcd-download --strip-components=1 rm -f /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz @@ -188,6 +189,7 @@ jobs: if: github.event.pull_request.draft == false runs-on: ubuntu-latest-8-cores timeout-minutes: 60 + needs: [clippy] steps: - uses: actions/checkout@v3 - uses: arduino/setup-protoc@v1 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index d19ef3e027..a3c3781828 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -10,7 +10,7 @@ on: name: Release env: - RUST_TOOLCHAIN: nightly-2023-02-14 + RUST_TOOLCHAIN: nightly-2023-02-26 # FIXME(zyy17): Would be better to use `gh release list -L 1 | cut -f 3` to get the latest release version tag, but for a long time, we will stay at 'v0.1.0-alpha-*'. SCHEDULED_BUILD_VERSION_PREFIX: v0.1.0-alpha @@ -76,10 +76,10 @@ jobs: ETCD_VER=v3.5.7 DOWNLOAD_URL=https://github.com/etcd-io/etcd/releases/download curl -L ${DOWNLOAD_URL}/${ETCD_VER}/etcd-${ETCD_VER}-linux-amd64.tar.gz -o /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz - mkdir -p /tmp/etcd-download - tar xzvf /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz -C /tmp/etcd-download --strip-components=1 + mkdir -p /tmp/etcd-download + tar xzvf /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz -C /tmp/etcd-download --strip-components=1 rm -f /tmp/etcd-${ETCD_VER}-linux-amd64.tar.gz - + sudo cp -a /tmp/etcd-download/etcd* /usr/local/bin/ nohup etcd >/tmp/etcd.log 2>&1 & diff --git a/rust-toolchain.toml b/rust-toolchain.toml index a184cf98b6..14bcfe10cc 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,2 +1,2 @@ [toolchain] -channel = "nightly-2023-02-14" +channel = "nightly-2023-02-26" diff --git a/src/catalog/src/system.rs b/src/catalog/src/system.rs index 88a722ed3e..19dffa492d 100644 --- a/src/catalog/src/system.rs +++ b/src/catalog/src/system.rs @@ -219,7 +219,7 @@ fn build_primary_key_columns(entry_type: EntryType, key: &[u8]) -> HashMap HashMap let now = util::current_time_millis(); columns_values.insert( "gmt_created".to_string(), - Arc::new(TimestampMillisecondVector::from_slice(&[now])) as _, + Arc::new(TimestampMillisecondVector::from_slice([now])) as _, ); columns_values.insert( "gmt_modified".to_string(), - Arc::new(TimestampMillisecondVector::from_slice(&[now])) as _, + Arc::new(TimestampMillisecondVector::from_slice([now])) as _, ); InsertRequest { diff --git a/src/common/recordbatch/src/adapter.rs b/src/common/recordbatch/src/adapter.rs index 3a6f2e5236..179cedb2d7 100644 --- a/src/common/recordbatch/src/adapter.rs +++ b/src/common/recordbatch/src/adapter.rs @@ -242,12 +242,12 @@ mod test { )])); let batch1 = RecordBatch::new( schema.clone(), - vec![Arc::new(Int32Vector::from_slice(&[1])) as _], + vec![Arc::new(Int32Vector::from_slice([1])) as _], ) .unwrap(); let batch2 = RecordBatch::new( schema.clone(), - vec![Arc::new(Int32Vector::from_slice(&[2])) as _], + vec![Arc::new(Int32Vector::from_slice([2])) as _], ) .unwrap(); diff --git a/src/common/recordbatch/src/lib.rs b/src/common/recordbatch/src/lib.rs index 656f265b2b..477b8527bd 100644 --- a/src/common/recordbatch/src/lib.rs +++ b/src/common/recordbatch/src/lib.rs @@ -204,7 +204,7 @@ mod tests { ); assert!(result.is_err()); - let v: VectorRef = Arc::new(Int32Vector::from_slice(&[1, 2])); + let v: VectorRef = Arc::new(Int32Vector::from_slice([1, 2])); let expected = vec![RecordBatch::new(schema.clone(), vec![v.clone()]).unwrap()]; let r = RecordBatches::try_from_columns(schema, vec![v]).unwrap(); assert_eq!(r.take(), expected); @@ -216,7 +216,7 @@ mod tests { let column_b = ColumnSchema::new("b", ConcreteDataType::string_datatype(), false); let column_c = ColumnSchema::new("c", ConcreteDataType::boolean_datatype(), false); - let va: VectorRef = Arc::new(Int32Vector::from_slice(&[1, 2])); + let va: VectorRef = Arc::new(Int32Vector::from_slice([1, 2])); let vb: VectorRef = Arc::new(StringVector::from(vec!["hello", "world"])); let vc: VectorRef = Arc::new(BooleanVector::from(vec![true, false])); @@ -255,11 +255,11 @@ mod tests { let column_b = ColumnSchema::new("b", ConcreteDataType::string_datatype(), false); let schema = Arc::new(Schema::new(vec![column_a, column_b])); - let va1: VectorRef = Arc::new(Int32Vector::from_slice(&[1, 2])); + let va1: VectorRef = Arc::new(Int32Vector::from_slice([1, 2])); let vb1: VectorRef = Arc::new(StringVector::from(vec!["a", "b"])); let batch1 = RecordBatch::new(schema.clone(), vec![va1, vb1]).unwrap(); - let va2: VectorRef = Arc::new(Int32Vector::from_slice(&[3, 4, 5])); + let va2: VectorRef = Arc::new(Int32Vector::from_slice([3, 4, 5])); let vb2: VectorRef = Arc::new(StringVector::from(vec!["c", "d", "e"])); let batch2 = RecordBatch::new(schema.clone(), vec![va2, vb2]).unwrap(); diff --git a/src/common/recordbatch/src/recordbatch.rs b/src/common/recordbatch/src/recordbatch.rs index 16a51dbbc6..a795626407 100644 --- a/src/common/recordbatch/src/recordbatch.rs +++ b/src/common/recordbatch/src/recordbatch.rs @@ -189,8 +189,8 @@ mod tests { ])); let schema = Arc::new(Schema::try_from(arrow_schema).unwrap()); - let c1 = Arc::new(UInt32Vector::from_slice(&[1, 2, 3])); - let c2 = Arc::new(UInt32Vector::from_slice(&[4, 5, 6])); + let c1 = Arc::new(UInt32Vector::from_slice([1, 2, 3])); + let c2 = Arc::new(UInt32Vector::from_slice([4, 5, 6])); let columns: Vec = vec![c1, c2]; let batch = RecordBatch::new(schema.clone(), columns.clone()).unwrap(); @@ -222,7 +222,7 @@ mod tests { let schema = Arc::new(Schema::try_new(column_schemas).unwrap()); let numbers: Vec = (0..10).collect(); - let columns = vec![Arc::new(UInt32Vector::from_slice(&numbers)) as VectorRef]; + let columns = vec![Arc::new(UInt32Vector::from_slice(numbers)) as VectorRef]; let batch = RecordBatch::new(schema, columns).unwrap(); let output = serde_json::to_string(&batch).unwrap(); diff --git a/src/datatypes/src/schema/column_schema.rs b/src/datatypes/src/schema/column_schema.rs index 02a8ad0093..5c980fdee8 100644 --- a/src/datatypes/src/schema/column_schema.rs +++ b/src/datatypes/src/schema/column_schema.rs @@ -341,7 +341,7 @@ mod tests { let column_schema = ColumnSchema::new("test", ConcreteDataType::int32_datatype(), false); let vector = column_schema.create_default_vector_for_padding(4); assert_eq!(4, vector.len()); - let expect: VectorRef = Arc::new(Int32Vector::from_slice(&[0, 0, 0, 0])); + let expect: VectorRef = Arc::new(Int32Vector::from_slice([0, 0, 0, 0])); assert_eq!(expect, vector); } diff --git a/src/datatypes/src/vectors/binary.rs b/src/datatypes/src/vectors/binary.rs index 5d7dc6c5f2..231ec2f5c4 100644 --- a/src/datatypes/src/vectors/binary.rs +++ b/src/datatypes/src/vectors/binary.rs @@ -345,7 +345,7 @@ mod tests { assert!(builder.try_push_value_ref(ValueRef::Int32(123)).is_err()); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); diff --git a/src/datatypes/src/vectors/boolean.rs b/src/datatypes/src/vectors/boolean.rs index f9ad873fa3..6022f54353 100644 --- a/src/datatypes/src/vectors/boolean.rs +++ b/src/datatypes/src/vectors/boolean.rs @@ -365,7 +365,7 @@ mod tests { assert!(builder.try_push_value_ref(ValueRef::Int32(123)).is_err()); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); diff --git a/src/datatypes/src/vectors/date.rs b/src/datatypes/src/vectors/date.rs index 5118c6d8a5..5e5a490849 100644 --- a/src/datatypes/src/vectors/date.rs +++ b/src/datatypes/src/vectors/date.rs @@ -58,7 +58,7 @@ mod tests { #[test] fn test_date_scalar() { - let vector = DateVector::from_slice(&[1, 2]); + let vector = DateVector::from_slice([1, 2]); assert_eq!(2, vector.len()); assert_eq!(Some(Date::new(1)), vector.get_data(0)); assert_eq!(Some(Date::new(2)), vector.get_data(1)); @@ -66,24 +66,24 @@ mod tests { #[test] fn test_date_vector_builder() { - let input = DateVector::from_slice(&[1, 2, 3]); + let input = DateVector::from_slice([1, 2, 3]); let mut builder = DateType::default().create_mutable_vector(3); builder.push_value_ref(ValueRef::Date(Date::new(5))); assert!(builder.try_push_value_ref(ValueRef::Int32(123)).is_err()); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); - let expect: VectorRef = Arc::new(DateVector::from_slice(&[5, 2, 3])); + let expect: VectorRef = Arc::new(DateVector::from_slice([5, 2, 3])); assert_eq!(expect, vector); } #[test] fn test_date_from_arrow() { - let vector = DateVector::from_slice(&[1, 2]); + let vector = DateVector::from_slice([1, 2]); let arrow = vector.as_arrow().slice(0, vector.len()); let vector2 = DateVector::try_from_arrow_array(&arrow).unwrap(); assert_eq!(vector, vector2); @@ -91,7 +91,7 @@ mod tests { #[test] fn test_serialize_date_vector() { - let vector = DateVector::from_slice(&[-1, 0, 1]); + let vector = DateVector::from_slice([-1, 0, 1]); let serialized_json = serde_json::to_string(&vector.serialize_to_json().unwrap()).unwrap(); assert_eq!( r#"["1969-12-31","1970-01-01","1970-01-02"]"#, diff --git a/src/datatypes/src/vectors/datetime.rs b/src/datatypes/src/vectors/datetime.rs index 18bec2c5a6..f854839a01 100644 --- a/src/datatypes/src/vectors/datetime.rs +++ b/src/datatypes/src/vectors/datetime.rs @@ -81,7 +81,7 @@ mod tests { assert_eq!(Value::Null, v.get(1)); assert_eq!(Value::DateTime(DateTime::new(-1)), v.get(2)); - let input = DateTimeVector::from_wrapper_slice(&[ + let input = DateTimeVector::from_wrapper_slice([ DateTime::new(1), DateTime::new(2), DateTime::new(3), @@ -92,11 +92,11 @@ mod tests { assert!(builder.try_push_value_ref(ValueRef::Int32(123)).is_err()); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); - let expect: VectorRef = Arc::new(DateTimeVector::from_wrapper_slice(&[ + let expect: VectorRef = Arc::new(DateTimeVector::from_wrapper_slice([ DateTime::new(5), DateTime::new(2), DateTime::new(3), @@ -106,7 +106,7 @@ mod tests { #[test] fn test_datetime_from_arrow() { - let vector = DateTimeVector::from_wrapper_slice(&[DateTime::new(1), DateTime::new(2)]); + let vector = DateTimeVector::from_wrapper_slice([DateTime::new(1), DateTime::new(2)]); let arrow = vector.as_arrow().slice(0, vector.len()); let vector2 = DateTimeVector::try_from_arrow_array(&arrow).unwrap(); assert_eq!(vector, vector2); diff --git a/src/datatypes/src/vectors/eq.rs b/src/datatypes/src/vectors/eq.rs index 5c582ecf69..09619d5e09 100644 --- a/src/datatypes/src/vectors/eq.rs +++ b/src/datatypes/src/vectors/eq.rs @@ -167,30 +167,30 @@ mod tests { Some("world"), ]))); - assert_vector_ref_eq(Arc::new(Int8Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(UInt8Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(Int16Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(UInt16Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(Int32Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(UInt32Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(Int64Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(UInt64Vector::from_slice(&[1, 2, 3, 4]))); - assert_vector_ref_eq(Arc::new(Float32Vector::from_slice(&[1.0, 2.0, 3.0, 4.0]))); - assert_vector_ref_eq(Arc::new(Float64Vector::from_slice(&[1.0, 2.0, 3.0, 4.0]))); + assert_vector_ref_eq(Arc::new(Int8Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(UInt8Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(Int16Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(UInt16Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(Int32Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(UInt32Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(Int64Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(UInt64Vector::from_slice([1, 2, 3, 4]))); + assert_vector_ref_eq(Arc::new(Float32Vector::from_slice([1.0, 2.0, 3.0, 4.0]))); + assert_vector_ref_eq(Arc::new(Float64Vector::from_slice([1.0, 2.0, 3.0, 4.0]))); } #[test] fn test_vector_ne() { assert_vector_ref_ne( - Arc::new(Int32Vector::from_slice(&[1, 2, 3, 4])), - Arc::new(Int32Vector::from_slice(&[1, 2])), + Arc::new(Int32Vector::from_slice([1, 2, 3, 4])), + Arc::new(Int32Vector::from_slice([1, 2])), ); assert_vector_ref_ne( - Arc::new(Int32Vector::from_slice(&[1, 2, 3, 4])), - Arc::new(Int8Vector::from_slice(&[1, 2, 3, 4])), + Arc::new(Int32Vector::from_slice([1, 2, 3, 4])), + Arc::new(Int8Vector::from_slice([1, 2, 3, 4])), ); assert_vector_ref_ne( - Arc::new(Int32Vector::from_slice(&[1, 2, 3, 4])), + Arc::new(Int32Vector::from_slice([1, 2, 3, 4])), Arc::new(BooleanVector::from(vec![true, true])), ); assert_vector_ref_ne( diff --git a/src/datatypes/src/vectors/list.rs b/src/datatypes/src/vectors/list.rs index 7073049fc9..6b94457bea 100644 --- a/src/datatypes/src/vectors/list.rs +++ b/src/datatypes/src/vectors/list.rs @@ -624,7 +624,7 @@ pub mod tests { ); let mut iter = list_vector.values_iter(); assert_eq!( - Arc::new(Int32Vector::from_slice(&[1, 2, 3])) as VectorRef, + Arc::new(Int32Vector::from_slice([1, 2, 3])) as VectorRef, *iter.next().unwrap().unwrap().unwrap() ); assert!(iter.next().unwrap().unwrap().is_none()); @@ -674,7 +674,7 @@ pub mod tests { let input = new_list_vector(&data); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); diff --git a/src/datatypes/src/vectors/null.rs b/src/datatypes/src/vectors/null.rs index d1c4090c92..21378fe2dd 100644 --- a/src/datatypes/src/vectors/null.rs +++ b/src/datatypes/src/vectors/null.rs @@ -276,7 +276,7 @@ mod tests { let input = NullVector::new(3); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); diff --git a/src/datatypes/src/vectors/operations/cast.rs b/src/datatypes/src/vectors/operations/cast.rs index 8929b54a96..4ab154fa65 100644 --- a/src/datatypes/src/vectors/operations/cast.rs +++ b/src/datatypes/src/vectors/operations/cast.rs @@ -72,7 +72,7 @@ mod tests { u32::MAX as f64, u64::MAX as f64, ]; - let f64_vector: VectorRef = Arc::new(Float64Vector::from_slice(&f64_values)); + let f64_vector: VectorRef = Arc::new(Float64Vector::from_slice(f64_values)); let f64_expected = vec![ -9223372036854776000.0, @@ -137,7 +137,7 @@ mod tests { i16::MAX as i32, i32::MAX, ]; - let date32_vector: VectorRef = Arc::new(DateVector::from_slice(&i32_values)); + let date32_vector: VectorRef = Arc::new(DateVector::from_slice(i32_values)); let i32_expected = vec![ "-2147483648", diff --git a/src/datatypes/src/vectors/operations/filter.rs b/src/datatypes/src/vectors/operations/filter.rs index f9ad6b2c33..32ed67255e 100644 --- a/src/datatypes/src/vectors/operations/filter.rs +++ b/src/datatypes/src/vectors/operations/filter.rs @@ -68,7 +68,7 @@ mod tests { } fn check_filter_constant(expect_length: usize, input_length: usize, filter: &[bool]) { - let v = ConstantVector::new(Arc::new(Int32Vector::from_slice(&[123])), input_length); + let v = ConstantVector::new(Arc::new(Int32Vector::from_slice([123])), input_length); let filter = BooleanVector::from_slice(filter); let out = v.filter(&filter).unwrap(); diff --git a/src/datatypes/src/vectors/operations/find_unique.rs b/src/datatypes/src/vectors/operations/find_unique.rs index b76a975f84..a4bb148963 100644 --- a/src/datatypes/src/vectors/operations/find_unique.rs +++ b/src/datatypes/src/vectors/operations/find_unique.rs @@ -165,14 +165,14 @@ mod tests { #[test] fn test_find_unique_scalar_multi_times_with_prev() { - let prev = Int32Vector::from_slice(&[1]); + let prev = Int32Vector::from_slice([1]); - let v1 = Int32Vector::from_slice(&[2, 3, 4]); + let v1 = Int32Vector::from_slice([2, 3, 4]); let mut selected = BitVec::repeat(false, v1.len()); v1.find_unique(&mut selected, Some(&prev)); // Though element in v2 are the same as prev, but we should still keep them. - let v2 = Int32Vector::from_slice(&[1, 1, 1]); + let v2 = Int32Vector::from_slice([1, 1, 1]); v2.find_unique(&mut selected, Some(&prev)); check_bitmap(&[true, true, true], &selected); @@ -184,34 +184,34 @@ mod tests { #[test] fn test_find_unique_scalar_with_prev() { - let prev = Int32Vector::from_slice(&[1]); + let prev = Int32Vector::from_slice([1]); let mut selected = new_bitmap(&[true, false, true, false]); - let v = Int32Vector::from_slice(&[2, 3, 4, 5]); + let v = Int32Vector::from_slice([2, 3, 4, 5]); v.find_unique(&mut selected, Some(&prev)); // All elements are different. check_bitmap(&[true, true, true, true], &selected); let mut selected = new_bitmap(&[true, false, true, false]); - let v = Int32Vector::from_slice(&[1, 2, 3, 4]); + let v = Int32Vector::from_slice([1, 2, 3, 4]); v.find_unique(&mut selected, Some(&prev)); // Though first element is duplicate, but we keep the flag unchanged. check_bitmap(&[true, true, true, true], &selected); // Same case as above, but now `prev` is None. let mut selected = new_bitmap(&[true, false, true, false]); - let v = Int32Vector::from_slice(&[1, 2, 3, 4]); + let v = Int32Vector::from_slice([1, 2, 3, 4]); v.find_unique(&mut selected, None); check_bitmap(&[true, true, true, true], &selected); // Same case as above, but now `prev` is empty. let mut selected = new_bitmap(&[true, false, true, false]); - let v = Int32Vector::from_slice(&[1, 2, 3, 4]); - v.find_unique(&mut selected, Some(&Int32Vector::from_slice(&[]))); + let v = Int32Vector::from_slice([1, 2, 3, 4]); + v.find_unique(&mut selected, Some(&Int32Vector::from_slice([]))); check_bitmap(&[true, true, true, true], &selected); let mut selected = new_bitmap(&[false, false, false, false]); - let v = Int32Vector::from_slice(&[2, 2, 4, 5]); + let v = Int32Vector::from_slice([2, 2, 4, 5]); v.find_unique(&mut selected, Some(&prev)); // only v[1] is duplicate. check_bitmap(&[true, false, true, true], &selected); @@ -269,7 +269,7 @@ mod tests { } fn check_find_unique_constant(len: usize) { - let input = ConstantVector::new(Arc::new(Int32Vector::from_slice(&[8])), len); + let input = ConstantVector::new(Arc::new(Int32Vector::from_slice([8])), len); let mut selected = BitVec::repeat(false, len); input.find_unique(&mut selected, None); @@ -281,7 +281,7 @@ mod tests { let mut selected = BitVec::repeat(false, len); let prev = Some(ConstantVector::new( - Arc::new(Int32Vector::from_slice(&[8])), + Arc::new(Int32Vector::from_slice([8])), 1, )); input.find_unique(&mut selected, prev.as_ref().map(|v| v as _)); @@ -298,11 +298,11 @@ mod tests { #[test] fn test_find_unique_constant_with_prev() { - let prev = ConstantVector::new(Arc::new(Int32Vector::from_slice(&[1])), 1); + let prev = ConstantVector::new(Arc::new(Int32Vector::from_slice([1])), 1); // Keep flags unchanged. let mut selected = new_bitmap(&[true, false, true, false]); - let v = ConstantVector::new(Arc::new(Int32Vector::from_slice(&[1])), 4); + let v = ConstantVector::new(Arc::new(Int32Vector::from_slice([1])), 4); v.find_unique(&mut selected, Some(&prev)); check_bitmap(&[true, false, true, false], &selected); @@ -321,7 +321,7 @@ mod tests { v.find_unique( &mut selected, Some(&ConstantVector::new( - Arc::new(Int32Vector::from_slice(&[1])), + Arc::new(Int32Vector::from_slice([1])), 0, )), ); @@ -329,7 +329,7 @@ mod tests { // Different constant vector. let mut selected = new_bitmap(&[false, false, true, false]); - let v = ConstantVector::new(Arc::new(Int32Vector::from_slice(&[2])), 4); + let v = ConstantVector::new(Arc::new(Int32Vector::from_slice([2])), 4); v.find_unique(&mut selected, Some(&prev)); check_bitmap(&[true, false, true, false], &selected); } diff --git a/src/datatypes/src/vectors/primitive.rs b/src/datatypes/src/vectors/primitive.rs index f0a21605f0..219e5ae34b 100644 --- a/src/datatypes/src/vectors/primitive.rs +++ b/src/datatypes/src/vectors/primitive.rs @@ -518,14 +518,14 @@ mod tests { builder.push_value_ref(ValueRef::Int64(123)); assert!(builder.try_push_value_ref(ValueRef::Int32(123)).is_err()); - let input = Int64Vector::from_slice(&[7, 8, 9]); + let input = Int64Vector::from_slice([7, 8, 9]); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); - let expect: VectorRef = Arc::new(Int64Vector::from_slice(&[123, 8, 9])); + let expect: VectorRef = Arc::new(Int64Vector::from_slice([123, 8, 9])); assert_eq!(expect, vector); } @@ -537,7 +537,7 @@ mod tests { $ty::from_native($ty::MAX), $ty::from_native($ty::MIN), ]); - let from_slice = $vec::from_slice(&[$ty::MAX, $ty::MIN]); + let from_slice = $vec::from_slice([$ty::MAX, $ty::MIN]); assert_eq!(from_wrapper_slice, from_slice); }; } diff --git a/src/datatypes/src/vectors/string.rs b/src/datatypes/src/vectors/string.rs index dced05199d..56098eddb5 100644 --- a/src/datatypes/src/vectors/string.rs +++ b/src/datatypes/src/vectors/string.rs @@ -295,7 +295,7 @@ mod tests { let input = StringVector::from_slice(&["world", "one", "two"]); builder.extend_slice_of(&input, 1, 2).unwrap(); assert!(builder - .extend_slice_of(&crate::vectors::Int32Vector::from_slice(&[13]), 0, 1) + .extend_slice_of(&crate::vectors::Int32Vector::from_slice([13]), 0, 1) .is_err()); let vector = builder.to_vector(); diff --git a/src/query/src/datafusion.rs b/src/query/src/datafusion.rs index 53ab61c611..ab5ce5ea16 100644 --- a/src/query/src/datafusion.rs +++ b/src/query/src/datafusion.rs @@ -392,7 +392,7 @@ mod tests { assert_eq!( *batch.column(0), - Arc::new(UInt64Vector::from_slice(&[4950])) as VectorRef + Arc::new(UInt64Vector::from_slice([4950])) as VectorRef ); } _ => unreachable!(), diff --git a/src/query/src/sql.rs b/src/query/src/sql.rs index 89152580d4..fcf21f6e4a 100644 --- a/src/query/src/sql.rs +++ b/src/query/src/sql.rs @@ -277,8 +277,8 @@ mod test { .with_time_index(true), ]; let data = vec![ - Arc::new(UInt32Vector::from_slice(&[0])) as _, - Arc::new(TimestampMillisecondVector::from_slice(&[0])) as _, + Arc::new(UInt32Vector::from_slice([0])) as _, + Arc::new(TimestampMillisecondVector::from_slice([0])) as _, ]; let expected_columns = vec![ Arc::new(StringVector::from(vec!["t1", "t2"])) as _, diff --git a/src/query/src/tests/percentile_test.rs b/src/query/src/tests/percentile_test.rs index 5880314012..b0aecc3e8c 100644 --- a/src/query/src/tests/percentile_test.rs +++ b/src/query/src/tests/percentile_test.rs @@ -129,7 +129,7 @@ fn create_correctness_engine() -> Arc { let numbers = [3_i32, 6_i32, 8_i32, 10_i32]; - let column: VectorRef = Arc::new(Int32Vector::from_slice(&numbers)); + let column: VectorRef = Arc::new(Int32Vector::from_slice(numbers)); columns.push(column); let schema = Arc::new(Schema::new(column_schemas)); diff --git a/src/query/src/tests/query_engine_test.rs b/src/query/src/tests/query_engine_test.rs index 4a3197fa6e..f4285f4264 100644 --- a/src/query/src/tests/query_engine_test.rs +++ b/src/query/src/tests/query_engine_test.rs @@ -96,7 +96,7 @@ async fn test_datafusion_query_engine() -> Result<()> { let expected: Vec = (0u32..limit as u32).collect(); assert_eq!( *batch.column(0), - Arc::new(UInt32Vector::from_slice(&expected)) as VectorRef + Arc::new(UInt32Vector::from_slice(expected)) as VectorRef ); Ok(()) @@ -200,7 +200,7 @@ async fn test_udf() -> Result<()> { let expected: Vec = vec![1, 1, 4, 27, 256, 3125, 46656, 823543, 16777216, 387420489]; assert_eq!( *batch.column(0), - Arc::new(UInt32Vector::from_slice(&expected)) as VectorRef + Arc::new(UInt32Vector::from_slice(expected)) as VectorRef ); Ok(()) diff --git a/src/script/src/table.rs b/src/script/src/table.rs index d806b12e1f..ea4b2470ae 100644 --- a/src/script/src/table.rs +++ b/src/script/src/table.rs @@ -108,16 +108,16 @@ impl ScriptsTable { // Timestamp in key part is intentionally left to 0 columns_values.insert( "timestamp".to_string(), - Arc::new(TimestampMillisecondVector::from_slice(&[0])) as _, + Arc::new(TimestampMillisecondVector::from_slice([0])) as _, ); let now = util::current_time_millis(); columns_values.insert( "gmt_created".to_string(), - Arc::new(TimestampMillisecondVector::from_slice(&[now])) as _, + Arc::new(TimestampMillisecondVector::from_slice([now])) as _, ); columns_values.insert( "gmt_modified".to_string(), - Arc::new(TimestampMillisecondVector::from_slice(&[now])) as _, + Arc::new(TimestampMillisecondVector::from_slice([now])) as _, ); let table = self .catalog_manager diff --git a/src/servers/src/grpc/flight/stream.rs b/src/servers/src/grpc/flight/stream.rs index cd39a31fe4..0048da2ed8 100644 --- a/src/servers/src/grpc/flight/stream.rs +++ b/src/servers/src/grpc/flight/stream.rs @@ -140,7 +140,7 @@ mod test { false, )])); - let v: VectorRef = Arc::new(Int32Vector::from_slice(&[1, 2])); + let v: VectorRef = Arc::new(Int32Vector::from_slice([1, 2])); let recordbatch = RecordBatch::new(schema.clone(), vec![v]).unwrap(); let recordbatches = RecordBatches::try_new(schema.clone(), vec![recordbatch.clone()]) diff --git a/src/storage/benches/wal/util/mod.rs b/src/storage/benches/wal/util/mod.rs index 36c8be432c..dcf714892b 100644 --- a/src/storage/benches/wal/util/mod.rs +++ b/src/storage/benches/wal/util/mod.rs @@ -71,10 +71,10 @@ pub fn gen_new_batch_and_types(putdate_nums: usize) -> (WriteBatch, Vec) { rng.fill(&mut boolvs[..]); rng.fill(&mut tsvs[..]); rng.fill(&mut fvs[..]); - let intv = Arc::new(UInt64Vector::from_slice(&intvs)) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice(intvs)) as VectorRef; let boolv = Arc::new(BooleanVector::from(boolvs.to_vec())) as VectorRef; let tsv = Arc::new(TimestampMillisecondVector::from_values(tsvs)) as VectorRef; - let fvs = Arc::new(Float64Vector::from_slice(&fvs)) as VectorRef; + let fvs = Arc::new(Float64Vector::from_slice(fvs)) as VectorRef; let svs = Arc::new(StringVector::from_slice(&svs)) as VectorRef; let mut put_data = HashMap::with_capacity(11); put_data.insert("k1".to_string(), intv.clone()); diff --git a/src/storage/src/memtable/tests.rs b/src/storage/src/memtable/tests.rs index c46e864bac..de958bd68b 100644 --- a/src/storage/src/memtable/tests.rs +++ b/src/storage/src/memtable/tests.rs @@ -579,11 +579,11 @@ fn test_memtable_projection() { assert!(iter.next().is_none()); assert_eq!(5, batch.num_columns()); - let k0 = Arc::new(TimestampMillisecondVector::from_slice(&[1000, 1001, 1002])) as VectorRef; - let k1 = Arc::new(UInt64Vector::from_slice(&[0, 1, 2])) as VectorRef; - let v0 = Arc::new(UInt64Vector::from_slice(&[10, 11, 12])) as VectorRef; - let sequences = Arc::new(UInt64Vector::from_slice(&[9, 9, 9])) as VectorRef; - let op_types = Arc::new(UInt8Vector::from_slice(&[1, 1, 1])) as VectorRef; + let k0 = Arc::new(TimestampMillisecondVector::from_slice([1000, 1001, 1002])) as VectorRef; + let k1 = Arc::new(UInt64Vector::from_slice([0, 1, 2])) as VectorRef; + let v0 = Arc::new(UInt64Vector::from_slice([10, 11, 12])) as VectorRef; + let sequences = Arc::new(UInt64Vector::from_slice([9, 9, 9])) as VectorRef; + let op_types = Arc::new(UInt8Vector::from_slice([1, 1, 1])) as VectorRef; assert_eq!(k0, *batch.column(0)); assert_eq!(k1, *batch.column(1)); diff --git a/src/storage/src/schema.rs b/src/storage/src/schema.rs index 4d7aabc2f6..f31e3b8fb3 100644 --- a/src/storage/src/schema.rs +++ b/src/storage/src/schema.rs @@ -38,18 +38,18 @@ mod tests { } pub(crate) fn new_batch_with_num_values(num_value_columns: usize) -> Batch { - let k0 = Int64Vector::from_slice(&[1, 2, 3]); + let k0 = Int64Vector::from_slice([1, 2, 3]); let timestamp = TimestampMillisecondVector::from_vec(vec![4, 5, 6]); let mut columns: Vec = vec![Arc::new(k0), Arc::new(timestamp)]; for i in 0..num_value_columns { - let vi = Int64Vector::from_slice(&[i as i64, i as i64, i as i64]); + let vi = Int64Vector::from_slice([i as i64, i as i64, i as i64]); columns.push(Arc::new(vi)); } - let sequences = UInt64Vector::from_slice(&[100, 100, 100]); - let op_types = UInt8Vector::from_slice(&[0, 0, 0]); + let sequences = UInt64Vector::from_slice([100, 100, 100]); + let op_types = UInt8Vector::from_slice([0, 0, 0]); columns.push(Arc::new(sequences)); columns.push(Arc::new(op_types)); diff --git a/src/storage/src/sst/parquet.rs b/src/storage/src/sst/parquet.rs index 556a83ff3a..eeae739658 100644 --- a/src/storage/src/sst/parquet.rs +++ b/src/storage/src/sst/parquet.rs @@ -593,7 +593,7 @@ mod tests { // timestamp assert_eq!( - &TimestampMillisecondVector::from_slice(&[ + &TimestampMillisecondVector::from_slice([ 1000.into(), 1000.into(), 1001.into(), diff --git a/src/storage/src/write_batch.rs b/src/storage/src/write_batch.rs index 1420a51b03..1cfbebf898 100644 --- a/src/storage/src/write_batch.rs +++ b/src/storage/src/write_batch.rs @@ -367,8 +367,8 @@ mod tests { let columns = NameToVector::new(HashMap::new()).unwrap(); assert!(columns.is_empty()); - let vector1 = Arc::new(Int32Vector::from_slice(&[1, 2, 3, 4, 5])) as VectorRef; - let vector2 = Arc::new(UInt64Vector::from_slice(&[0, 2, 4, 6, 8])) as VectorRef; + let vector1 = Arc::new(Int32Vector::from_slice([1, 2, 3, 4, 5])) as VectorRef; + let vector2 = Arc::new(UInt64Vector::from_slice([0, 2, 4, 6, 8])) as VectorRef; let mut put_data = HashMap::with_capacity(3); put_data.insert("k1".to_string(), vector1.clone()); @@ -382,7 +382,7 @@ mod tests { #[test] fn test_name_to_vector_empty_vector() { - let vector1 = Arc::new(Int32Vector::from_slice(&[])) as VectorRef; + let vector1 = Arc::new(Int32Vector::from_slice([])) as VectorRef; let mut put_data = HashMap::new(); put_data.insert("k1".to_string(), vector1); @@ -393,9 +393,9 @@ mod tests { #[test] fn test_write_batch_put() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; let boolv = Arc::new(BooleanVector::from(vec![true, false, true])) as VectorRef; - let tsv = Arc::new(TimestampMillisecondVector::from_slice(&[0, 0, 0])) as VectorRef; + let tsv = Arc::new(TimestampMillisecondVector::from_slice([0, 0, 0])) as VectorRef; let mut put_data = HashMap::with_capacity(4); put_data.insert("k1".to_string(), intv.clone()); @@ -437,8 +437,8 @@ mod tests { #[test] fn test_put_data_different_len() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; - let tsv = Arc::new(TimestampMillisecondVector::from_slice(&[0, 0])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; + let tsv = Arc::new(TimestampMillisecondVector::from_slice([0, 0])) as VectorRef; let boolv = Arc::new(BooleanVector::from(vec![true, false, true])) as VectorRef; let mut put_data = HashMap::new(); @@ -455,7 +455,7 @@ mod tests { #[test] fn test_put_type_mismatch() { let boolv = Arc::new(BooleanVector::from(vec![true, false, true])) as VectorRef; - let tsv = Arc::new(Int64Vector::from_slice(&[0, 0, 0])) as VectorRef; + let tsv = Arc::new(Int64Vector::from_slice([0, 0, 0])) as VectorRef; let mut put_data = HashMap::new(); put_data.insert("k1".to_string(), boolv); @@ -469,7 +469,7 @@ mod tests { #[test] fn test_put_type_has_null() { let intv = Arc::new(UInt64Vector::from(vec![Some(1), None, Some(3)])) as VectorRef; - let tsv = Arc::new(Int64Vector::from_slice(&[0, 0, 0])) as VectorRef; + let tsv = Arc::new(Int64Vector::from_slice([0, 0, 0])) as VectorRef; let mut put_data = HashMap::new(); put_data.insert("k1".to_string(), intv); @@ -483,7 +483,7 @@ mod tests { #[test] fn test_put_missing_column() { let boolv = Arc::new(BooleanVector::from(vec![true, false, true])) as VectorRef; - let tsv = Arc::new(Int64Vector::from_slice(&[0, 0, 0])) as VectorRef; + let tsv = Arc::new(Int64Vector::from_slice([0, 0, 0])) as VectorRef; let mut put_data = HashMap::new(); put_data.insert("v1".to_string(), boolv); @@ -496,8 +496,8 @@ mod tests { #[test] fn test_put_unknown_column() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; - let tsv = Arc::new(TimestampMillisecondVector::from_slice(&[0, 0, 0])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; + let tsv = Arc::new(TimestampMillisecondVector::from_slice([0, 0, 0])) as VectorRef; let boolv = Arc::new(BooleanVector::from(vec![true, false, true])) as VectorRef; let mut put_data = HashMap::new(); @@ -528,8 +528,8 @@ mod tests { #[test] fn test_write_batch_delete() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; - let tsv = Arc::new(TimestampMillisecondVector::from_slice(&[0, 0, 0])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; + let tsv = Arc::new(TimestampMillisecondVector::from_slice([0, 0, 0])) as VectorRef; let mut keys = HashMap::with_capacity(3); keys.insert("k1".to_string(), intv.clone()); @@ -548,7 +548,7 @@ mod tests { #[test] fn test_delete_missing_column() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; let mut keys = HashMap::with_capacity(3); keys.insert("k1".to_string(), intv.clone()); @@ -561,8 +561,8 @@ mod tests { #[test] fn test_delete_columns_more_than_row_key() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; - let tsv = Arc::new(TimestampMillisecondVector::from_slice(&[0, 0, 0])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; + let tsv = Arc::new(TimestampMillisecondVector::from_slice([0, 0, 0])) as VectorRef; let mut keys = HashMap::with_capacity(3); keys.insert("k1".to_string(), intv.clone()); @@ -577,7 +577,7 @@ mod tests { #[test] fn test_delete_type_mismatch() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; let boolv = Arc::new(BooleanVector::from(vec![true, false, true])) as VectorRef; let mut keys = HashMap::with_capacity(3); @@ -592,8 +592,8 @@ mod tests { #[test] fn test_delete_non_null_value() { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; - let tsv = Arc::new(TimestampMillisecondVector::from_slice(&[0, 0, 0])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; + let tsv = Arc::new(TimestampMillisecondVector::from_slice([0, 0, 0])) as VectorRef; let mut keys = HashMap::with_capacity(2); keys.insert("k1".to_string(), intv.clone()); diff --git a/src/storage/src/write_batch/codec.rs b/src/storage/src/write_batch/codec.rs index 1db604d7f6..73c22af886 100644 --- a/src/storage/src/write_batch/codec.rs +++ b/src/storage/src/write_batch/codec.rs @@ -142,7 +142,7 @@ mod tests { fn gen_new_batch_and_types() -> (WriteBatch, Vec) { let mut batch = write_batch::new_test_batch(); for i in 0..10 { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; let boolv = Arc::new(BooleanVector::from(vec![Some(true), Some(false), None])) as VectorRef; let tsv = Arc::new(TimestampMillisecondVector::from_vec(vec![i, i, i])) as VectorRef; @@ -181,7 +181,7 @@ mod tests { fn gen_new_batch_and_types_with_none_column() -> (WriteBatch, Vec) { let mut batch = write_batch::new_test_batch(); for _ in 0..10 { - let intv = Arc::new(UInt64Vector::from_slice(&[1, 2, 3])) as VectorRef; + let intv = Arc::new(UInt64Vector::from_slice([1, 2, 3])) as VectorRef; let tsv = Arc::new(TimestampMillisecondVector::from_vec(vec![0, 0, 0])) as VectorRef; let mut put_data = HashMap::with_capacity(3); diff --git a/src/storage/src/write_batch/compat.rs b/src/storage/src/write_batch/compat.rs index b339076d25..85a582ea4e 100644 --- a/src/storage/src/write_batch/compat.rs +++ b/src/storage/src/write_batch/compat.rs @@ -145,7 +145,7 @@ mod tests { fn new_put_data() -> HashMap { let mut put_data = HashMap::new(); - let k0 = Arc::new(Int32Vector::from_slice(&[1, 2, 3])) as VectorRef; + let k0 = Arc::new(Int32Vector::from_slice([1, 2, 3])) as VectorRef; let ts = Arc::new(TimestampMillisecondVector::from_values([11, 12, 13])) as VectorRef; put_data.insert("k0".to_string(), k0); diff --git a/src/table/src/table/scan.rs b/src/table/src/table/scan.rs index fb6f312cc4..61c1fd721a 100644 --- a/src/table/src/table/scan.rs +++ b/src/table/src/table/scan.rs @@ -100,12 +100,12 @@ mod test { let batch1 = RecordBatch::new( schema.clone(), - vec![Arc::new(Int32Vector::from_slice(&[1, 2])) as _], + vec![Arc::new(Int32Vector::from_slice([1, 2])) as _], ) .unwrap(); let batch2 = RecordBatch::new( schema.clone(), - vec![Arc::new(Int32Vector::from_slice(&[3, 4, 5])) as _], + vec![Arc::new(Int32Vector::from_slice([3, 4, 5])) as _], ) .unwrap();