From d927ab1ce5693e966c9935d27b02fa880352e55d Mon Sep 17 00:00:00 2001
From: zyy17 <zyylsxm@gmail.com>
Date: Tue, 8 Aug 2023 19:22:24 +0800
Subject: [PATCH] ci: add 'upload-to-s3' option and disable it in dev build
 (#2124)

---
 .github/actions/build-greptime-binary/action.yml | 5 +++++
 .github/actions/build-linux-artifacts/action.yml | 7 +++++++
 .github/actions/upload-artifacts/action.yml      | 6 ++++++
 .github/workflows/dev-build.yml                  | 2 ++
 4 files changed, 20 insertions(+)

diff --git a/.github/actions/build-greptime-binary/action.yml b/.github/actions/build-greptime-binary/action.yml
index a817111227..a5eb4c9de9 100644
--- a/.github/actions/build-greptime-binary/action.yml
+++ b/.github/actions/build-greptime-binary/action.yml
@@ -28,6 +28,10 @@ inputs:
   aws-region:
     description: AWS region
     required: true
+  upload-to-s3:
+    description: Upload to S3
+    required: false
+    default: 'true'
 runs:
   using: composite
   steps:
@@ -49,3 +53,4 @@ runs:
         aws-access-key-id: ${{ inputs.aws-access-key-id }}
         aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
         aws-region: ${{ inputs.aws-region }}
+        upload-to-s3: ${{ inputs.upload-to-s3 }}
diff --git a/.github/actions/build-linux-artifacts/action.yml b/.github/actions/build-linux-artifacts/action.yml
index ac82ef6669..0944b8889e 100644
--- a/.github/actions/build-linux-artifacts/action.yml
+++ b/.github/actions/build-linux-artifacts/action.yml
@@ -29,6 +29,10 @@ inputs:
     description: Enable dev mode, only build standard greptime
     required: false
     default: 'false'
+  upload-to-s3:
+    description: Upload to S3
+    required: false
+    default: 'true'
 runs:
   using: composite
   steps:
@@ -59,6 +63,7 @@ runs:
         aws-access-key-id: ${{ inputs.aws-access-key-id }}
         aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
         aws-region: ${{ inputs.aws-region }}
+        upload-to-s3: ${{ inputs.upload-to-s3 }}
 
     - name: Build greptime without pyo3
       if: ${{ inputs.dev-mode == 'false' }}
@@ -73,6 +78,7 @@ runs:
         aws-access-key-id: ${{ inputs.aws-access-key-id }}
         aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
         aws-region: ${{ inputs.aws-region }}
+        upload-to-s3: ${{ inputs.upload-to-s3 }}
 
     - name: Build greptime on centos base image
       uses: ./.github/actions/build-greptime-binary
@@ -87,3 +93,4 @@ runs:
         aws-access-key-id: ${{ inputs.aws-access-key-id }}
         aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
         aws-region: ${{ inputs.aws-region }}
+        upload-to-s3: ${{ inputs.upload-to-s3 }}
diff --git a/.github/actions/upload-artifacts/action.yml b/.github/actions/upload-artifacts/action.yml
index 2a81a9e778..2ef402f8d0 100644
--- a/.github/actions/upload-artifacts/action.yml
+++ b/.github/actions/upload-artifacts/action.yml
@@ -22,6 +22,10 @@ inputs:
   aws-region:
     description: AWS region
     required: true
+  upload-to-s3:
+    description: Upload to S3
+    required: false
+    default: 'true'
 runs:
   using: composite
   steps:
@@ -57,6 +61,7 @@ runs:
         path: ${{ inputs.artifacts-dir }}.sha256sum
 
     - name: Configure AWS credentials
+      if: ${{ inputs.upload-to-s3 == 'true' }}
       uses: aws-actions/configure-aws-credentials@v2
       with:
         aws-access-key-id: ${{ inputs.aws-access-key-id }}
@@ -64,6 +69,7 @@ runs:
         aws-region: ${{ inputs.aws-region }}
 
     - name: Upload artifacts to S3
+      if: ${{ inputs.upload-to-s3 == 'true' }}
       shell: bash
       # The bucket layout will be:
       # releases/greptimedb
diff --git a/.github/workflows/dev-build.yml b/.github/workflows/dev-build.yml
index 9193ad830d..4dca408909 100644
--- a/.github/workflows/dev-build.yml
+++ b/.github/workflows/dev-build.yml
@@ -170,6 +170,7 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_CN_SECRET_ACCESS_KEY }}
           aws-region: ${{ vars.AWS_RELEASE_BUCKET_REGION }}
           dev-mode: true # Only build the standard greptime binary.
+          upload-to-s3: false # No need to upload to S3.
 
   build-linux-arm64-artifacts:
     name: Build linux-arm64 artifacts
@@ -206,6 +207,7 @@ jobs:
           aws-secret-access-key: ${{ secrets.AWS_CN_SECRET_ACCESS_KEY }}
           aws-region: ${{ vars.AWS_RELEASE_BUCKET_REGION }}
           dev-mode: true # Only build the standard greptime binary.
+          upload-to-s3: false # No need to upload to S3.
 
   release-images-to-dockerhub:
     name: Build and push images to DockerHub