From dc66363f89d687933d5694d5a106d32c9808360e Mon Sep 17 00:00:00 2001 From: WenyXu Date: Wed, 15 Apr 2026 12:51:00 +0000 Subject: [PATCH] chore: apply suggestions Signed-off-by: WenyXu --- src/common/meta/src/region_keeper.rs | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/common/meta/src/region_keeper.rs b/src/common/meta/src/region_keeper.rs index 55116b15e9..77db68450c 100644 --- a/src/common/meta/src/region_keeper.rs +++ b/src/common/meta/src/region_keeper.rs @@ -12,6 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. +use std::collections::hash_map::Entry; use std::collections::{HashMap, HashSet}; use std::sync::{Arc, RwLock}; @@ -68,14 +69,16 @@ impl MemoryRegionKeeper { ) -> Option { let mut inner = self.inner.write().unwrap(); - if inner.insert((datanode_id, region_id), role).is_none() { - Some(OperatingRegionGuard { - datanode_id, - region_id, - inner: self.inner.clone(), - }) - } else { - None + match inner.entry((datanode_id, region_id)) { + Entry::Occupied(_) => None, + Entry::Vacant(vacant_entry) => { + vacant_entry.insert(role); + Some(OperatingRegionGuard { + datanode_id, + region_id, + inner: self.inner.clone(), + }) + } } }