From dcdbef534cfd7ccf0dd0529a58a29cabd40219ec Mon Sep 17 00:00:00 2001 From: Dennis Zhuang Date: Thu, 11 Aug 2022 15:49:12 +0800 Subject: [PATCH] fix: resolve CR problems --- src/datanode/src/error.rs | 2 +- src/storage/src/engine.rs | 1 - src/table-engine/src/manifest.rs | 3 ++- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/datanode/src/error.rs b/src/datanode/src/error.rs index 85aab1c57a..12f7d30fbe 100644 --- a/src/datanode/src/error.rs +++ b/src/datanode/src/error.rs @@ -109,7 +109,7 @@ pub enum Error { #[snafu(display("Failed to storage engine, source: {}", source))] OpenStorageEngine { source: StorageError }, - #[snafu(display("Failed to init backend, source: {}", source))] + #[snafu(display("Failed to init backend, dir: {}, source: {}", dir, source))] InitBackend { dir: String, source: std::io::Error, diff --git a/src/storage/src/engine.rs b/src/storage/src/engine.rs index 50f593a438..2fae3b67d6 100644 --- a/src/storage/src/engine.rs +++ b/src/storage/src/engine.rs @@ -241,7 +241,6 @@ impl EngineInner { let mut guard = SlotGuard::new(name, &self.regions); - // FIXME(yingwen): Get region id or remove dependency of region id. let store_config = self.region_store_config(&opts.parent_dir, name); let region = match RegionImpl::open(name.to_string(), store_config, opts).await? { diff --git a/src/table-engine/src/manifest.rs b/src/table-engine/src/manifest.rs index 47a4581604..f8ca01d1c0 100644 --- a/src/table-engine/src/manifest.rs +++ b/src/table-engine/src/manifest.rs @@ -3,7 +3,7 @@ pub mod action; use storage::manifest::ManifestImpl; -use crate::manifest::action::*; +use crate::manifest::action::TableMetaActionList; pub type TableManifest = ManifestImpl; @@ -15,6 +15,7 @@ mod tests { use table::metadata::TableInfo; use super::*; + use crate::manifest::action::{TableChange, TableMetaAction, TableRemove}; use crate::table::test_util; type TableManifestActionIter = MetaActionIteratorImpl;