From dd845cfbc96ee74644124347e39088d853451fa1 Mon Sep 17 00:00:00 2001 From: discord9 Date: Mon, 7 Sep 2026 11:05:46 +0800 Subject: [PATCH] docs(meta): describe flow extension interfaces neutrally Signed-off-by: discord9 --- src/common/meta/src/ddl/create_flow.rs | 2 +- src/common/meta/src/ddl_manager.rs | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/common/meta/src/ddl/create_flow.rs b/src/common/meta/src/ddl/create_flow.rs index da553b5c07..e36c89fbb3 100644 --- a/src/common/meta/src/ddl/create_flow.rs +++ b/src/common/meta/src/ddl/create_flow.rs @@ -785,7 +785,7 @@ pub enum FlowType { pub const FLOW_EXPERIMENTAL_ENABLE_INCREMENTAL_READ_KEY: &str = "experimental_enable_incremental_read"; -/// Reserved internal value for Enterprise flows requiring exact sequence ranges. +/// Reserved internal value for flows requiring exact sequence ranges. pub const FLOW_EXPERIMENTAL_ENABLE_INCREMENTAL_READ_SEQUENCE_RANGE: &str = "__greptime_internal_exact_sequence_range"; diff --git a/src/common/meta/src/ddl_manager.rs b/src/common/meta/src/ddl_manager.rs index 9c208f458b..9d4f4c01a4 100644 --- a/src/common/meta/src/ddl_manager.rs +++ b/src/common/meta/src/ddl_manager.rs @@ -148,7 +148,7 @@ pub trait TriggerDdlManager: Send + Sync { #[cfg(feature = "enterprise")] pub type TriggerDdlManagerRef = Arc; -/// This trait is responsible for handling enterprise CREATE FLOW tasks. +/// This trait is responsible for handling custom/extension CREATE FLOW tasks. #[cfg(feature = "enterprise")] #[async_trait::async_trait] pub trait CreateFlowHandler: Send + Sync { @@ -1959,7 +1959,7 @@ mod tests { #[cfg(feature = "enterprise")] #[tokio::test] - async fn test_reserved_sequence_range_is_rejected_before_enterprise_handler() { + async fn test_reserved_sequence_range_is_rejected_before_custom_handler() { let handler = Arc::new(RecordingCreateFlowHandler::default()); let ddl_manager = build_soft_drop_test_ddl_manager().with_create_flow_handler(handler.clone()); @@ -1987,7 +1987,7 @@ mod tests { #[tokio::test] async fn test_create_flow_handler_dispatches_without_procedure() { let response = SubmitDdlTaskResponse { - key: b"enterprise".to_vec(), + key: b"custom-handler".to_vec(), ..Default::default() }; let handler = Arc::new(RecordingCreateFlowHandler { @@ -2018,7 +2018,7 @@ mod tests { ) .await .unwrap(); - assert_eq!(actual.key, b"enterprise"); + assert_eq!(actual.key, b"custom-handler"); assert_eq!(handler.tasks.lock().unwrap().len(), 1); assert_eq!( handler.contexts.lock().unwrap().as_slice(),