From de3f817596576019b79e7502edbcfdf17bb65afd Mon Sep 17 00:00:00 2001 From: yihong Date: Tue, 11 Feb 2025 14:23:49 +0800 Subject: [PATCH] fix: drop useless clone and for loop second (#5507) Signed-off-by: yihong0618 --- src/promql/src/extension_plan/union_distinct_on.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/promql/src/extension_plan/union_distinct_on.rs b/src/promql/src/extension_plan/union_distinct_on.rs index 83af93edc9..e68c2ce37f 100644 --- a/src/promql/src/extension_plan/union_distinct_on.rs +++ b/src/promql/src/extension_plan/union_distinct_on.rs @@ -498,13 +498,13 @@ fn interleave_batches( } // interleave arrays - let mut interleaved_arrays = Vec::with_capacity(arrays.len()); - for array in arrays { - interleaved_arrays.push(compute::interleave(&array, &indices)?); - } + let interleaved_arrays: Vec<_> = arrays + .into_iter() + .map(|array| compute::interleave(&array, &indices)) + .collect::>()?; // assemble new record batch - RecordBatch::try_new(schema.clone(), interleaved_arrays) + RecordBatch::try_new(schema, interleaved_arrays) .map_err(|e| DataFusionError::ArrowError(e, None)) }