From f1574d940da1906c85514c2c99f379214a51d3c2 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 10 Jun 2026 10:17:35 +0000 Subject: [PATCH] Fail flow recovery on partial recreate errors --- src/flow/src/adapter/flownode_impl.rs | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/flow/src/adapter/flownode_impl.rs b/src/flow/src/adapter/flownode_impl.rs index 7d451d90380..44cf462fa6b 100644 --- a/src/flow/src/adapter/flownode_impl.rs +++ b/src/flow/src/adapter/flownode_impl.rs @@ -412,10 +412,17 @@ impl FlowDualEngine { } if errors.is_empty() { info!("Recover flows successfully, flows: {:?}", to_be_created); - } - - for (flow_id, err) in errors { - warn!("Failed to recreate flow {}, err={:#?}", flow_id, err); + } else { + let failed_flow_ids = errors.iter().map(|(flow_id, _)| *flow_id).join(", "); + for (flow_id, err) in errors { + warn!("Failed to recreate flow {}, err={:#?}", flow_id, err); + } + return InternalSnafu { + reason: format!( + "Failed to recreate flows during consistency check: [{failed_flow_ids}]" + ), + } + .fail(); } } else { warn!(