From f88e3ee45c05d3bc8922477dfa79bc9567ce3782 Mon Sep 17 00:00:00 2001 From: luofucong Date: Wed, 13 May 2026 09:51:37 +0800 Subject: [PATCH] resolve PR comments Signed-off-by: luofucong --- src/mito2/src/compaction.rs | 5 ++--- src/mito2/src/error.rs | 7 ++----- src/mito2/src/read/scan_region.rs | 2 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/mito2/src/compaction.rs b/src/mito2/src/compaction.rs index 12803e9acc..bc9368f8b1 100644 --- a/src/mito2/src/compaction.rs +++ b/src/mito2/src/compaction.rs @@ -1094,6 +1094,7 @@ impl CompactionSstReaderBuilder<'_> { let parquet_metadata = self .sst_layer .read_sst(file_handle.clone()) + .cache(CacheStrategy::Compaction(self.cache)) .read_parquet_metadata( &file_path, file_size, @@ -1108,9 +1109,7 @@ impl CompactionSstReaderBuilder<'_> { file_metadata.schema_descr(), file_metadata.key_value_metadata(), ) - .with_context(|_| ParquetToArrowSchemaSnafu { - parquet_metadata: format!("{:?}", parquet_metadata), - })?; + .context(ParquetToArrowSchemaSnafu { file: file_path })?; schemas.push(schema); } diff --git a/src/mito2/src/error.rs b/src/mito2/src/error.rs index dcabdcac95..085ebe96fe 100644 --- a/src/mito2/src/error.rs +++ b/src/mito2/src/error.rs @@ -1249,12 +1249,9 @@ pub enum Error { location: Location, }, - #[snafu(display( - "Failed generate Arrow schema from Parquet metadata: {}", - parquet_metadata - ))] + #[snafu(display("Failed to generate Arrow schema from Parquet file: {}", file))] ParquetToArrowSchema { - parquet_metadata: String, + file: String, #[snafu(source)] error: parquet::errors::ParquetError, #[snafu(implicit)] diff --git a/src/mito2/src/read/scan_region.rs b/src/mito2/src/read/scan_region.rs index 455215d01b..c1eb048bce 100644 --- a/src/mito2/src/read/scan_region.rs +++ b/src/mito2/src/read/scan_region.rs @@ -753,7 +753,7 @@ pub(crate) fn concretize_json_types( }; debug!( - "column {} set concretize JSON type {}", + "column {} concretized JSON type set to {}", column_schema.name, json_type, ); column_schema.data_type = ConcreteDataType::from(json_type);