mirror of
https://github.com/GreptimeTeam/greptimedb.git
synced 2026-08-22 05:58:33 +00:00
09c0b23a23
* fix(meta): actually acquire logical table locks in alter-logical-tables procedure The procedure listed its logical table locks from table_info_values, which is only filled during Prepare, while procedure lock keys are fixed at submission — so the logical locks were never acquired. Today every writer of a logical table's info is serialized by the physical table lock, which hides the problem; a metadata-only alter procedure targeting a single logical table would race it. Resolve the logical table ids at submission, persist them in the procedure state (serde(default): state dumped by older versions keeps the previous behavior), lock physical + logical tables, and re-check the resolved ids against the locked set at Prepare so a table dropped and recreated after submission cannot be mutated without a lock. Signed-off-by: Dennis Zhuang <killme2008@gmail.com> * feat: manage semantic table options via ALTER TABLE SET/UNSET CREATE TABLE accepts greptime.semantic.* options, but ALTER TABLE SET routed every option through SetRegionOption, whose closed match rejects them — tables auto-created by ingestion could never receive semantic declarations after the fact. Semantic options are pure metadata markers no region consumes, so they now take a metadata-only alter, following the repartition-hint precedent: - New AlterKind::SetAnnotations/UnsetAnnotations carrying an AnnotationFamily (currently only Semantic), so future marker-style option families reuse the same machinery. The converter classifies a SET/UNSET batch by key prefix and rejects batches that mix annotation keys with regular options. - The procedure reuses the MetadataOnly flow: no region dispatch, table-info update plus cache invalidation only. - Validation lives in the table-meta mutation layer, so it runs at frontend verification and again in the procedure's prepare step under the table lock: SET is strict (known key, value domain, entity columns exist and render as strings); UNSET is lenient inside the namespace so stale keys can be cleaned up. ModifyColumnTypes re-checks columns referenced by entity declarations at the same layer, closing a verify-then-execute race. - Logical metric tables are supported: an annotation alter submits a regular alter-table task locking only the logical table, and the DDL manager's physical-route guard admits it. - create_table_info re-checks semantic value domains for gRPC-built expressions that bypass the SQL parser. Signed-off-by: Dennis Zhuang <killme2008@gmail.com> * refactor(table): centralize annotation option classification and validation Address review feedback on the AnnotationFamily abstraction: with only one variant that every consumer immediately destructured, the generality was fake. Make it real and exhaustive instead: - AnnotationFamily gains RepartitionHint: repartition.column.hint is the same kind of marker option (pure metadata, no region consumes it) and previously had a hand-rolled special case in the converter, the metadata-only classifier, and a dedicated AlterKind pair — all deleted, one classification API remains. Per-family logical-table eligibility (allows_logical_tables) replaces the hard-coded Semantic check in the DDL manager guard. - One validation core in the table crate (check_annotation) serves both DDL entry points. CREATE and ALTER previously duplicated the rules; each keeps its existing error variants, status codes and messages via thin adapters over a typed error (ALTER missing column stays 4002 TableColumnNotFound, CREATE stays InvalidArguments). - The batch classifier returns Result instead of swallowing the mixed-batch error: a mixed SET on a logical table now reports the actual problem instead of UnexpectedLogicalRouteTable, and the flow classifiers propagate instead of guessing. The converter also moves its owned payloads instead of cloning them. Signed-off-by: Dennis Zhuang <killme2008@gmail.com> * test(meta): cover logical-table annotation alter routing The route-guard branch admitting metadata-only annotation alters on logical tables was only exercised end to end by sqlness. Pin it at the DDL manager level: a semantic SET on a logical table succeeds, updates only the logical table's metadata and dispatches nothing to datanodes; a mixed batch reports its own error instead of the route guard's; the repartition hint stays rejected on logical routes. Signed-off-by: Dennis Zhuang <killme2008@gmail.com> * fix(table): keep entity guard on ADD COLUMN and report missing columns first Review follow-ups: the old verify_alter loop scanned the post-alter schema, so it also caught DROP COLUMN followed by re-adding the declared column with a non-string type — the mutation-layer move only kept the MODIFY path. Guard add_columns the same way (this also covers ingestion auto-alter). And run the MODIFY drift check after the existence lookup, so altering a dropped-but-still-declared column reports ColumnNotExists (4002) like every other MODIFY on a missing column. Signed-off-by: Dennis Zhuang <killme2008@gmail.com> * style(grpc-expr): drop a test comment restating the classifier doc Signed-off-by: Dennis Zhuang <killme2008@gmail.com> * refactor(table): rename annotation validation helpers per review check_annotation* validated and normalized; align the names with the validate_and_normalize_* convention nearby, and spell out AnnotationContext (Cx is not used in this repo). Signed-off-by: Dennis Zhuang <killme2008@gmail.com> --------- Signed-off-by: Dennis Zhuang <killme2008@gmail.com>
390 lines
15 KiB
SQL
390 lines
15 KiB
SQL
-- The computed entity-graph tables under greptime_private are read-only
|
|
-- virtual tables: readable, but rejecting every DDL/DML path.
|
|
select observed_at, entity_type, entity_id, scope from greptime_private.semantic_entities;
|
|
|
|
select observed_at, src_id, dst_id, rel_type from greptime_private.semantic_relationships;
|
|
|
|
insert into greptime_private.semantic_entities (observed_at, entity_type, entity_id) values (now(), 'service', 'svc-a');
|
|
|
|
-- Plain-literal VALUES takes the direct region-insert path, not the query
|
|
-- engine; the table-level guard must hold there too.
|
|
insert into greptime_private.semantic_entities (observed_at, entity_type, entity_id) values (0, 'service', 'svc-b');
|
|
|
|
create table greptime_private.semantic_entities (ts timestamp time index);
|
|
|
|
create table greptime_private.semantic_relationships (ts timestamp time index);
|
|
|
|
alter table greptime_private.semantic_entities add column extra string;
|
|
|
|
truncate table greptime_private.semantic_entities;
|
|
|
|
drop table greptime_private.semantic_entities;
|
|
|
|
drop table greptime_private.semantic_relationships;
|
|
|
|
-- Renaming a physical table INTO a reserved name would let the overlay shadow
|
|
-- it (or squat the declared table's canonical schema), orphaning its data.
|
|
create table greptime_private.graph_rename_probe (ts timestamp time index);
|
|
|
|
alter table greptime_private.graph_rename_probe rename semantic_entities;
|
|
|
|
alter table greptime_private.graph_rename_probe rename semantic_relationships_declared;
|
|
|
|
drop table greptime_private.graph_rename_probe;
|
|
|
|
-- Read-time derivation from one declaring metric table: entity identities in
|
|
-- the computed registry (single-column and composite ids, scope and
|
|
-- descriptive columns, JSON output columns), and the same rows witnessing the
|
|
-- co-declared vocabulary edges (runs_on / part_of, direction built in).
|
|
create table graph_app_metrics (
|
|
ts timestamp time index,
|
|
service_name string,
|
|
instance string,
|
|
host string,
|
|
env string,
|
|
latency double,
|
|
primary key (service_name, instance, host, env)
|
|
) with (
|
|
'greptime.semantic.entity.service.id' = 'service_name',
|
|
'greptime.semantic.entity.service.scope' = 'env',
|
|
'greptime.semantic.entity.service.instance.id' = 'instance',
|
|
'greptime.semantic.entity.host.id' = 'host',
|
|
'greptime.semantic.entity.process.id' = 'service_name,host',
|
|
'greptime.semantic.entity.process.descriptive' = 'env'
|
|
);
|
|
|
|
insert into graph_app_metrics values (now(), 'cart', 'cart-0', 'h1', 'us-east', 3.5);
|
|
|
|
-- SQLNESS PROTOCOL MYSQL
|
|
select entity_type, entity_id, entity_id_attrs, scope, descriptive, source_tables
|
|
from greptime_private.semantic_entities
|
|
order by entity_type, entity_id;
|
|
|
|
select src_type, src_id, dst_type, dst_id, rel_type, provenance, confidence
|
|
from greptime_private.semantic_relationships
|
|
order by rel_type, src_id;
|
|
|
|
drop table graph_app_metrics;
|
|
|
|
-- Declarations can be added after the fact: a table created without semantic
|
|
-- options joins the graph once ALTER TABLE declares its entities, and leaves
|
|
-- it again on UNSET.
|
|
create table graph_late_metrics (
|
|
ts timestamp time index,
|
|
svc string,
|
|
env string,
|
|
latency double
|
|
);
|
|
|
|
insert into graph_late_metrics values (now(), 'checkout', 'eu-1', 1.5);
|
|
|
|
select entity_type, entity_id from greptime_private.semantic_entities order by entity_type, entity_id;
|
|
|
|
alter table graph_late_metrics set 'greptime.semantic.entity.service.id' = 'svc', 'greptime.semantic.entity.service.scope' = 'env';
|
|
|
|
select entity_type, entity_id, scope from greptime_private.semantic_entities order by entity_type, entity_id;
|
|
|
|
-- A column referenced by a declaration must keep a string-renderable type.
|
|
alter table graph_late_metrics modify column svc binary;
|
|
|
|
alter table graph_late_metrics unset 'greptime.semantic.entity.service.id';
|
|
|
|
alter table graph_late_metrics unset 'greptime.semantic.entity.service.scope';
|
|
|
|
select entity_type, entity_id from greptime_private.semantic_entities order by entity_type, entity_id;
|
|
|
|
drop table graph_late_metrics;
|
|
|
|
-- Calls derivation over trace-v1 tables, all branches in one scan: the client
|
|
-- span and its child server span land in different tables and still pair into
|
|
-- one edge with RED metrics; the epoch-timestamped pair falls outside the
|
|
-- default one-hour window; unmatched clients become virtual-node edges named
|
|
-- from span attributes (confidence < 1.0, connection type); a trace-model
|
|
-- table that lost the fixed span columns is skipped instead of failing the
|
|
-- scan. Trace tables need no entity declaration: service entities are
|
|
-- implicit.
|
|
create table graph_traces_a (
|
|
"timestamp" timestamp(9) time index,
|
|
trace_id string,
|
|
span_id string,
|
|
parent_span_id string,
|
|
span_kind string,
|
|
span_status_code string,
|
|
service_name string,
|
|
duration_nano bigint unsigned,
|
|
"span_attributes.peer.service" string,
|
|
"span_attributes.db.name" string,
|
|
primary key (service_name)
|
|
) with ('table_data_model' = 'greptime_trace_v1', 'append_mode' = 'true');
|
|
|
|
create table graph_traces_b (
|
|
"timestamp" timestamp(9) time index,
|
|
trace_id string,
|
|
span_id string,
|
|
parent_span_id string,
|
|
span_kind string,
|
|
span_status_code string,
|
|
service_name string,
|
|
duration_nano bigint unsigned,
|
|
primary key (service_name)
|
|
) with ('table_data_model' = 'greptime_trace_v1', 'append_mode' = 'true');
|
|
|
|
create table graph_traces_malformed (
|
|
ts timestamp time index,
|
|
note string
|
|
) with ('table_data_model' = 'greptime_trace_v1');
|
|
|
|
insert into graph_traces_a values
|
|
(now(), 't1', 'c1', NULL, 'SPAN_KIND_CLIENT', 'STATUS_CODE_UNSET', 'frontend', 0, NULL, NULL),
|
|
(now(), 't2', 'c2', NULL, 'SPAN_KIND_CLIENT', 'STATUS_CODE_UNSET', 'frontend', 0, NULL, NULL),
|
|
(0, 't0', 'c0', NULL, 'SPAN_KIND_CLIENT', 'STATUS_CODE_UNSET', 'stale-src', 0, NULL, NULL),
|
|
(0, 't0', 's0', 'c0', 'SPAN_KIND_SERVER', 'STATUS_CODE_UNSET', 'stale-dst', 100, NULL, NULL),
|
|
(now(), 't3', 'c3', NULL, 'SPAN_KIND_CLIENT', 'STATUS_CODE_UNSET', 'frontend', 250000000, 'redis', NULL),
|
|
(now(), 't4', 'c4', NULL, 'SPAN_KIND_CLIENT', 'STATUS_CODE_UNSET', 'frontend', 100000000, NULL, 'orders-db');
|
|
|
|
insert into graph_traces_b values
|
|
(now(), 't1', 's1', 'c1', 'SPAN_KIND_SERVER', 'STATUS_CODE_ERROR', 'cart', 1500000000),
|
|
(now(), 't2', 's2', 'c2', 'SPAN_KIND_SERVER', 'STATUS_CODE_UNSET', 'cart', 500000000);
|
|
|
|
insert into graph_traces_malformed values (now(), 'not a trace');
|
|
|
|
-- SQLNESS PROTOCOL MYSQL
|
|
select src_id, dst_id, rel_type, provenance, confidence,
|
|
request_count, error_count, duration_sum, duration_count, attributes
|
|
from greptime_private.semantic_relationships
|
|
order by dst_id;
|
|
|
|
-- SQLNESS PROTOCOL MYSQL
|
|
select entity_type, entity_id, entity_id_attrs, scope, source_tables
|
|
from greptime_private.semantic_entities
|
|
order by entity_id;
|
|
|
|
drop table graph_traces_a;
|
|
|
|
drop table graph_traces_b;
|
|
|
|
drop table graph_traces_malformed;
|
|
|
|
-- Declared edges: the physical table is created by the system on the first
|
|
-- INSERT with its canonical schema. Re-asserting an edge stores a new revision;
|
|
-- reads keep only the latest one per edge key.
|
|
insert into greptime_private.semantic_relationships_declared
|
|
(observed_at, src_type, src_id, rel_type, dst_type, dst_id, provenance, scope, generation_id, confidence)
|
|
values (now() - interval '10 minute', 'service', 'frontend', 'depends_on', 'service', 'users-db', 'declared', '', '', 0.5);
|
|
|
|
insert into greptime_private.semantic_relationships_declared
|
|
(observed_at, src_type, src_id, rel_type, dst_type, dst_id, provenance, scope, generation_id, confidence)
|
|
values (now() - interval '5 minute', 'service', 'frontend', 'depends_on', 'service', 'users-db', 'declared', '', '', 1.0);
|
|
|
|
-- An old open-ended declaration stays valid until its row expires; an edge
|
|
-- retired in the past must not appear.
|
|
insert into greptime_private.semantic_relationships_declared
|
|
(observed_at, src_type, src_id, rel_type, dst_type, dst_id, provenance, scope, generation_id, valid_until)
|
|
values
|
|
('1970-01-01 00:00:01', 'service', 'legacy', 'depends_on', 'service', 'mainframe', 'declared', '', '', NULL),
|
|
('1970-01-01 00:00:01', 'service', 'retired', 'depends_on', 'service', 'oldsys', 'declared', '', '', '2000-01-01 00:00:00');
|
|
|
|
select src_id, dst_id, rel_type, provenance, confidence
|
|
from greptime_private.semantic_relationships
|
|
order by src_id;
|
|
|
|
-- An explicit observed_at window replaces the default last hour; the emitted
|
|
-- timestamps of declared edges are synthesized inside the queried window.
|
|
select observed_at, window_start, fresh_until, src_id, dst_id
|
|
from greptime_private.semantic_relationships
|
|
where observed_at >= '2001-01-01 00:00:00' and observed_at < '2001-01-02 00:00:00'
|
|
order by src_id;
|
|
|
|
-- A lower bound alone is fine (the upper bound defaults to now)...
|
|
select src_id, dst_id, provenance
|
|
from greptime_private.semantic_relationships
|
|
where observed_at >= now() - interval '30 minute'
|
|
order by src_id;
|
|
|
|
-- ...but an upper bound alone would scan unbounded history: explicit error.
|
|
select src_id from greptime_private.semantic_relationships
|
|
where observed_at < '2001-01-02 00:00:00';
|
|
|
|
-- The declared-edge table's definition is system-owned: user CREATE/ALTER are
|
|
-- rejected, while plain DML stays allowed.
|
|
create table greptime_private.semantic_relationships_declared (ts timestamp time index);
|
|
|
|
alter table greptime_private.semantic_relationships_declared add column extra string;
|
|
|
|
delete from greptime_private.semantic_relationships_declared;
|
|
|
|
select src_id from greptime_private.semantic_relationships order by src_id;
|
|
|
|
-- DROP is allowed (nothing structural is lost: the next INSERT recreates the
|
|
-- canonical table) and cleans up after this test.
|
|
drop table greptime_private.semantic_relationships_declared;
|
|
|
|
insert into greptime_private.semantic_relationships_declared
|
|
(observed_at, src_type, src_id, rel_type, dst_type, dst_id, provenance, scope, generation_id)
|
|
values (now(), 'service', 'reborn', 'depends_on', 'service', 'db', 'declared', '', '');
|
|
|
|
select src_id from greptime_private.semantic_relationships order by src_id;
|
|
|
|
drop table greptime_private.semantic_relationships_declared;
|
|
|
|
-- Agent edges: span structure derives parent_agent calls agent, and span rows
|
|
-- co-declaring gen_ai.agent+gen_ai.model / gen_ai.agent+gen_ai.tool witness
|
|
-- uses / invokes. The identity columns are fields, not tags.
|
|
create table graph_agent_traces (
|
|
"timestamp" timestamp(9) time index,
|
|
trace_id string,
|
|
span_id string,
|
|
parent_span_id string,
|
|
span_kind string,
|
|
span_status_code string,
|
|
service_name string,
|
|
duration_nano bigint unsigned,
|
|
agent_id string,
|
|
model_name string,
|
|
tool_name string,
|
|
primary key (service_name)
|
|
) with (
|
|
'table_data_model' = 'greptime_trace_v1',
|
|
'append_mode' = 'true',
|
|
'greptime.semantic.entity.gen_ai.agent.id' = 'agent_id',
|
|
'greptime.semantic.entity.gen_ai.model.id' = 'model_name',
|
|
'greptime.semantic.entity.gen_ai.tool.id' = 'tool_name'
|
|
);
|
|
|
|
insert into graph_agent_traces values
|
|
(now(), 't1', 'p1', NULL, 'SPAN_KIND_INTERNAL', 'STATUS_CODE_UNSET', 'app', 0, 'orchestrator', NULL, NULL),
|
|
(now(), 't1', 'a1', 'p1', 'SPAN_KIND_INTERNAL', 'STATUS_CODE_UNSET', 'app', 2000000000, 'researcher', 'gpt-5', NULL),
|
|
(now(), 't1', 'a2', 'a1', 'SPAN_KIND_INTERNAL', 'STATUS_CODE_UNSET', 'app', 500000000, 'researcher', NULL, 'web_search');
|
|
|
|
select src_type, src_id, dst_type, dst_id, rel_type, provenance
|
|
from greptime_private.semantic_relationships
|
|
order by rel_type, dst_id;
|
|
|
|
drop table graph_agent_traces;
|
|
|
|
-- Prometheus conventions: whitelisted entity-descriptor metrics (stamped
|
|
-- signal_type=metric + source=prometheus by the remote-write path) get
|
|
-- implicit declarations, and the co-declared rules derive runs_on / part_of /
|
|
-- contains from their rows. Pod identity is the UID, so every KSM descriptor
|
|
-- lands on one entity; the empty labels kube-state-metrics emits (unscheduled
|
|
-- pod's node, ownerless pod's owner_*) identify nothing. A non-whitelisted
|
|
-- metric contributes nothing.
|
|
create table kube_pod_info (
|
|
greptime_timestamp timestamp(3) time index,
|
|
uid string,
|
|
namespace string,
|
|
pod string,
|
|
node string,
|
|
greptime_value double,
|
|
primary key (uid, namespace, pod, node)
|
|
) with (
|
|
'greptime.semantic.signal_type' = 'metric',
|
|
'greptime.semantic.source' = 'prometheus'
|
|
);
|
|
|
|
create table kube_pod_owner (
|
|
greptime_timestamp timestamp(3) time index,
|
|
uid string,
|
|
namespace string,
|
|
pod string,
|
|
owner_kind string,
|
|
owner_name string,
|
|
greptime_value double,
|
|
primary key (uid, namespace, pod, owner_kind, owner_name)
|
|
) with (
|
|
'greptime.semantic.signal_type' = 'metric',
|
|
'greptime.semantic.source' = 'prometheus'
|
|
);
|
|
|
|
create table kube_pod_container_info (
|
|
greptime_timestamp timestamp(3) time index,
|
|
uid string,
|
|
container string,
|
|
image string,
|
|
greptime_value double,
|
|
primary key (uid, container, image)
|
|
) with (
|
|
'greptime.semantic.signal_type' = 'metric',
|
|
'greptime.semantic.source' = 'prometheus'
|
|
);
|
|
|
|
create table kube_service_info (
|
|
greptime_timestamp timestamp(3) time index,
|
|
uid string,
|
|
namespace string,
|
|
"service" string,
|
|
cluster_ip string,
|
|
greptime_value double,
|
|
primary key (uid, namespace, "service", cluster_ip)
|
|
) with (
|
|
'greptime.semantic.signal_type' = 'metric',
|
|
'greptime.semantic.source' = 'prometheus'
|
|
);
|
|
|
|
create table target_info (
|
|
greptime_timestamp timestamp(3) time index,
|
|
job string,
|
|
instance string,
|
|
k8s_cluster_name string,
|
|
greptime_value double,
|
|
primary key (job, instance, k8s_cluster_name)
|
|
) with (
|
|
'greptime.semantic.signal_type' = 'metric',
|
|
'greptime.semantic.source' = 'prometheus'
|
|
);
|
|
|
|
create table http_requests_total (
|
|
greptime_timestamp timestamp(3) time index,
|
|
job string,
|
|
instance string,
|
|
greptime_value double,
|
|
primary key (job, instance)
|
|
) with (
|
|
'greptime.semantic.signal_type' = 'metric',
|
|
'greptime.semantic.source' = 'prometheus'
|
|
);
|
|
|
|
insert into kube_pod_info values
|
|
(now(), 'uid-1', 'default', 'api-1', 'node-a', 1),
|
|
(now(), 'uid-2', 'default', 'api-2', 'node-a', 1),
|
|
(now(), 'uid-3', 'default', 'pending-1', '', 1),
|
|
(now(), '', 'default', 'ghost', 'node-a', 1);
|
|
|
|
insert into kube_pod_owner values
|
|
(now(), 'uid-1', 'default', 'api-1', 'ReplicaSet', 'api-rs', 1),
|
|
(now(), 'uid-2', 'default', 'api-2', 'ReplicaSet', 'api-rs', 1);
|
|
|
|
insert into kube_pod_container_info values
|
|
(now(), 'uid-1', 'main', 'nginx:1.25', 1);
|
|
|
|
insert into kube_service_info values
|
|
(now(), 'svc-uid-1', 'default', 'api-svc', '10.0.0.1', 1);
|
|
|
|
insert into target_info values
|
|
(now(), 'shop/api', 'inst-1', 'prod', 1);
|
|
|
|
insert into http_requests_total values
|
|
(now(), 'shop/api', 'inst-1', 42);
|
|
|
|
-- SQLNESS PROTOCOL MYSQL
|
|
select entity_type, entity_id, source_tables
|
|
from greptime_private.semantic_entities
|
|
order by entity_type, entity_id, source_tables;
|
|
|
|
-- SQLNESS PROTOCOL MYSQL
|
|
select src_type, src_id, dst_type, dst_id, rel_type, provenance
|
|
from greptime_private.semantic_relationships
|
|
order by rel_type, src_id, dst_id;
|
|
|
|
drop table kube_pod_info;
|
|
|
|
drop table kube_pod_owner;
|
|
|
|
drop table kube_pod_container_info;
|
|
|
|
drop table kube_service_info;
|
|
|
|
drop table target_info;
|
|
|
|
drop table http_requests_total;
|