Lei, HUANG
5fe17531ee
## Summary - Add post-flush dirty-window notifications for metric writes through `PendingRowsBatcher`, so batching-mode flows are updated when Prometheus remote write uses the pending-row batcher path. - Notifications fire only after the entire physical flush succeeds; failed flushes (including partial region failures) send no notification. Notification errors are best-effort and never affect the persisted write result. - Optimize timestamp extraction with a null-free fast path (`extend_from_slice(values())`) and a nullable fallback (`iter().flatten()`). - Refactor notifier to take ownership of `Vec<TableBatch>`, eliminating the per-flush vector clone. - Key `PendingBatch` by logical `TableId` to prevent same-name drop/recreate merging within one flush interval. ## Known follow-ups (from self-review) - Per-peer `Vec<i64>` clone in notifier could use `Arc<Vec<i64>>`; intentionally deferred as the cost is negligible for typical peer counts. - No integration/sqlness test for end-to-end flow notification through the batcher. - Cache lookup `Err` path and multi-table flush path lack dedicated unit tests. ## Test Plan - [x] `cargo nextest run -p servers --lib --retries 0` — 293 tests pass - [x] `cargo fmt --all -- --check` - [x] `cargo check -p servers -p frontend -p operator -p tests-integration` - [x] `git diff --check`
Setup tests for multiple storage backend
To run the integration test, please copy .env.example to .env in the project root folder and change the values on need.
Take s3 for example. You need to set your S3 bucket, access key id and secret key:
# Settings for s3 test
GT_S3_BUCKET=S3 bucket
GT_S3_REGION=S3 region
GT_S3_ACCESS_KEY_ID=S3 access key id
GT_S3_ACCESS_KEY=S3 secret access key
Run
Execute the following command in the project root folder:
cargo test integration
Test s3 storage:
cargo test s3
Test oss storage:
cargo test oss
Test azblob storage:
cargo test azblob
Setup tests with Kafka wal
To run the integration test, please copy .env.example to .env in the project root folder and change the values on need.
GT_KAFKA_ENDPOINTS = localhost:9092
Setup kafka standalone
cd tests-integration/fixtures
docker compose -f docker-compose.yml up kafka
Setup tests with etcd TLS
This guide explains how to set up and test TLS-enabled etcd connections in GreptimeDB integration tests.
Quick Start
TLS certificates are already at tests-integration/fixtures/etcd-tls-certs/.
-
Start TLS-enabled etcd:
cd tests-integration/fixtures docker compose up etcd-tls -d -
Start all services (including etcd-tls):
cd tests-integration/fixtures docker compose up -d --wait
Certificate Details
The checked-in certificates include:
ca.crt- Certificate Authority certificateserver.crt/server-key.pem- Server certificate for etcd-tls serviceclient.crt/client-key.pem- Client certificate for connecting to etcd-tls
The server certificate includes SANs for localhost, etcd-tls, 127.0.0.1, and ::1.
Regenerating Certificates (Optional)
If you need to regenerate the etcd certificates:
# Regenerate certificates (overwrites existing ones)
./scripts/generate-etcd-tls-certs.sh
# Or generate in custom location
./scripts/generate-etcd-tls-certs.sh /path/to/cert/directory
If you need to regenerate the mysql and postgres certificates:
# Regenerate certificates (overwrites existing ones)
./scripts/generate_certs.sh
# Or generate in custom location
./scripts/generate_certs.sh /path/to/cert/directory
Note: The checked-in certificates are for testing purposes only and should never be used in production.