Files
greptimedb/tests-integration/tests/truncate.rs
T
Chenglong Zheng 2117f8b059 feat: Support procedure_state() using the last procedure ID (#9876)
* feat: Support procedure_state() using the last procedure ID

Signed-off-by: hahaha <a310608318@gmail.com>

* feat: Fix and add tests according to review comments

Signed-off-by: hahaha <a310608318@gmail.com>

* fix: the zero-argument signature in ADMIN swallows explicit arguments

Signed-off-by: hahaha <a310608318@gmail.com>

* fix: fix the CI failures caused by SQL version issues

Signed-off-by: hahaha <a310608318@gmail.com>

* fix: apply the changes based on the review

Signed-off-by: hahaha <a310608318@gmail.com>

---------

Signed-off-by: hahaha <a310608318@gmail.com>
2026-10-27 07:27:55 +00:00

494 lines
16 KiB
Rust

// Copyright 2023 Greptime Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
use std::sync::Arc;
use std::time::Duration;
use client::OutputData;
use common_error::ext::ErrorExt;
use common_error::snafu::ResultExt;
use common_error::status_code::StatusCode;
use common_meta::lock_key::TableLock;
use common_procedure::{
LockKey, Procedure, ProcedureId, ProcedureState, ProcedureWithId, Status, watcher,
};
use common_recordbatch::RecordBatches;
use datatypes::arrow::array::AsArray;
use frontend::instance::Instance;
use servers::error::{CollectRecordbatchSnafu, Result as ServerResult};
use servers::query_handler::sql::SqlQueryHandler;
use session::Session;
use session::context::Channel;
use sqlx::{Connection, Executor, Row, Statement};
use tests_integration::cluster::GreptimeDbClusterBuilder;
use tests_integration::standalone::GreptimeDbStandaloneBuilder;
use tests_integration::test_util::{execute_sql, execute_sql_and_expect};
use tokio::sync::Notify;
/// Holds the table lock until explicitly released, keeping truncate pending.
struct HoldTruncateTableLock {
table_id: u32,
started: Arc<Notify>,
release: Arc<Notify>,
}
#[async_trait::async_trait]
impl Procedure for HoldTruncateTableLock {
fn type_name(&self) -> &str {
"test::HoldTruncateTableLock"
}
async fn execute(&mut self, _: &common_procedure::Context) -> common_procedure::Result<Status> {
self.started.notify_one();
self.release.notified().await;
Ok(Status::done())
}
fn dump(&self) -> common_procedure::Result<String> {
Ok(String::new())
}
fn lock_key(&self) -> LockKey {
LockKey::new(vec![TableLock::Write(self.table_id).into()])
}
}
#[rstest_reuse::apply(crate::both_deployment_cases)]
async fn test_truncate_wait_and_timeout(distributed: bool) {
let cluster = if distributed {
Some(
GreptimeDbClusterBuilder::new("truncate_wait_and_timeout")
.await
.with_datanodes(1)
.build(false)
.await,
)
} else {
None
};
let standalone = if distributed {
None
} else {
Some(
GreptimeDbStandaloneBuilder::new("truncate_wait_and_timeout")
.build()
.await,
)
};
let (frontend, manager) = if let Some(cluster) = &cluster {
(
cluster.fe_instance().clone(),
cluster.metasrv.procedure_manager().clone(),
)
} else {
let standalone = standalone.as_ref().unwrap();
(
standalone.fe_instance().clone(),
standalone.procedure_manager.clone(),
)
};
execute_sql(
&frontend,
"CREATE TABLE truncate_wait_test (v INT, ts TIMESTAMP TIME INDEX)",
)
.await;
execute_sql(&frontend, "INSERT INTO truncate_wait_test VALUES (1, 1)").await;
let definition = execute_sql(&frontend, "SHOW CREATE TABLE truncate_wait_test")
.await
.data
.pretty_print()
.await;
let table_id = frontend
.catalog_manager()
.table("greptime", "public", "truncate_wait_test", None)
.await
.unwrap()
.unwrap()
.table_info()
.table_id();
let started = Arc::new(Notify::new());
let release = Arc::new(Notify::new());
let mut blocker = manager
.submit(ProcedureWithId::with_random_id(Box::new(
HoldTruncateTableLock {
table_id,
started: started.clone(),
release: release.clone(),
},
)))
.await
.unwrap();
tokio::time::timeout(Duration::from_secs(10), started.notified())
.await
.unwrap();
let session = Session::new(None, Channel::Mysql, Default::default(), 0);
let query_ctx = session.new_query_context();
let output = run_sql(
&frontend,
"TRUNCATE TABLE truncate_wait_test WITH (wait=false, timeout='10s')",
&session,
)
.await
.unwrap();
let id = procedure_id_from_output(output).to_string();
assert_eq!(query_ctx.last_procedure_id(), Some(id.clone()));
for sql in [
format!("SELECT procedure_state('{id}')"),
"SELECT procedure_state()".to_string(),
] {
let state = run_sql(&frontend, &sql, &session)
.await
.unwrap()
.pretty_print()
.await;
assert!(state.contains(r#""status":"Running""#), "{state}");
assert_eq!(query_ctx.last_procedure_id(), Some(id.clone()));
}
// The same table lock holds a synchronous truncate past its wait deadline.
// Give metadata reads and submission a generous budget. Using the same budget
// also verifies that the async procedure keeps running after it expires.
let err = run_sql(
&frontend,
"TRUNCATE TABLE truncate_wait_test WITH (wait=true, timeout='10s')",
&session,
)
.await
.unwrap_err();
assert_eq!(query_ctx.last_procedure_id(), Some(id.clone()));
if distributed {
assert!(matches!(
err.status_code(),
StatusCode::DeadlineExceeded | StatusCode::Cancelled
));
} else {
assert_eq!(err.status_code(), StatusCode::Cancelled);
assert!(err.output_msg().contains("DDL request timed out"), "{err}");
}
let pending = manager
.list_procedures()
.await
.unwrap()
.into_iter()
.filter(|procedure| procedure.type_name == "metasrv-procedure::TruncateTable")
.collect::<Vec<_>>();
assert_eq!(pending.len(), 2);
let mut watchers = pending
.into_iter()
.map(|procedure| {
assert!(matches!(procedure.state, ProcedureState::Running));
manager.procedure_watcher(procedure.id).unwrap()
})
.collect::<Vec<_>>();
execute_sql_and_expect(
&frontend,
"SELECT * FROM truncate_wait_test",
r#"
+---+-------------------------+
| v | ts |
+---+-------------------------+
| 1 | 1970-01-01T00:00:00.001 |
+---+-------------------------+
"#,
)
.await;
release.notify_one();
tokio::time::timeout(Duration::from_secs(10), async {
watcher::wait(&mut blocker).await.unwrap();
for watcher in &mut watchers {
watcher::wait(watcher).await.unwrap();
}
})
.await
.unwrap();
execute_sql_and_expect(
&frontend,
"SELECT * FROM truncate_wait_test",
r#"
+---+----+
| v | ts |
+---+----+
+---+----+
"#,
)
.await;
assert_eq!(
definition,
execute_sql(&frontend, "SHOW CREATE TABLE truncate_wait_test")
.await
.data
.pretty_print()
.await
);
for (sql, succeeds) in [
("SELECT 1", true),
("TRUNCATE TABLE truncate_wait_test WITH (wait=true)", true),
(
"TRUNCATE TABLE nonexistent_session_table WITH (wait=false)",
false,
),
("SELECT procedure_state(NULL)", false),
("SELECT procedure_state('')", false),
("SELECT procedure_state('invalid-id')", false),
] {
let result = run_sql(&frontend, sql, &session).await;
assert_eq!(result.is_ok(), succeeds, "{sql}: {result:?}");
assert_eq!(query_ctx.last_procedure_id(), Some(id.clone()));
}
let other_session = Session::new(None, Channel::Mysql, Default::default(), 1);
let state = run_sql(
&frontend,
&format!("SELECT procedure_state('{id}')"),
&other_session,
)
.await
.unwrap()
.pretty_print()
.await;
assert!(state.contains(r#""status":"Done""#), "{state}");
let err = run_sql(&frontend, "SELECT procedure_state()", &other_session)
.await
.unwrap_err();
assert!(
err.output_msg()
.contains("No procedure ID has been returned")
);
let output = run_sql(
&frontend,
"TRUNCATE TABLE truncate_wait_test WITH (wait=false)",
&session,
)
.await
.unwrap();
let new_id = procedure_id_from_output(output);
assert_ne!(new_id.to_string(), id);
assert_eq!(query_ctx.last_procedure_id(), Some(new_id.to_string()));
let mut watcher = manager.procedure_watcher(new_id).unwrap();
tokio::time::timeout(Duration::from_secs(10), watcher::wait(&mut watcher))
.await
.unwrap()
.unwrap();
}
#[rstest::rstest]
#[case::mysql("MYSQL_SERVER", "mysql")]
#[case::postgres("POSTGRES_SERVER", "postgres")]
#[tokio::test(flavor = "multi_thread")]
async fn test_procedure_state_prepared_and_admin(
#[case] server_name: &str,
#[case] protocol: &str,
) {
let instance = GreptimeDbStandaloneBuilder::new("procedure_state_prepared")
.build()
.await;
let mut opts = instance.opts.clone();
opts.http.addr = "127.0.0.1:0".into();
opts.grpc.bind_addr = "127.0.0.1:0".into();
opts.mysql.addr = "127.0.0.1:0".into();
opts.postgres.addr = "127.0.0.1:0".into();
let mut servers =
frontend::server::Services::new(opts, instance.fe_instance().clone(), Default::default())
.build()
.unwrap();
servers.start_all().await.unwrap();
sqlx::any::install_default_drivers();
let url = format!("{protocol}://{}/public", servers.addr(server_name).unwrap());
let mut connection = sqlx::AnyConnection::connect(&url).await.unwrap();
for table in ["prepared_async", "prepared_sync"] {
// Safety: the table names are fixed test-local identifiers.
connection
.execute(sqlx::AssertSqlSafe(format!(
"CREATE TABLE {table} (ts TIMESTAMP TIME INDEX)"
)))
.await
.unwrap();
}
// Prepare once, before any ID exists, and reuse the same statement below.
let statement = connection
.prepare(sqlx::SqlStr::from_static(
"SELECT procedure_state() AS state",
))
.await
.unwrap();
let manager = &instance.procedure_manager;
let id: String = connection
.fetch_one("TRUNCATE TABLE prepared_async WITH (wait=false)")
.await
.unwrap()
.get(0);
let mut completed = manager
.procedure_watcher(ProcedureId::parse_str(&id).unwrap())
.unwrap();
tokio::time::timeout(Duration::from_secs(10), watcher::wait(&mut completed))
.await
.unwrap()
.unwrap();
assert_eq!(prepared_state(&mut connection, &statement).await, "Done");
// An explicit ADMIN ID works without history and does not record that ID.
let mut other_connection = sqlx::AnyConnection::connect(&url).await.unwrap();
for explicit in [false, true, false] {
let sql = if explicit {
format!("ADMIN procedure_state('{id}')")
} else {
"ADMIN procedure_state()".to_string()
};
// Safety: the SQL contains only a procedure ID returned by this test.
let result = sqlx::query(sqlx::AssertSqlSafe(sql.as_str()))
.fetch_one(&mut other_connection)
.await;
if explicit {
assert_eq!(result.unwrap().get::<String, _>(0), r#"{"status":"Done"}"#);
} else {
let err = result.err().expect("expected missing procedure ID error");
assert!(
err.to_string()
.contains("No procedure ID has been returned"),
"{err}"
);
}
}
other_connection.close().await.unwrap();
let table_id = instance
.fe_instance()
.catalog_manager()
.table("greptime", "public", "prepared_async", None)
.await
.unwrap()
.unwrap()
.table_info()
.table_id();
let started = Arc::new(Notify::new());
let release = Arc::new(Notify::new());
let mut blocker = manager
.submit(ProcedureWithId::with_random_id(Box::new(
HoldTruncateTableLock {
table_id,
started: started.clone(),
release: release.clone(),
},
)))
.await
.unwrap();
tokio::time::timeout(Duration::from_secs(10), started.notified())
.await
.unwrap();
let new_id: String = connection
.fetch_one("TRUNCATE TABLE prepared_async WITH (wait=false)")
.await
.unwrap()
.get(0);
assert_ne!(id, new_id);
let mut pending = manager
.procedure_watcher(ProcedureId::parse_str(&new_id).unwrap())
.unwrap();
// A is Done and B is Running, so retaining A cannot pass this assertion.
assert_eq!(prepared_state(&mut connection, &statement).await, "Running");
for (sql, expected) in [
("ADMIN procedure_state()".to_string(), "Running"),
(format!("ADMIN procedure_state('{id}')"), "Done"),
("ADMIN procedure_state()".to_string(), "Running"),
] {
// Safety: the SQL contains only a procedure ID returned by this test.
let state: String = connection
.fetch_one(sqlx::AssertSqlSafe(sql.as_str()))
.await
.unwrap()
.get(0);
assert_eq!(state, format!(r#"{{"status":"{expected}"}}"#), "{sql}");
}
for sql in [
"ADMIN procedure_state('a', 'b')",
"ADMIN procedure_state(NULL)",
"ADMIN procedure_state('')",
"ADMIN procedure_state('invalid-id')",
] {
assert!(connection.fetch_one(sql).await.is_err(), "{sql}");
}
connection
.execute("TRUNCATE TABLE prepared_sync WITH (wait=true)")
.await
.unwrap();
assert_eq!(prepared_state(&mut connection, &statement).await, "Running");
release.notify_one();
tokio::time::timeout(Duration::from_secs(10), async {
watcher::wait(&mut blocker).await.unwrap();
watcher::wait(&mut pending).await.unwrap();
})
.await
.unwrap();
// The ID stays B; only its state changes between executions.
assert_eq!(prepared_state(&mut connection, &statement).await, "Done");
connection.close().await.unwrap();
servers.shutdown_all().await.unwrap();
}
async fn prepared_state(
connection: &mut sqlx::AnyConnection,
statement: &sqlx::any::AnyStatement,
) -> String {
let state: String = statement
.query()
.fetch_one(connection)
.await
.unwrap()
.get(0);
serde_json::from_str::<serde_json::Value>(&state).unwrap()["status"]
.as_str()
.unwrap()
.to_string()
}
async fn run_sql(
frontend: &Arc<Instance>,
sql: &str,
session: &Session,
) -> ServerResult<OutputData> {
let data = frontend
.do_query(sql, session.new_query_context())
.await
.remove(0)?
.data;
match data {
OutputData::Stream(stream) => Ok(OutputData::RecordBatches(
RecordBatches::try_collect(stream)
.await
.context(CollectRecordbatchSnafu)?,
)),
data => Ok(data),
}
}
fn procedure_id_from_output(output: OutputData) -> ProcedureId {
let OutputData::RecordBatches(batches) = output else {
panic!("expected Procedure ID result");
};
let batch = batches.iter().next().unwrap();
let id = batch
.column_by_name("Procedure ID")
.unwrap()
.as_string::<i32>()
.value(0);
ProcedureId::parse_str(id).unwrap()
}