mirror of
https://github.com/GreptimeTeam/greptimedb.git
synced 2026-10-13 15:32:36 +00:00
Yingwen
c52be28ff9
* fix: coalesce equal histogram quantile bucket boundaries
Merge numerically equivalent bucket boundaries before monotonicity repair, preserving the allocation-free path for unique boundaries. Share coalescing with histogram_fraction and cover duplicate boundaries with unit and SQL regressions.
Fixes #9443
Signed-off-by: evenyag <realevenyag@gmail.com>
* fix: keep duplicate infinity buckets in one histogram group
Confirm classic histogram completion at a series/timestamp boundary or EOF instead of the first positive infinity. Retain lookahead across batches and reject incomplete optimistic groups so equivalent infinity labels reach numeric coalescing together.
Add stream and SQL regressions for duplicate infinity labels, including established bucket counts and EOF. Correct older fixtures to use distinct keys for distinct histogram groups.
Signed-off-by: evenyag <realevenyag@gmail.com>
* fix: avoid buffering histogram groups with invalid trailing bounds
Discover candidate bucket counts at the first group boundary and let optimistic validation fall back to safe mode for malformed bounds. Document discovery and cover trailing invalid and null labels with a focused streaming regression.
Signed-off-by: evenyag <realevenyag@gmail.com>
---------
Signed-off-by: evenyag <realevenyag@gmail.com>
(cherry picked from commit 97913b4b3a)
Signed-off-by: WenyXu <wenymedia@gmail.com>
303 lines
8.7 KiB
SQL
303 lines
8.7 KiB
SQL
-- from prometheus/promql/testdata/histograms.test
|
|
-- cases related to metric `testhistogram_bucket`
|
|
|
|
create table histogram_bucket (
|
|
ts timestamp time index,
|
|
le string,
|
|
s string,
|
|
val double,
|
|
primary key (s, le),
|
|
);
|
|
|
|
insert into histogram_bucket values
|
|
(3000000, "0.1", "positive", 50),
|
|
(3000000, ".2", "positive", 70),
|
|
(3000000, "1e0", "positive", 110),
|
|
(3000000, "+Inf", "positive", 120),
|
|
(3000000, "-.2", "negative", 10),
|
|
(3000000, "-0.1", "negative", 20),
|
|
(3000000, "0.3", "negative", 20),
|
|
(3000000, "+Inf", "negative", 30);
|
|
|
|
-- Quantile too low.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(-0.1, histogram_bucket);
|
|
|
|
-- Quantile too high.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(1.01, histogram_bucket);
|
|
|
|
-- Quantile invalid.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(NaN, histogram_bucket);
|
|
|
|
-- Quantile value in lowest bucket, which is positive.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0, histogram_bucket{s="positive"});
|
|
|
|
-- Quantile value in lowest bucket, which is negative.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0, histogram_bucket{s="negative"});
|
|
|
|
-- Quantile value in highest bucket.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(1, histogram_bucket);
|
|
|
|
-- Finally some useful quantiles.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.2, histogram_bucket);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.5, histogram_bucket);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.8, histogram_bucket);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') label_replace(histogram_quantile(0.8, histogram_bucket), "s2", "$1", "s", "(.*)tive");
|
|
|
|
-- More realistic with rates.
|
|
-- This case doesn't contains value because other point are not inserted.
|
|
-- Prometheus `v3.9.1` updates the range to 10m to avoid the (t-r) boundary.
|
|
-- Quantile with rate is covered in other cases.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.2, rate(histogram_bucket[10m]));
|
|
|
|
drop table histogram_bucket;
|
|
|
|
-- cases related to `testhistogram2_bucket`
|
|
create table histogram2_bucket (
|
|
ts timestamp time index,
|
|
le string,
|
|
val double,
|
|
primary key (le),
|
|
);
|
|
|
|
insert into histogram2_bucket values
|
|
(0, "0", 0),
|
|
(300000, "0", 0),
|
|
(600000, "0", 0),
|
|
(900000, "0", 0),
|
|
(1200000, "0", 0),
|
|
(1500000, "0", 0),
|
|
(1800000, "0", 0),
|
|
(2100000, "0", 0),
|
|
(2400000, "0", 0),
|
|
(2700000, "0", 0),
|
|
(0, "2", 1),
|
|
(300000, "2", 2),
|
|
(600000, "2", 3),
|
|
(900000, "2", 4),
|
|
(1200000, "2", 5),
|
|
(1500000, "2", 6),
|
|
(1800000, "2", 7),
|
|
(2100000, "2", 8),
|
|
(2400000, "2", 9),
|
|
(2700000, "2", 10),
|
|
(0, "4", 2),
|
|
(300000, "4", 4),
|
|
(600000, "4", 6),
|
|
(900000, "4", 8),
|
|
(1200000, "4", 10),
|
|
(1500000, "4", 12),
|
|
(1800000, "4", 14),
|
|
(2100000, "4", 16),
|
|
(2400000, "4", 18),
|
|
(2700000, "4", 20),
|
|
(0, "6", 3),
|
|
(300000, "6", 6),
|
|
(600000, "6", 9),
|
|
(900000, "6", 12),
|
|
(1200000, "6", 15),
|
|
(1500000, "6", 18),
|
|
(1800000, "6", 21),
|
|
(2100000, "6", 24),
|
|
(2400000, "6", 27),
|
|
(2700000, "6", 30),
|
|
(0, "+Inf", 3),
|
|
(300000, "+Inf", 6),
|
|
(600000, "+Inf", 9),
|
|
(900000, "+Inf", 12),
|
|
(1200000, "+Inf", 15),
|
|
(1500000, "+Inf", 18),
|
|
(1800000, "+Inf", 21),
|
|
(2100000, "+Inf", 24),
|
|
(2400000, "+Inf", 27),
|
|
(2700000, "+Inf", 30);
|
|
|
|
-- Want results exactly in the middle of the bucket.
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (420, 420, '1s') histogram_quantile(0.166, histogram2_bucket);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (420, 420, '1s') histogram_quantile(0.5, histogram2_bucket);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (420, 420, '1s') histogram_quantile(0.833, histogram2_bucket);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (2820, 2820, '1s') histogram_quantile(0.166, rate(histogram2_bucket[15m]));
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (2820, 2820, '1s') histogram_quantile(0.5, rate(histogram2_bucket[15m]));
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (2820, 2820, '1s') histogram_quantile(0.833, rate(histogram2_bucket[15m]));
|
|
|
|
drop table histogram2_bucket;
|
|
|
|
-- not from Prometheus
|
|
-- makesure the sort expr works as expected
|
|
create table histogram3_bucket (
|
|
ts timestamp time index,
|
|
le string,
|
|
s string,
|
|
val double,
|
|
primary key (s, le),
|
|
);
|
|
|
|
insert into histogram3_bucket values
|
|
(2900000, "0.1", "a", 0),
|
|
(2900000, "1", "a", 0),
|
|
(2900000, "5", "a", 0),
|
|
(2900000, "+Inf", "a", 0),
|
|
(3000000, "0.1", "a", 50),
|
|
(3000000, "1", "a", 70),
|
|
(3000000, "5", "a", 110),
|
|
(3000000, "+Inf", "a", 120),
|
|
(3005000, "0.1", "a", 10),
|
|
(3005000, "1", "a", 20),
|
|
(3005000, "5", "a", 20),
|
|
(3005000, "+Inf", "a", 30);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3005, '3s') histogram_quantile(0.5, sum by(le, s) (rate(histogram3_bucket[5m])));
|
|
|
|
drop table histogram3_bucket;
|
|
|
|
-- test with invalid data (unaligned buckets)
|
|
create table histogram4_bucket (
|
|
ts timestamp time index,
|
|
le string,
|
|
s string,
|
|
val double,
|
|
primary key (s, le),
|
|
);
|
|
|
|
insert into histogram4_bucket values
|
|
(2900000, "0.1", "a", 0),
|
|
(2900000, "1", "a", 10),
|
|
(2900000, "5", "a", 20),
|
|
(2900000, "+Inf", "a", 150),
|
|
(3000000, "0.1", "a", 50),
|
|
(3000000, "1", "a", 70),
|
|
(3000000, "5", "a", 120),
|
|
-- INF here is missing
|
|
;
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (2900, 3000, '100s') histogram_quantile(0.9, histogram4_bucket);
|
|
|
|
drop table histogram4_bucket;
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval(0, 10, '10s') histogram_quantile(0.99, sum by(pod,instance, fff) (rate(greptime_servers_postgres_query_elapsed_bucket{instance=~"xxx"}[1m])));
|
|
|
|
-- test case where table exists but doesn't have 'le' column should raise error
|
|
CREATE TABLE greptime_servers_postgres_query_elapsed_no_le (
|
|
pod STRING,
|
|
instance STRING,
|
|
t TIMESTAMP TIME INDEX,
|
|
v DOUBLE,
|
|
PRIMARY KEY (pod, instance)
|
|
);
|
|
|
|
-- should return empty result instead of error when 'le' column is missin
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval(0, 10, '10s') histogram_quantile(0.99, sum by(pod,instance, le) (rate(greptime_servers_postgres_query_elapsed_no_le{instance=~"xxx"}[1m])));
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval(0, 10, '10s') histogram_quantile(0.99, sum by(pod,instance, fbf) (rate(greptime_servers_postgres_query_elapsed_no_le{instance=~"xxx"}[1m])));
|
|
|
|
drop table greptime_servers_postgres_query_elapsed_no_le;
|
|
|
|
-- test case with some missing buckets
|
|
create table histogram5_bucket (
|
|
ts timestamp time index,
|
|
le string,
|
|
s string,
|
|
val double,
|
|
primary key (s, le),
|
|
);
|
|
|
|
insert into histogram5_bucket values
|
|
(3000000, "0.1", "a", 0),
|
|
-- (3000000, "1", "a", 0),
|
|
-- (3000000, "5", "a", 0),
|
|
-- (3000000, "+Inf", "a", 0),
|
|
(3005000, "0.1", "a", 50),
|
|
(3005000, "1", "a", 70),
|
|
(3005000, "5", "a", 110),
|
|
(3005000, "+Inf", "a", 120),
|
|
(3010000, "0.1", "a", 10),
|
|
-- (3010000, "1", "a", 20),
|
|
-- (3010000, "5", "a", 20),
|
|
(3010000, "+Inf", "a", 30),
|
|
(3015000, "0.1", "a", 10),
|
|
(3015000, "1", "a", 10),
|
|
(3015000, "3", "a", 20), --
|
|
(3015000, "5", "a", 30),
|
|
(3015000, "+Inf", "a", 50);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3015, '3s') histogram_quantile(0.5, histogram5_bucket);
|
|
|
|
drop table histogram5_bucket;
|
|
|
|
-- Issue #9443: string labels stay distinct during aggregation, but equal
|
|
-- numeric bucket boundaries must be coalesced before monotonicity repair.
|
|
CREATE TABLE equivalent_bounds_bucket (
|
|
ts TIMESTAMP TIME INDEX,
|
|
instance STRING,
|
|
le STRING,
|
|
val DOUBLE,
|
|
PRIMARY KEY (instance, le)
|
|
);
|
|
|
|
INSERT INTO equivalent_bounds_bucket VALUES
|
|
(3000000, 'a', '10', 40),
|
|
(3000000, 'a', '100', 50),
|
|
(3000000, 'a', '+Inf', 50),
|
|
(3000000, 'b', '10.0', 40),
|
|
(3000000, 'b', '100.0', 50),
|
|
(3000000, 'b', '1000.0', 50),
|
|
(3000000, 'b', '+Inf', 50);
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') sum by (le) (equivalent_bounds_bucket);
|
|
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.95, sum by (le) (equivalent_bounds_bucket));
|
|
|
|
-- SQLNESS SORT_RESULT 3 1
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.95, sum by (instance, le) (equivalent_bounds_bucket));
|
|
|
|
DROP TABLE equivalent_bounds_bucket;
|
|
|
|
-- Equivalent infinity labels belong to the same histogram until the group ends.
|
|
CREATE TABLE infinity_bounds_bucket (
|
|
ts TIMESTAMP TIME INDEX,
|
|
le STRING,
|
|
val DOUBLE,
|
|
PRIMARY KEY (le)
|
|
);
|
|
|
|
INSERT INTO infinity_bounds_bucket VALUES
|
|
(3000000, '10', 20),
|
|
(3000000, '10.0', 20),
|
|
(3000000, '+Inf', 25),
|
|
(3000000, '+inf', 25);
|
|
|
|
tql eval (3000, 3000, '1s') histogram_quantile(0.5, infinity_bounds_bucket);
|
|
|
|
DROP TABLE infinity_bounds_bucket;
|