Files
greptimedb/.github/scripts/query-regression-comment.cjs
discord9 d8f692f4c5 ci: run query regression on self-hosted runners (#8423)
* ci: run query regression on self-hosted runners

Signed-off-by: discord9 <discord9@163.com>

* ci: use dedicated perf regression runner labels

Signed-off-by: discord9 <discord9@163.com>

* ci: keep query regression runner scale set minimal

Signed-off-by: discord9 <discord9@163.com>

* ci: use custom query regression runner image

Signed-off-by: discord9 <discord9@163.com>

* ci: host query regression runner image in acr

Signed-off-by: discord9 <discord9@163.com>

* ci: harden query regression runner workflow

Signed-off-by: discord9 <discord9@163.com>

* ci: avoid runner uid assumptions in values

Signed-off-by: discord9 <discord9@163.com>

* ci: fix query regression comments for fork prs

Signed-off-by: discord9 <discord9@163.com>

* ci: address query regression review comments

Signed-off-by: discord9 <discord9@163.com>

---------

Signed-off-by: discord9 <discord9@163.com>
2026-07-06 13:12:18 +00:00

278 lines
10 KiB
JavaScript

// Copyright 2023 Greptime Team
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
const fs = require('fs');
const path = require('path');
function skip(core, message) {
core.info(message);
core.setOutput('should_post', 'false');
}
function findReports(dir) {
const reports = [];
for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
const full = path.join(dir, entry.name);
if (entry.isDirectory()) {
reports.push(...findReports(full));
} else if (entry.isFile() && entry.name === 'query-regression-report.json') {
reports.push(full);
}
}
return reports.sort();
}
function text(value) {
if (value === null || value === undefined || value === '') return 'N/A';
const result = String(value)
.replace(/<!--[\s\S]*?-->/g, '')
.replace(/\\/g, '\\\\')
.replace(/`/g, '&#96;')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/\[/g, '\\[')
.replace(/\]/g, '\\]')
.replace(/\(/g, '\\(')
.replace(/\)/g, '\\)')
.replace(/!/g, '\\!')
.replace(/@/g, '@\u200b')
.replace(/\|/g, '\\|')
.replace(/\r?\n/g, ' ');
return result.length > 512 ? `${result.slice(0, 509)}...` : result;
}
function statusEmoji(status) {
return { ok: '✅', measured: '✅', failed: '❌', planned: '📝', 'fixture-ready': '🧪' }[status] || '⚠️';
}
function fmtMs(value) {
const number = Number(value);
return Number.isFinite(number) ? number.toFixed(2) : 'N/A';
}
function measurementsByName(target) {
const result = new Map();
const measurements = Array.isArray(target?.measurements) ? target.measurements : [];
measurements.forEach((measurement, index) => {
result.set(String(measurement?.name || `query-${index}`), measurement || {});
});
return result;
}
function regression(base, candidate) {
const b = Number(base);
const c = Number(candidate);
if (!Number.isFinite(b) || !Number.isFinite(c) || b === 0) return 'N/A';
return `${(((c - b) / b) * 100).toFixed(1)}%`;
}
function renderReport(report, reportPath) {
const caseInfo = report.case || {};
const name = caseInfo.name || path.basename(path.dirname(reportPath));
const status = report.status || 'missing';
const lines = [
`### ${statusEmoji(status)} ${text(name)}`,
'',
`- **Status:** \`${text(status)}\``,
`- **Case path:** \`${text(report.case_path)}\``,
`- **Query mode:** \`${text(report.query_mode)}\``,
];
if (report.error) {
lines.push(`- **Error:** \`${text(report.error)}\``);
}
const targets = Array.isArray(report.targets) ? report.targets : [];
lines.push('', '| Target | Status | Validation errors | Region |', '| --- | --- | ---: | --- |');
for (const target of targets) {
const discovered = target?.discovered || {};
const region = Array.isArray(discovered)
? discovered.map(item => item?.region_id).filter(Boolean).join(', ')
: discovered.region_id;
lines.push(
`| ${text(target?.name)} | ${statusEmoji(target?.status)} \`${text(target?.status)}\` | ${(target?.validation_errors || []).length} | ${text(region)} |`
);
}
if (targets.length >= 2) {
const base = measurementsByName(targets[0]);
const candidate = measurementsByName(targets[1]);
const names = Array.from(new Set([...base.keys(), ...candidate.keys()])).sort();
lines.push('', '| Query | Base median ms | Candidate median ms | Regression |', '| --- | ---: | ---: | ---: |');
for (const query of names) {
const b = base.get(query) || {};
const c = candidate.get(query) || {};
lines.push(
`| ${text(query)} | ${fmtMs(b.latency_ms_median)} | ${fmtMs(c.latency_ms_median)} | ${regression(b.latency_ms_median, c.latency_ms_median)} |`
);
}
}
return lines.join('\n');
}
module.exports = async function validateQueryRegressionComment({ github, context, core }) {
const artifactDir = 'query-regression-comment';
const metadataPath = path.join(artifactDir, 'query-regression-pr.json');
const summaryPath = path.join(artifactDir, 'query-regression-summary.md');
if (!fs.existsSync(metadataPath)) {
return skip(core, 'Missing query-regression-pr.json; skipping sticky comment.');
}
let metadata;
try {
metadata = JSON.parse(fs.readFileSync(metadataPath, 'utf8'));
} catch (error) {
core.warning(`Invalid PR metadata JSON: ${error.message}`);
return skip(core, 'Invalid PR metadata JSON; skipping sticky comment.');
}
const expectedRunId = Number(process.env.WORKFLOW_RUN_ID);
const expectedRunAttempt = Number(process.env.WORKFLOW_RUN_ATTEMPT);
if (metadata.run_id !== expectedRunId || metadata.run_attempt !== expectedRunAttempt) {
return skip(core, 'Artifact metadata does not match this workflow_run; skipping.');
}
if (metadata.base_repo !== `${context.repo.owner}/${context.repo.repo}`) {
return skip(core, `PR targets ${metadata.base_repo}, not this repository; skipping.`);
}
const prNumber = Number(metadata.pr_number);
if (!Number.isInteger(prNumber) || prNumber <= 0) {
return skip(core, 'Invalid PR number in metadata; skipping.');
}
const run = context.payload.workflow_run;
if (run.event !== 'pull_request') {
return skip(core, `Workflow run event is ${run.event}, not pull_request; skipping.`);
}
if (run.head_sha !== metadata.head_sha) {
return skip(core, 'Workflow run head SHA differs from artifact metadata; skipping.');
}
const runHeadRepo = run.head_repository?.full_name;
if (!runHeadRepo) {
return skip(core, 'Workflow run head repository is missing; skipping.');
}
if (runHeadRepo !== metadata.head_repo) {
return skip(core, 'Workflow run head repository differs from artifact metadata; skipping.');
}
// GitHub leaves workflow_run.pull_requests empty for fork PRs. When present,
// use it as an extra guard; otherwise resolve the unique open PR from trusted
// workflow_run head repo/branch/SHA metadata before accepting the artifact PR.
const workflowPrNumbers = new Set(
(run.pull_requests || []).map(pr => Number(pr.number)).filter(Number.isInteger)
);
if (workflowPrNumbers.size > 0) {
if (!workflowPrNumbers.has(prNumber)) {
return skip(core, `PR #${prNumber} is not listed in workflow_run ${run.id}; skipping.`);
}
} else {
const runHeadOwner = run.head_repository?.owner?.login;
const runHeadBranch = run.head_branch;
if (!runHeadOwner || !runHeadBranch) {
return skip(core, 'Workflow run head owner or branch is missing; skipping.');
}
let matchingPrs;
try {
const { data: pullRequests } = await github.rest.pulls.list({
owner: context.repo.owner,
repo: context.repo.repo,
state: 'open',
head: `${runHeadOwner}:${runHeadBranch}`,
per_page: 100,
});
matchingPrs = pullRequests.filter(pr => (
pr.head.repo?.full_name === runHeadRepo &&
pr.head.sha === run.head_sha &&
pr.base.repo?.full_name === metadata.base_repo
));
} catch (error) {
core.warning(`Could not resolve PR from workflow_run metadata: ${error.message}`);
return skip(core, 'Could not resolve PR from workflow_run metadata; skipping.');
}
if (matchingPrs.length !== 1) {
return skip(core, `Workflow run matched ${matchingPrs.length} open PRs; skipping.`);
}
if (Number(matchingPrs[0].number) !== prNumber) {
return skip(core, `Artifact PR #${prNumber} does not match workflow_run PR #${matchingPrs[0].number}; skipping.`);
}
}
let pull;
try {
({ data: pull } = await github.rest.pulls.get({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: prNumber,
}));
} catch (error) {
core.warning(`Could not read PR #${prNumber}: ${error.message}`);
return skip(core, `Could not read PR #${prNumber}; skipping.`);
}
if (pull.state !== 'open') {
return skip(core, `PR #${prNumber} is ${pull.state}; skipping.`);
}
if (pull.base.repo.full_name !== metadata.base_repo || pull.head.repo.full_name !== metadata.head_repo) {
return skip(core, 'Current PR repository metadata does not match artifact; skipping.');
}
if (pull.head.sha !== metadata.head_sha) {
return skip(core, 'Current PR head SHA differs from artifact; skipping stale run.');
}
const reportPaths = findReports(artifactDir);
const serverUrl = process.env.GITHUB_SERVER_URL || 'https://github.com';
let body = [
'## Query regression report',
'',
'> Rendered by a trusted workflow from JSON artifacts produced by the query-regression run. Results from untrusted PR code are advisory until reviewed.',
'',
`- **Workflow run:** ${serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${expectedRunId}`,
`- **Base SHA:** \`${text(metadata.base_sha)}\``,
`- **Head SHA:** \`${text(metadata.head_sha)}\``,
'',
].join('\n');
if (reportPaths.length === 0) {
body += 'No query-regression JSON reports were found in the artifact.\n';
} else {
const rendered = [];
for (const reportPath of reportPaths) {
const size = fs.statSync(reportPath).size;
if (size > 1024 * 1024) {
return skip(core, `Report file too large: ${reportPath} (${size} bytes).`);
}
let report;
try {
report = JSON.parse(fs.readFileSync(reportPath, 'utf8'));
} catch (error) {
return skip(core, `Invalid report JSON in ${reportPath}: ${error.message}`);
}
rendered.push(renderReport(report, reportPath));
}
body += rendered.join('\n\n---\n\n') + '\n';
}
if (body.length > 59999) {
body = `${body.slice(0, 59500)}\n\n\n\n_Comment truncated because it exceeded 60000 characters._\n`;
}
fs.writeFileSync(summaryPath, body);
core.setOutput('should_post', 'true');
core.setOutput('pr_number', String(prNumber));
core.setOutput('summary_path', summaryPath);
};