mirror of
https://github.com/GreptimeTeam/greptimedb.git
synced 2026-01-16 02:02:56 +00:00
* chore/update-sequence-on-region-edit: ### Commit Message Refactor `get_last_seq_num` Method Across Engines - **Change Return Type**: Updated the `get_last_seq_num` method to return `Result<SequenceNumber, BoxedError>` instead of `Result<Option<SequenceNumber>, BoxedError>` in the following files: - `src/datanode/src/tests.rs` - `src/file-engine/src/engine.rs` - `src/metric-engine/src/engine.rs` - `src/metric-engine/src/engine/read.rs` - `src/mito2/src/engine.rs` - `src/query/src/optimizer/test_util.rs` - `src/store-api/src/region_engine.rs` - **Enhance Region Edit Handling**: Modified `RegionWorkerLoop` in `src/mito2/src/worker/handle_manifest.rs` to update file sequences during region edits. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * add committed_sequence to RegionEdit Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * chore/update-sequence-on-region-edit: ### Commit Message Refactor sequence retrieval method - **Renamed Method**: Changed `get_last_seq_num` to `get_committed_sequence` across multiple files to better reflect its purpose of retrieving the latest committed sequence. - Affected files: `tests.rs`, `engine.rs` in `file-engine`, `metric-engine`, `mito2`, `test_util.rs`, and `region_engine.rs`. - **Removed Unused Struct**: Deleted `RegionSequencesRequest` struct from `region_request.rs` as it is no longer needed. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * chore/update-sequence-on-region-edit: **Add Committed Sequence Handling in Region Engine** - **`engine.rs`**: Introduced a new test module `bump_committed_sequence_test` to verify committed sequence handling. - **`bump_committed_sequence_test.rs`**: Added a test to ensure the committed sequence is correctly updated and persisted across region reopenings. - **`action.rs`**: Updated `RegionManifest` and `RegionManifestBuilder` to include `committed_sequence` for tracking. - **`manager.rs`**: Adjusted manifest size assertion to accommodate new committed sequence data. - **`opener.rs`**: Implemented logic to override committed sequence during region opening. - **`version.rs`**: Added `set_committed_sequence` method to update the committed sequence in `VersionControl`. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * chore/update-sequence-on-region-edit: **Enhance `test_bump_committed_sequence` in `bump_committed_sequence_test.rs`** - Updated the test to include row operations using `build_rows`, `put_rows`, and `rows_schema` to verify the committed sequence behavior. - Adjusted assertions to reflect changes in committed sequence after row operations and region edits. - Added comments to clarify the expected behavior of committed sequence after reopening the region and replaying the WAL. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * chore/update-sequence-on-region-edit: **Enhance Region Sequence Management** - **`bump_committed_sequence_test.rs`**: Updated test to handle region reopening and sequence management, ensuring committed sequences are correctly set and verified after edits. - **`opener.rs`**: Improved committed sequence handling by overriding it only if the manifest's sequence is greater than the replayed sequence. Added logging for mutation sequence replay. - **`region_write_ctx.rs`**: Modified `push_mutation` and `push_bulk` methods to adopt sequence numbers from parameters, enhancing sequence management during write operations. - **`handle_write.rs`**: Updated `RegionWorkerLoop` to pass sequence numbers in `push_bulk` and `push_mutation` methods, ensuring consistent sequence handling. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> * chore/update-sequence-on-region-edit: ### Remove Debug Logging from `opener.rs` - Removed debug logging for mutation sequences in `opener.rs` to clean up the output and improve performance. Signed-off-by: Lei, HUANG <mrsatangel@gmail.com> --------- Signed-off-by: Lei, HUANG <mrsatangel@gmail.com>
347 lines
10 KiB
Rust
347 lines
10 KiB
Rust
// Copyright 2023 Greptime Team
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use std::any::Any;
|
|
use std::collections::HashMap;
|
|
use std::sync::{Arc, RwLock};
|
|
|
|
use api::region::RegionResponse;
|
|
use async_trait::async_trait;
|
|
use common_catalog::consts::FILE_ENGINE;
|
|
use common_error::ext::BoxedError;
|
|
use common_recordbatch::SendableRecordBatchStream;
|
|
use common_telemetry::{error, info};
|
|
use object_store::ObjectStore;
|
|
use snafu::{OptionExt, ensure};
|
|
use store_api::metadata::RegionMetadataRef;
|
|
use store_api::region_engine::{
|
|
RegionEngine, RegionManifestInfo, RegionRole, RegionScannerRef, RegionStatistic,
|
|
SetRegionRoleStateResponse, SetRegionRoleStateSuccess, SettableRegionRoleState,
|
|
SinglePartitionScanner, SyncManifestResponse,
|
|
};
|
|
use store_api::region_request::{
|
|
AffectedRows, RegionCloseRequest, RegionCreateRequest, RegionDropRequest, RegionOpenRequest,
|
|
RegionRequest,
|
|
};
|
|
use store_api::storage::{RegionId, ScanRequest, SequenceNumber};
|
|
use tokio::sync::Mutex;
|
|
|
|
use crate::config::EngineConfig;
|
|
use crate::error::{
|
|
RegionNotFoundSnafu, Result as EngineResult, UnexpectedEngineSnafu, UnsupportedSnafu,
|
|
};
|
|
use crate::region::{FileRegion, FileRegionRef};
|
|
|
|
pub struct FileRegionEngine {
|
|
inner: EngineInnerRef,
|
|
}
|
|
|
|
impl FileRegionEngine {
|
|
pub fn new(_config: EngineConfig, object_store: ObjectStore) -> Self {
|
|
Self {
|
|
inner: Arc::new(EngineInner::new(object_store)),
|
|
}
|
|
}
|
|
|
|
async fn handle_query(
|
|
&self,
|
|
region_id: RegionId,
|
|
request: ScanRequest,
|
|
) -> Result<SendableRecordBatchStream, BoxedError> {
|
|
self.inner
|
|
.get_region(region_id)
|
|
.await
|
|
.context(RegionNotFoundSnafu { region_id })
|
|
.map_err(BoxedError::new)?
|
|
.query(request)
|
|
.map_err(BoxedError::new)
|
|
}
|
|
}
|
|
|
|
#[async_trait]
|
|
impl RegionEngine for FileRegionEngine {
|
|
fn name(&self) -> &str {
|
|
FILE_ENGINE
|
|
}
|
|
|
|
async fn handle_request(
|
|
&self,
|
|
region_id: RegionId,
|
|
request: RegionRequest,
|
|
) -> Result<RegionResponse, BoxedError> {
|
|
self.inner
|
|
.handle_request(region_id, request)
|
|
.await
|
|
.map_err(BoxedError::new)
|
|
}
|
|
|
|
async fn handle_query(
|
|
&self,
|
|
region_id: RegionId,
|
|
request: ScanRequest,
|
|
) -> Result<RegionScannerRef, BoxedError> {
|
|
let stream = self.handle_query(region_id, request).await?;
|
|
let metadata = self.get_metadata(region_id).await?;
|
|
// We don't support enabling append mode for file engine.
|
|
let scanner = Box::new(SinglePartitionScanner::new(stream, false, metadata));
|
|
Ok(scanner)
|
|
}
|
|
|
|
async fn get_metadata(&self, region_id: RegionId) -> Result<RegionMetadataRef, BoxedError> {
|
|
self.inner
|
|
.get_region(region_id)
|
|
.await
|
|
.map(|r| r.metadata())
|
|
.context(RegionNotFoundSnafu { region_id })
|
|
.map_err(BoxedError::new)
|
|
}
|
|
|
|
async fn stop(&self) -> Result<(), BoxedError> {
|
|
self.inner.stop().await.map_err(BoxedError::new)
|
|
}
|
|
|
|
fn region_statistic(&self, _: RegionId) -> Option<RegionStatistic> {
|
|
None
|
|
}
|
|
|
|
async fn get_committed_sequence(&self, _: RegionId) -> Result<SequenceNumber, BoxedError> {
|
|
Ok(Default::default())
|
|
}
|
|
|
|
fn set_region_role(&self, region_id: RegionId, role: RegionRole) -> Result<(), BoxedError> {
|
|
self.inner
|
|
.set_region_role(region_id, role)
|
|
.map_err(BoxedError::new)
|
|
}
|
|
|
|
async fn set_region_role_state_gracefully(
|
|
&self,
|
|
region_id: RegionId,
|
|
_region_role_state: SettableRegionRoleState,
|
|
) -> Result<SetRegionRoleStateResponse, BoxedError> {
|
|
let exists = self.inner.get_region(region_id).await.is_some();
|
|
|
|
if exists {
|
|
Ok(SetRegionRoleStateResponse::success(
|
|
SetRegionRoleStateSuccess::file(),
|
|
))
|
|
} else {
|
|
Ok(SetRegionRoleStateResponse::NotFound)
|
|
}
|
|
}
|
|
|
|
async fn sync_region(
|
|
&self,
|
|
_region_id: RegionId,
|
|
_manifest_info: RegionManifestInfo,
|
|
) -> Result<SyncManifestResponse, BoxedError> {
|
|
// File engine doesn't need to sync region manifest.
|
|
Ok(SyncManifestResponse::NotSupported)
|
|
}
|
|
|
|
fn role(&self, region_id: RegionId) -> Option<RegionRole> {
|
|
self.inner.state(region_id)
|
|
}
|
|
|
|
fn as_any(&self) -> &dyn Any {
|
|
self
|
|
}
|
|
}
|
|
|
|
struct EngineInner {
|
|
/// All regions opened by the engine.
|
|
///
|
|
/// Writing to `regions` should also hold the `region_mutex`.
|
|
regions: RwLock<HashMap<RegionId, FileRegionRef>>,
|
|
|
|
/// Region mutex is used to protect the operations such as creating/opening/closing
|
|
/// a region, to avoid things like opening the same region simultaneously.
|
|
region_mutex: Mutex<()>,
|
|
|
|
object_store: ObjectStore,
|
|
}
|
|
|
|
type EngineInnerRef = Arc<EngineInner>;
|
|
|
|
impl EngineInner {
|
|
fn new(object_store: ObjectStore) -> Self {
|
|
Self {
|
|
regions: RwLock::new(HashMap::new()),
|
|
region_mutex: Mutex::new(()),
|
|
object_store,
|
|
}
|
|
}
|
|
|
|
async fn handle_request(
|
|
&self,
|
|
region_id: RegionId,
|
|
request: RegionRequest,
|
|
) -> EngineResult<RegionResponse> {
|
|
let result = match request {
|
|
RegionRequest::Create(req) => self.handle_create(region_id, req).await,
|
|
RegionRequest::Drop(req) => self.handle_drop(region_id, req).await,
|
|
RegionRequest::Open(req) => self.handle_open(region_id, req).await,
|
|
RegionRequest::Close(req) => self.handle_close(region_id, req).await,
|
|
_ => UnsupportedSnafu {
|
|
operation: request.to_string(),
|
|
}
|
|
.fail(),
|
|
};
|
|
result.map(RegionResponse::new)
|
|
}
|
|
|
|
async fn stop(&self) -> EngineResult<()> {
|
|
let _lock = self.region_mutex.lock().await;
|
|
self.regions.write().unwrap().clear();
|
|
Ok(())
|
|
}
|
|
|
|
fn set_region_role(&self, _region_id: RegionId, _region_role: RegionRole) -> EngineResult<()> {
|
|
// TODO(zhongzc): Improve the semantics and implementation of this API.
|
|
Ok(())
|
|
}
|
|
|
|
fn state(&self, region_id: RegionId) -> Option<RegionRole> {
|
|
if self.regions.read().unwrap().get(®ion_id).is_some() {
|
|
Some(RegionRole::Leader)
|
|
} else {
|
|
None
|
|
}
|
|
}
|
|
}
|
|
|
|
impl EngineInner {
|
|
async fn handle_create(
|
|
&self,
|
|
region_id: RegionId,
|
|
request: RegionCreateRequest,
|
|
) -> EngineResult<AffectedRows> {
|
|
ensure!(
|
|
request.engine == FILE_ENGINE,
|
|
UnexpectedEngineSnafu {
|
|
engine: request.engine
|
|
}
|
|
);
|
|
|
|
if self.exists(region_id).await {
|
|
return Ok(0);
|
|
}
|
|
|
|
info!("Try to create region, region_id: {}", region_id);
|
|
|
|
let _lock = self.region_mutex.lock().await;
|
|
// Check again after acquiring the lock
|
|
if self.exists(region_id).await {
|
|
return Ok(0);
|
|
}
|
|
|
|
let res = FileRegion::create(region_id, request, &self.object_store).await;
|
|
let region = res.inspect_err(|err| {
|
|
error!(
|
|
err;
|
|
"Failed to create region, region_id: {}",
|
|
region_id
|
|
);
|
|
})?;
|
|
self.regions.write().unwrap().insert(region_id, region);
|
|
|
|
info!("A new region is created, region_id: {}", region_id);
|
|
Ok(0)
|
|
}
|
|
|
|
async fn handle_open(
|
|
&self,
|
|
region_id: RegionId,
|
|
request: RegionOpenRequest,
|
|
) -> EngineResult<AffectedRows> {
|
|
if self.exists(region_id).await {
|
|
return Ok(0);
|
|
}
|
|
|
|
info!("Try to open region, region_id: {}", region_id);
|
|
|
|
let _lock = self.region_mutex.lock().await;
|
|
// Check again after acquiring the lock
|
|
if self.exists(region_id).await {
|
|
return Ok(0);
|
|
}
|
|
|
|
let res = FileRegion::open(region_id, request, &self.object_store).await;
|
|
let region = res.inspect_err(|err| {
|
|
error!(
|
|
err;
|
|
"Failed to open region, region_id: {}",
|
|
region_id
|
|
);
|
|
})?;
|
|
self.regions.write().unwrap().insert(region_id, region);
|
|
|
|
info!("Region opened, region_id: {}", region_id);
|
|
Ok(0)
|
|
}
|
|
|
|
async fn handle_close(
|
|
&self,
|
|
region_id: RegionId,
|
|
_request: RegionCloseRequest,
|
|
) -> EngineResult<AffectedRows> {
|
|
let _lock = self.region_mutex.lock().await;
|
|
|
|
let mut regions = self.regions.write().unwrap();
|
|
if regions.remove(®ion_id).is_some() {
|
|
info!("Region closed, region_id: {}", region_id);
|
|
}
|
|
|
|
Ok(0)
|
|
}
|
|
|
|
async fn handle_drop(
|
|
&self,
|
|
region_id: RegionId,
|
|
_request: RegionDropRequest,
|
|
) -> EngineResult<AffectedRows> {
|
|
if !self.exists(region_id).await {
|
|
return RegionNotFoundSnafu { region_id }.fail();
|
|
}
|
|
|
|
info!("Try to drop region, region_id: {}", region_id);
|
|
|
|
let _lock = self.region_mutex.lock().await;
|
|
|
|
let region = self.get_region(region_id).await;
|
|
if let Some(region) = region {
|
|
let res = FileRegion::drop(®ion, &self.object_store).await;
|
|
res.inspect_err(|err| {
|
|
error!(
|
|
err;
|
|
"Failed to drop region, region_id: {}",
|
|
region_id
|
|
);
|
|
})?;
|
|
}
|
|
let _ = self.regions.write().unwrap().remove(®ion_id);
|
|
|
|
info!("Region dropped, region_id: {}", region_id);
|
|
Ok(0)
|
|
}
|
|
|
|
async fn get_region(&self, region_id: RegionId) -> Option<FileRegionRef> {
|
|
self.regions.read().unwrap().get(®ion_id).cloned()
|
|
}
|
|
|
|
async fn exists(&self, region_id: RegionId) -> bool {
|
|
self.regions.read().unwrap().contains_key(®ion_id)
|
|
}
|
|
}
|