mirror of
https://github.com/GreptimeTeam/greptimedb.git
synced 2026-01-08 14:22:58 +00:00
* feat: Adds ColumnDefaultConstraint::create_default_vector ColumnDefaultConstraint::create_default_vector is ported from MitoTable::try_get_column_default_constraint_vector. * refactor: Replace try_get_column_default_constraint_vector by create_default_vector * style: Remove unnecessary map_err in MitoTable::insert * feat: Adds compat_write For column in `dest_schema` but not in `write_batch`, this method would insert a vector with default value to the `write_batch`. If there are columns not in `dest_schema`, an error would be returned. * chore: Add info log to RegionInner::alter * feat(storage): RegionImpl::write support request with old version * feat: Add nullable check when creating default value * feat: Validate nullable and default value * chore: Modify PutOperation comments * chore: Make ColumnDescriptor::is_nullable readonly and validate name * feat: Use CompatWrite trait to replace campat::compat_write method Adds a CompactWrite trait to support padding columns to WriteBatch: - The WriteBatch and PutData implements this trait - Fix the issue that WriteBatch::schema is not updated to the schema after compat - Also validate the created column when adding to PutData The WriteBatch would also pad default value to missing columns in PutData, so the memtable inserter don't need to manually check whether the column is nullable and then insert a NullVector. All WriteBatch is ensured to have all columns defined by the schema in its PutData. * feat: Validate constraint by ColumnDefaultConstraint::validate() The ColumnDefaultConstraint::validate() would also ensure the default value has the same data type as the column's. * feat: Use NullVector for null columns * fix: Fix BinaryType returns wrong logical_type_id * fix: Fix tests and revert NullVector for null columns NullVector doesn't support custom logical type make it hard to encode/decode, which also cause the arrow/protobuf codec of write batch fail. * fix: create_default_vector use replicate to create vector with default value This would fix the test_codec_with_none_column_protobuf test, as we need to downcast the vector to construct the protobuf values. * test: add tests for column default constraints * test: Add tests for CompatWrite trait impl * test: Test write region with old schema * fix(storage): Fix replay() applies metadata too early The committed sequence of the RegionChange action is the sequence of the last entry that use the old metadata (schema). During replay, we should apply the new metadata after we see an entry that has sequence greater than (not equals to) the `RegionChange::committed_sequence` Also remove duplicate `set_committed_sequence()` call in persist_manifest_version() * chore: Removes some unreachable codes Also add more comments to document codes in these files * refactor: Refactor MitoTable::insert Return error if we could not create a default vector for given column, instead of ignoring the error * chore: Fix incorrect comments * chore: Fix typo in error message